mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-25 05:34:00 +08:00
8c0eb596ba
Avoid that the fcport structure gets leaked if bsg_job->request->msgcode == FC_BSG_HST_ELS_NOLOGIN, the fcport allocation succeeds and the !vha->flags.online branch is taken. This was detected by Coverity. However, Coverity does not recognize that all qla2x00_process_els() callers specify either FC_BSG_RPT_ELS or FC_BSG_HST_ELS_NOLOGIN in the field bsg_job->request->msgcode and that the value of that field is not modified inside that function. This results in a false positive report about a possible memory leak in an error path for bsg_job->request->msgcode values other than the two mentioned values. Make it easy for Coverity (and for humans) to recognize that there is no fcport leak in the error path by changing the bsg_job->request->msgcode == FC_BSG_HST_ELS_NOLOGIN test into bsg_job->request->msgcode != FC_BSG_RPT_ELS. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| qla_attr.c | ||
| qla_bsg.c | ||
| qla_bsg.h | ||
| qla_dbg.c | ||
| qla_dbg.h | ||
| qla_def.h | ||
| qla_devtbl.h | ||
| qla_dfs.c | ||
| qla_fw.h | ||
| qla_gbl.h | ||
| qla_gs.c | ||
| qla_init.c | ||
| qla_inline.h | ||
| qla_iocb.c | ||
| qla_isr.c | ||
| qla_mbx.c | ||
| qla_mid.c | ||
| qla_mr.c | ||
| qla_mr.h | ||
| qla_nx.c | ||
| qla_nx.h | ||
| qla_os.c | ||
| qla_settings.h | ||
| qla_sup.c | ||
| qla_target.c | ||
| qla_target.h | ||
| qla_version.h | ||
| tcm_qla2xxx.c | ||
| tcm_qla2xxx.h | ||