mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 20:53:53 +08:00
76f7ba35d4
I started playing with pahole today and decided to put it against the
selinux structures. Found we could save a little bit of space on x86_64
(and no harm on i686) just reorganizing some structs.
Object size changes:
av_inherit: 24 -> 16
selinux_class_perm: 48 -> 40
context: 80 -> 72
Admittedly there aren't many of av_inherit or selinux_class_perm's in
the kernel (33 and 1 respectively) But the change to the size of struct
context reverberate out a bit. I can get some hard number if they are
needed, but I don't see why they would be. We do change which cacheline
context->len and context->str would be on, but I don't see that as a
problem since we are clearly going to have to load both if the context
is to be of any value. I've run with the patch and don't seem to be
having any problems.
An example of what's going on using struct av_inherit would be:
form: to:
struct av_inherit { struct av_inherit {
u16 tclass; const char **common_pts;
const char **common_pts; u32 common_base;
u32 common_base; u16 tclass;
};
(notice all I did was move u16 tclass to the end of the struct instead
of the beginning)
Memory layout before the change:
struct av_inherit {
u16 tclass; /* 2 */
/* 6 bytes hole */
const char** common_pts; /* 8 */
u32 common_base; /* 4 */
/* 4 byes padding */
/* size: 24, cachelines: 1 */
/* sum members: 14, holes: 1, sum holes: 6 */
/* padding: 4 */
};
Memory layout after the change:
struct av_inherit {
const char ** common_pts; /* 8 */
u32 common_base; /* 4 */
u16 tclass; /* 2 */
/* 2 bytes padding */
/* size: 16, cachelines: 1 */
/* sum members: 14, holes: 0, sum holes: 0 */
/* padding: 2 */
};
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
36 lines
617 B
C
36 lines
617 B
C
/*
|
|
* Access vector cache interface for the security server.
|
|
*
|
|
* Author : Stephen Smalley, <sds@epoch.ncsc.mil>
|
|
*/
|
|
#ifndef _SELINUX_AVC_SS_H_
|
|
#define _SELINUX_AVC_SS_H_
|
|
|
|
#include "flask.h"
|
|
|
|
int avc_ss_reset(u32 seqno);
|
|
|
|
struct av_perm_to_string {
|
|
u16 tclass;
|
|
u32 value;
|
|
const char *name;
|
|
};
|
|
|
|
struct av_inherit {
|
|
const char **common_pts;
|
|
u32 common_base;
|
|
u16 tclass;
|
|
};
|
|
|
|
struct selinux_class_perm {
|
|
const struct av_perm_to_string *av_perm_to_string;
|
|
u32 av_pts_len;
|
|
u32 cts_len;
|
|
const char **class_to_string;
|
|
const struct av_inherit *av_inherit;
|
|
u32 av_inherit_len;
|
|
};
|
|
|
|
#endif /* _SELINUX_AVC_SS_H_ */
|
|
|