mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-25 21:54:06 +08:00
462cdace79
The current test for bio vec merging is not fully accurate and can be tricked into merging bios when certain grant combinations are used. The result of these malicious bio merges is a bio that extends past the memory page used by any of the originating bios. Take into account the following scenario, where a guest creates two grant references that point to the same mfn, ie: grant 1 -> mfn A, grant 2 -> mfn A. These references are then used in a PV block request, and mapped by the backend domain, thus obtaining two different pfns that point to the same mfn, pfn B -> mfn A, pfn C -> mfn A. If those grants happen to be used in two consecutive sectors of a disk IO operation becoming two different bios in the backend domain, the checks in xen_biovec_phys_mergeable will succeed, because bfn1 == bfn2 (they both point to the same mfn). However due to the bio merging, the backend domain will end up with a bio that expands past mfn A into mfn A + 1. Fix this by making sure the check in xen_biovec_phys_mergeable takes into account the offset and the length of the bio, this basically replicates whats done in __BIOVEC_PHYS_MERGEABLE using mfns (bus addresses). While there also remove the usage of __BIOVEC_PHYS_MERGEABLE, since that's already checked by the callers of xen_biovec_phys_mergeable. CC: stable@vger.kernel.org Reported-by: "Jan H. Schönherr" <jschoenh@amazon.de> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
23 lines
585 B
C
23 lines
585 B
C
#include <linux/bio.h>
|
|
#include <linux/io.h>
|
|
#include <linux/export.h>
|
|
#include <xen/page.h>
|
|
|
|
bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
|
|
const struct bio_vec *vec2)
|
|
{
|
|
#if XEN_PAGE_SIZE == PAGE_SIZE
|
|
unsigned long bfn1 = pfn_to_bfn(page_to_pfn(vec1->bv_page));
|
|
unsigned long bfn2 = pfn_to_bfn(page_to_pfn(vec2->bv_page));
|
|
|
|
return bfn1 + PFN_DOWN(vec1->bv_offset + vec1->bv_len) == bfn2;
|
|
#else
|
|
/*
|
|
* XXX: Add support for merging bio_vec when using different page
|
|
* size in Xen and Linux.
|
|
*/
|
|
return 0;
|
|
#endif
|
|
}
|
|
EXPORT_SYMBOL(xen_biovec_phys_mergeable);
|