Mike Snitzer f62b6b8f49 dm space map metadata: return on failure in sm_metadata_new_block ... Commit 2fc48021f4 ("dm persistent metadata: add space map threshold callback") introduced a regression to the metadata block allocation path that resulted in errors being ignored. This regression was uncovered by running the following device-mapper-test-suite test: dmtest run --suite thin-provisioning -n /exhausting_metadata_space_causes_fail_mode/ The ignored error codes in sm_metadata_new_block() could crash the kernel through use of either the dm-thin or dm-cache targets, e.g.: device-mapper: thin: 253:4: reached low water mark for metadata device: sending event. device-mapper: space map metadata: unable to allocate new metadata block general protection fault: 0000 [#1] SMP ... Workqueue: dm-thin do_worker [dm_thin_pool] task: ffff880035ce2ab0 ti: ffff88021a054000 task.ti: ffff88021a054000 RIP: 0010:[<ffffffffa0331385>] [<ffffffffa0331385>] metadata_ll_load_ie+0x15/0x30 [dm_persistent_data] RSP: 0018:ffff88021a055a68 EFLAGS: 00010202 RAX: 003fc8243d212ba0 RBX: ffff88021a780070 RCX: ffff88021a055a78 RDX: ffff88021a055a78 RSI: 0040402222a92a80 RDI: ffff88021a780070 RBP: ffff88021a055a68 R08: ffff88021a055ba4 R09: 0000000000000010 R10: 0000000000000000 R11: 00000002a02e1000 R12: ffff88021a055ad4 R13: 0000000000000598 R14: ffffffffa0338470 R15: ffff88021a055ba4 FS: 0000000000000000(0000) GS:ffff88033fca0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 00007f467c0291b8 CR3: 0000000001a0b000 CR4: 00000000000007e0 Stack: ffff88021a055ab8 ffffffffa0332020 ffff88021a055b30 0000000000000001 ffff88021a055b30 0000000000000000 ffff88021a055b18 0000000000000000 ffff88021a055ba4 ffff88021a055b98 ffff88021a055ae8 ffffffffa033304c Call Trace: [<ffffffffa0332020>] sm_ll_lookup_bitmap+0x40/0xa0 [dm_persistent_data] [<ffffffffa033304c>] sm_metadata_count_is_more_than_one+0x8c/0xc0 [dm_persistent_data] [<ffffffffa0333825>] dm_tm_shadow_block+0x65/0x110 [dm_persistent_data] [<ffffffffa0331b00>] sm_ll_mutate+0x80/0x300 [dm_persistent_data] [<ffffffffa0330e60>] ? set_ref_count+0x10/0x10 [dm_persistent_data] [<ffffffffa0331dba>] sm_ll_inc+0x1a/0x20 [dm_persistent_data] [<ffffffffa0332270>] sm_disk_new_block+0x60/0x80 [dm_persistent_data] [<ffffffff81520036>] ? down_write+0x16/0x40 [<ffffffffa001e5c4>] dm_pool_alloc_data_block+0x54/0x80 [dm_thin_pool] [<ffffffffa001b23c>] alloc_data_block+0x9c/0x130 [dm_thin_pool] [<ffffffffa001c27e>] provision_block+0x4e/0x180 [dm_thin_pool] [<ffffffffa001fe9a>] ? dm_thin_find_block+0x6a/0x110 [dm_thin_pool] [<ffffffffa001c57a>] process_bio+0x1ca/0x1f0 [dm_thin_pool] [<ffffffff8111e2ed>] ? mempool_free+0x8d/0xa0 [<ffffffffa001d755>] process_deferred_bios+0xc5/0x230 [dm_thin_pool] [<ffffffffa001d911>] do_worker+0x51/0x60 [dm_thin_pool] [<ffffffff81067872>] process_one_work+0x182/0x3b0 [<ffffffff81068c90>] worker_thread+0x120/0x3a0 [<ffffffff81068b70>] ? manage_workers+0x160/0x160 [<ffffffff8106eb2e>] kthread+0xce/0xe0 [<ffffffff8106ea60>] ? kthread_freezable_should_stop+0x70/0x70 [<ffffffff8152af6c>] ret_from_fork+0x7c/0xb0 [<ffffffff8106ea60>] ? kthread_freezable_should_stop+0x70/0x70 [<ffffffff8152af6c>] ret_from_fork+0x7c/0xb0 [<ffffffff8106ea60>] ? kthread_freezable_should_stop+0x70/0x70 Signed-off-by: Mike Snitzer <snitzer@redhat.com> Acked-by: Joe Thornber <ejt@redhat.com> Cc: stable@vger.kernel.org # v3.10+		2013-12-10 16:34:28 -05:00
..
bcache	bcache: Fix a null ptr deref regression	2013-10-10 18:17:39 -07:00
persistent-data	dm space map metadata: return on failure in sm_metadata_new_block	2013-12-10 16:34:28 -05:00
bitmap.c	md: replace strict_strto*() with kstrto*()	2013-06-14 08:10:26 +10:00
bitmap.h	md/bitmap: record the space available for the bitmap in the superblock.	2012-05-22 13:55:34 +10:00
dm-bio-prison.c	dm: add cache target	2013-03-01 22:45:51 +00:00
dm-bio-prison.h	dm: add cache target	2013-03-01 22:45:51 +00:00
dm-bio-record.h
dm-bufio.c	drivers: convert shrinkers to new count/scan API	2013-09-10 18:56:32 -04:00
dm-bufio.h	dm bufio: prefetch	2012-03-28 18:41:29 +01:00
dm-cache-block-types.h	dm: add cache target	2013-03-01 22:45:51 +00:00
dm-cache-metadata.c	dm cache metadata: check the metadata version when reading the superblock	2013-11-11 11:37:49 -05:00
dm-cache-metadata.h	dm cache: add passthrough mode	2013-11-11 11:37:49 -05:00
dm-cache-policy-cleaner.c	dm cache: policy change version from string to integer set	2013-03-20 17:21:27 +00:00
dm-cache-policy-internal.h	dm cache: add remove_cblock method to policy interface	2013-11-11 11:37:50 -05:00
dm-cache-policy-mq.c	dm cache: resolve small nits and improve Documentation	2013-11-12 13:11:09 -05:00
dm-cache-policy.c	dm cache: return -EINVAL if the user specifies unknown cache policy	2013-11-09 18:20:18 -05:00
dm-cache-policy.h	dm cache: add remove_cblock method to policy interface	2013-11-11 11:37:50 -05:00
dm-cache-target.c	dm cache: resolve small nits and improve Documentation	2013-11-12 13:11:09 -05:00
dm-crypt.c	dm crypt: add TCW IV mode for old CBC TCRYPT containers	2013-11-09 18:20:20 -05:00
dm-delay.c	dm delay: fix a possible deadlock due to shared workqueue	2013-11-18 11:23:21 -05:00
dm-exception-store.c	dm: replace simple_strtoul	2012-07-27 15:07:59 +01:00
dm-exception-store.h
dm-flakey.c	dm flakey: correct ctr alloc failure mesg	2013-07-10 23:41:17 +01:00
dm-io.c	dm: add reserved_bio_based_ios module parameter	2013-09-23 10:42:24 -04:00
dm-ioctl.c	dm: allow remove to be deferred	2013-11-09 18:20:22 -05:00
dm-kcopyd.c	dm: stop using WQ_NON_REENTRANT	2013-08-23 09:02:13 -04:00
dm-linear.c	dm: rename request variables to bios	2013-03-01 22:45:47 +00:00
dm-log-userspace-base.c
dm-log-userspace-transfer.c	connector/userns: replace netlink uses of cap_raised() with capable()	2012-05-10 23:21:39 -04:00
dm-log-userspace-transfer.h
dm-log.c	dm: use memweight()	2012-07-30 17:25:16 -07:00
dm-mpath.c	dm mpath: requeue I/O during pg_init	2013-11-05 11:20:34 -05:00
dm-mpath.h
dm-path-selector.c
dm-path-selector.h
dm-queue-length.c	dm: reject trailing characters in sccanf input	2012-03-28 18:41:26 +01:00
dm-raid1.c	dm: stop using WQ_NON_REENTRANT	2013-08-23 09:02:13 -04:00
dm-raid.c	MD: Remember the last sync operation that was performed	2013-06-26 12:38:24 +10:00
dm-region-hash.c	dm raid1: fix crash with mirror recovery and discard	2012-07-20 14:25:03 +01:00
dm-round-robin.c	dm: reject trailing characters in sccanf input	2012-03-28 18:41:26 +01:00
dm-service-time.c	dm: reject trailing characters in sccanf input	2012-03-28 18:41:26 +01:00
dm-snap-persistent.c	dm snapshot: workaround for a false positive lockdep warning	2013-09-20 10:36:34 -04:00
dm-snap-transient.c
dm-snap.c	dm snapshot: avoid snapshot space leak on crash	2013-12-10 16:34:25 -05:00
dm-stats.c	dm stats: fix possible counter corruption on 32-bit systems	2013-09-18 14:41:06 -04:00
dm-stats.h	dm: add statistics support	2013-09-05 20:46:06 -04:00
dm-stripe.c	dm stripe: silence a couple sparse warnings	2013-09-06 11:36:01 -04:00
dm-switch.c	dm: add switch target	2013-07-10 23:41:19 +01:00
dm-sysfs.c
dm-table.c	dm table: fail dm_table_create on dm_round_up overflow	2013-12-10 16:34:27 -05:00
dm-target.c	dm: allow error target to replace bio-based and request-based targets	2013-09-05 20:46:05 -04:00
dm-thin-metadata.c	dm thin: generate event when metadata threshold passed	2013-05-10 14:37:21 +01:00
dm-thin-metadata.h	dm thin: generate event when metadata threshold passed	2013-05-10 14:37:21 +01:00
dm-thin.c	dm thin: do not expose non-zero discard limits if discards disabled	2013-09-23 10:42:06 -04:00
dm-uevent.c
dm-uevent.h
dm-verity.c	dm verity: use __ffs and __fls	2013-07-10 23:41:17 +01:00
dm-zero.c	dm: rename request variables to bios	2013-03-01 22:45:47 +00:00
dm.c	dm: allow remove to be deferred	2013-11-09 18:20:22 -05:00
dm.h	dm: allow remove to be deferred	2013-11-09 18:20:22 -05:00
faulty.c	block: Add bio_end_sector()	2013-03-23 14:15:29 -07:00
Kconfig	dm: fix Kconfig menu indentation	2013-11-09 18:20:22 -05:00
linear.c	block: Add bio_end_sector()	2013-03-23 14:15:29 -07:00
linear.h
Makefile	dm: add statistics support	2013-09-05 20:46:06 -04:00
md.c	md: avoid deadlock when dirty buffers during md_stop.	2013-08-27 16:45:00 +10:00
md.h	md: avoid deadlock when dirty buffers during md_stop.	2013-08-27 16:45:00 +10:00
multipath.c	MD: change the parameter of md thread	2012-10-11 13:34:00 +11:00
multipath.h
raid0.c	md: fix buglet in RAID5 -> RAID0 conversion.	2013-06-26 12:38:19 +10:00
raid0.h
raid1.c	md/raid1: fix bio handling problems in process_checks()	2013-07-18 14:18:04 +10:00
raid1.h	md/raid1: prevent merging too large request	2012-07-31 10:03:53 +10:00
raid5.c	raid5: only wakeup necessary threads	2013-09-02 10:31:29 +10:00
raid5.h	raid5: only wakeup necessary threads	2013-09-02 10:31:29 +10:00
raid10.c	md/raid10: remove use-after-free bug.	2013-07-25 16:46:53 +10:00
raid10.h	MD RAID10: Improve redundancy for 'far' and 'offset' algorithms (part 1)	2013-02-26 11:55:30 +11:00