mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-24 21:24:00 +08:00
0683d5035c
The init functions do not return any error. They behave as the following:
- panic, thus leading to a kernel crash while another timer may work and
make the system boot up correctly
or
- print an error and leave the caller unaware of the state of the system
Change that by converting the init functions to return an error conforming
to the CLOCKSOURCE_OF_RET prototype.
Proper error handling (rollback, errno value) will be changed later case
by case, thus this change just returns an error code from the init function.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
57 lines
1.3 KiB
C
57 lines
1.3 KiB
C
#include <linux/clocksource.h>
|
|
#include <linux/sched_clock.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/printk.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/init.h>
|
|
#include <linux/clk.h>
|
|
|
|
static void __iomem *xtal_in_cnt;
|
|
static struct delay_timer delay_timer;
|
|
|
|
static unsigned long notrace read_xtal_counter(void)
|
|
{
|
|
return readl_relaxed(xtal_in_cnt);
|
|
}
|
|
|
|
static u64 notrace read_sched_clock(void)
|
|
{
|
|
return read_xtal_counter();
|
|
}
|
|
|
|
static int __init tango_clocksource_init(struct device_node *np)
|
|
{
|
|
struct clk *clk;
|
|
int xtal_freq, ret;
|
|
|
|
xtal_in_cnt = of_iomap(np, 0);
|
|
if (xtal_in_cnt == NULL) {
|
|
pr_err("%s: invalid address\n", np->full_name);
|
|
return -ENXIO;
|
|
}
|
|
|
|
clk = of_clk_get(np, 0);
|
|
if (IS_ERR(clk)) {
|
|
pr_err("%s: invalid clock\n", np->full_name);
|
|
return PTR_ERR(clk);
|
|
}
|
|
|
|
xtal_freq = clk_get_rate(clk);
|
|
delay_timer.freq = xtal_freq;
|
|
delay_timer.read_current_timer = read_xtal_counter;
|
|
|
|
ret = clocksource_mmio_init(xtal_in_cnt, "tango-xtal", xtal_freq, 350,
|
|
32, clocksource_mmio_readl_up);
|
|
if (ret) {
|
|
pr_err("%s: registration failed\n", np->full_name);
|
|
return ret;
|
|
}
|
|
|
|
sched_clock_register(read_sched_clock, 32, xtal_freq);
|
|
register_current_timer_delay(&delay_timer);
|
|
|
|
return 0;
|
|
}
|
|
|
|
CLOCKSOURCE_OF_DECLARE_RET(tango, "sigma,tick-counter", tango_clocksource_init);
|