mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-16 17:23:55 +08:00
c67d734975
Fixes segmentation fault when trying to obtain buildid list (e.g. via
perf-archive) from a zstd-compressed `perf.data` file:
```
$ perf record -z ls
...
[ perf record: Captured and wrote 0,010 MB perf.data, compressed (original 0,001 MB, ratio is 2,190) ]
$ memcheck perf buildid-list
...
==57268== Invalid read of size 4
==57268== at 0x5260D88: ZSTD_decompressStream (in /usr/lib/libzstd.so.1.4.9)
==57268== by 0x4BB51B: zstd_decompress_stream (zstd.c:100)
==57268== by 0x425C6C: perf_session__process_compressed_event (session.c:73)
==57268== by 0x427450: perf_session__process_user_event (session.c:1631)
==57268== by 0x42A609: reader__process_events (session.c:2207)
==57268== by 0x42A609: __perf_session__process_events (session.c:2264)
==57268== by 0x42A609: perf_session__process_events (session.c:2297)
==57268== by 0x343A62: perf_session__list_build_ids (builtin-buildid-list.c:88)
==57268== by 0x343A62: cmd_buildid_list (builtin-buildid-list.c:120)
==57268== by 0x3C7732: run_builtin (perf.c:313)
==57268== by 0x331157: handle_internal_command (perf.c:365)
==57268== by 0x331157: run_argv (perf.c:409)
==57268== by 0x331157: main (perf.c:539)
==57268== Address 0x7470 is not stack'd, malloc'd or (recently) free'd
```
Signed-off-by: Milian Wolff <milian.wolff@kdab.com>
Cc: Alexey Budankov <alexey.budankov@linux.intel.com>
Link: http://lore.kernel.org/lkml/20210429185759.59870-1-milian.wolff@kdab.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
125 lines
3.2 KiB
C
125 lines
3.2 KiB
C
/*
|
|
* builtin-buildid-list.c
|
|
*
|
|
* Builtin buildid-list command: list buildids in perf.data, in the running
|
|
* kernel and in ELF files.
|
|
*
|
|
* Copyright (C) 2009, Red Hat Inc.
|
|
* Copyright (C) 2009, Arnaldo Carvalho de Melo <acme@redhat.com>
|
|
*/
|
|
#include "builtin.h"
|
|
#include "perf.h"
|
|
#include "util/build-id.h"
|
|
#include "util/debug.h"
|
|
#include "util/dso.h"
|
|
#include <subcmd/pager.h>
|
|
#include <subcmd/parse-options.h>
|
|
#include "util/session.h"
|
|
#include "util/symbol.h"
|
|
#include "util/data.h"
|
|
#include <errno.h>
|
|
#include <linux/err.h>
|
|
|
|
static int sysfs__fprintf_build_id(FILE *fp)
|
|
{
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
|
int ret;
|
|
|
|
ret = sysfs__sprintf_build_id("/", sbuild_id);
|
|
if (ret != sizeof(sbuild_id))
|
|
return ret < 0 ? ret : -EINVAL;
|
|
|
|
return fprintf(fp, "%s\n", sbuild_id);
|
|
}
|
|
|
|
static int filename__fprintf_build_id(const char *name, FILE *fp)
|
|
{
|
|
char sbuild_id[SBUILD_ID_SIZE];
|
|
int ret;
|
|
|
|
ret = filename__sprintf_build_id(name, sbuild_id);
|
|
if (ret != sizeof(sbuild_id))
|
|
return ret < 0 ? ret : -EINVAL;
|
|
|
|
return fprintf(fp, "%s\n", sbuild_id);
|
|
}
|
|
|
|
static bool dso__skip_buildid(struct dso *dso, int with_hits)
|
|
{
|
|
return with_hits && !dso->hit;
|
|
}
|
|
|
|
static int perf_session__list_build_ids(bool force, bool with_hits)
|
|
{
|
|
struct perf_session *session;
|
|
struct perf_data data = {
|
|
.path = input_name,
|
|
.mode = PERF_DATA_MODE_READ,
|
|
.force = force,
|
|
};
|
|
|
|
symbol__elf_init();
|
|
/*
|
|
* See if this is an ELF file first:
|
|
*/
|
|
if (filename__fprintf_build_id(input_name, stdout) > 0)
|
|
goto out;
|
|
|
|
session = perf_session__new(&data, false, &build_id__mark_dso_hit_ops);
|
|
if (IS_ERR(session))
|
|
return PTR_ERR(session);
|
|
|
|
/*
|
|
* We take all buildids when the file contains AUX area tracing data
|
|
* because we do not decode the trace because it would take too long.
|
|
*/
|
|
if (!perf_data__is_pipe(&data) &&
|
|
perf_header__has_feat(&session->header, HEADER_AUXTRACE))
|
|
with_hits = false;
|
|
|
|
if (!perf_header__has_feat(&session->header, HEADER_BUILD_ID))
|
|
with_hits = true;
|
|
|
|
if (zstd_init(&(session->zstd_data), 0) < 0)
|
|
pr_warning("Decompression initialization failed. Reported data may be incomplete.\n");
|
|
|
|
/*
|
|
* in pipe-mode, the only way to get the buildids is to parse
|
|
* the record stream. Buildids are stored as RECORD_HEADER_BUILD_ID
|
|
*/
|
|
if (with_hits || perf_data__is_pipe(&data))
|
|
perf_session__process_events(session);
|
|
|
|
perf_session__fprintf_dsos_buildid(session, stdout, dso__skip_buildid, with_hits);
|
|
perf_session__delete(session);
|
|
out:
|
|
return 0;
|
|
}
|
|
|
|
int cmd_buildid_list(int argc, const char **argv)
|
|
{
|
|
bool show_kernel = false;
|
|
bool with_hits = false;
|
|
bool force = false;
|
|
const struct option options[] = {
|
|
OPT_BOOLEAN('H', "with-hits", &with_hits, "Show only DSOs with hits"),
|
|
OPT_STRING('i', "input", &input_name, "file", "input file name"),
|
|
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
|
|
OPT_BOOLEAN('k', "kernel", &show_kernel, "Show current kernel build id"),
|
|
OPT_INCR('v', "verbose", &verbose, "be more verbose"),
|
|
OPT_END()
|
|
};
|
|
const char * const buildid_list_usage[] = {
|
|
"perf buildid-list [<options>]",
|
|
NULL
|
|
};
|
|
|
|
argc = parse_options(argc, argv, options, buildid_list_usage, 0);
|
|
setup_pager();
|
|
|
|
if (show_kernel)
|
|
return !(sysfs__fprintf_build_id(stdout) > 0);
|
|
|
|
return perf_session__list_build_ids(force, with_hits);
|
|
}
|