Dave Chinner e09f98606d xfs: xfs_swap_extents needs to handle dynamic fork offsets ... When swapping extents, we can corrupt inodes by swapping data forks that are in incompatible formats. This is caused by the two indoes having different fork offsets due to the presence of an attribute fork on an attr2 filesystem. xfs_fsr tries to be smart about setting the fork offset, but the trick it plays only works on attr1 (old fixed format attribute fork) filesystems. Changing the way xfs_fsr sets up the attribute fork will prevent this situation from ever occurring, so in the kernel code we can get by with a preventative fix - check that the data fork in the defragmented inode is in a format valid for the inode it is being swapped into. This will lead to files that will silently and potentially repeatedly fail defragmentation, so issue a warning to the log when this particular failure occurs to let us know that xfs_fsr needs updating/fixing. To help identify how to improve xfs_fsr to avoid this issue, add trace points for the inodes being swapped so that we can determine why the swap was rejected and to confirm that the code is making the right decisions and modifications when swapping forks. A further complication is even when the swap is allowed to proceed when the fork offset is different between the two inodes then value for the maximum number of extents the data fork can hold can be wrong. Make sure these are also set correctly after the swap occurs. Signed-off-by: Dave Chinner <david@fromorbit.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com>		2010-01-15 13:49:07 -06:00
..
linux-2.6	xfs: reclaim all inodes by background tree walks	2010-01-15 13:44:44 -06:00
quota	xfs: reclaim inodes under a write lock	2010-01-15 13:43:55 -06:00
support	xfs: event tracing support	2009-12-14 23:08:16 -06:00
Kconfig	xfs: use generic Posix ACL code	2009-06-10 17:07:47 +02:00
Makefile	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_acl.h	sanitize xattr handler prototypes	2009-12-16 12:16:49 -05:00
xfs_ag.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_alloc_btree.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_alloc_btree.h	[XFS] Always use struct xfs_btree_block instead of short / longform	2008-10-30 17:14:34 +11:00
xfs_alloc.c	xfs: Ensure we force all busy extents in range to disk	2010-01-10 12:22:02 -06:00
xfs_alloc.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_arch.h	xfs: use generic Posix ACL code	2009-06-10 17:07:47 +02:00
xfs_attr_leaf.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_attr_leaf.h	[XFS] Remove macro-to-function indirections in attr code	2009-01-09 15:46:44 +11:00
xfs_attr_sf.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_attr.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_attr.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_bit.c	[XFS] Use the generic bitops rather than implementing them ourselves.	2008-08-13 15:41:12 +10:00
xfs_bit.h	[XFS] Remove macro-to-function indirections in the mask code	2009-01-09 15:53:54 +11:00
xfs_bmap_btree.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_bmap_btree.h	xfs: kill xfs_bmbt_rec_32/64 types	2009-12-16 13:41:20 -06:00
xfs_bmap.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_bmap.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_btree_trace.c	[XFS] make btree tracing generic	2008-10-30 16:58:50 +11:00
xfs_btree_trace.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_btree.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_btree.h	xfs: add more statics & drop some unused functions	2009-08-31 14:46:20 -05:00
xfs_buf_item.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_buf_item.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_da_btree.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_da_btree.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_dfrag.c	xfs: xfs_swap_extents needs to handle dynamic fork offsets	2010-01-15 13:49:07 -06:00
xfs_dfrag.h	[XFS] Move copy_from_user calls out of ioctl helpers into ioctl switch.	2008-12-02 17:08:01 +11:00
xfs_dinode.h	xfs: remove m_litino	2009-03-29 09:51:14 +02:00
xfs_dir2_block.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_dir2_block.h	[XFS] use filldir internally	2007-10-15 16:49:49 +10:00
xfs_dir2_data.c	[XFS] Name operation vector for hash and compare	2008-07-28 16:58:36 +10:00
xfs_dir2_data.h	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_dir2_leaf.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_dir2_leaf.h	[XFS] use filldir internally	2007-10-15 16:49:49 +10:00
xfs_dir2_node.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_dir2_node.h
xfs_dir2_sf.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_dir2_sf.h	[XFS] kill xfs_dinode_core_t	2008-12-01 11:37:35 +11:00
xfs_dir2.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_dir2.h	[XFS] Return case-insensitive match for dentry cache	2008-07-28 16:58:40 +10:00
xfs_dmapi.h	removed unused #include <linux/version.h>'s	2008-08-23 12:14:12 -07:00
xfs_dmops.c	[XFS] kill struct xfs_mount_args	2008-10-30 17:53:24 +11:00
xfs_error.c	[XFS] avoid memory allocations in xfs_fs_vcmn_err	2008-12-22 18:02:01 +11:00
xfs_error.h	[XFS] avoid memory allocations in xfs_fs_vcmn_err	2008-12-22 18:02:01 +11:00
xfs_extfree_item.c	[XFS] Finish removing the mount pointer from the AIL API	2008-10-30 17:39:58 +11:00
xfs_extfree_item.h	[XFS] remove always-true #ifndef HAVE_FORMAT32 tests	2009-01-22 14:07:31 +11:00
xfs_filestream.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_filestream.h	xfs: kill the STATIC_INLINE macro	2009-12-11 15:11:22 -06:00
xfs_fs.h	trivial: fix typo "for for" in multiple files	2009-09-21 15:14:54 +02:00
xfs_fsops.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_fsops.h	filesystem freeze: add error handling of write_super_lockfs/unlockfs	2009-01-09 16:54:42 -08:00
xfs_ialloc_btree.c	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_ialloc_btree.h	xfs: remove superflous inobt macros	2009-02-09 08:37:14 +01:00
xfs_ialloc.c	xfs: kill the STATIC_INLINE macro	2009-12-11 15:11:22 -06:00
xfs_ialloc.h	xfs: rationalize xfs_inobt_lookup*	2009-09-01 12:45:39 -05:00
xfs_iget.c	xfs: Remove inode iolock held check during allocation	2010-01-15 13:45:33 -06:00
xfs_inode_item.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_inode_item.h	xfs: kill xfs_bmbt_rec_32/64 types	2009-12-16 13:41:20 -06:00
xfs_inode.c	xfs: fix stale inode flush avoidance	2010-01-15 13:46:02 -06:00
xfs_inode.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_inum.h	xfs: remove XFS_INO64_OFFSET	2009-08-31 14:46:22 -05:00
xfs_iomap.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_iomap.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_itable.c	xfs: implement ->dirty_inode to fix timestamp handling	2009-10-08 12:00:03 -05:00
xfs_itable.h	xfs: add more statics & drop some unused functions	2009-08-31 14:46:20 -05:00
xfs_log_priv.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_log_recover.c	Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs	2009-12-15 09:12:43 -08:00
xfs_log_recover.h
xfs_log.c	xfs: improve metadata I/O merging in the elevator	2009-12-16 13:41:19 -06:00
xfs_log.h	xfs: cleanup log unmount handling	2009-03-16 08:19:29 +01:00
xfs_mount.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_mount.h	xfs: cleanup dmapi macros in the umount path	2009-12-11 15:11:23 -06:00
xfs_mru_cache.c	xfs: add more statics & drop some unused functions	2009-08-31 14:46:20 -05:00
xfs_mru_cache.h	xfs: add more statics & drop some unused functions	2009-08-31 14:46:20 -05:00
xfs_quota.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_refcache.h
xfs_rename.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_rtalloc.c	xfs: fix missing error check in xfs_rtfree_range	2010-01-15 13:46:19 -06:00
xfs_rtalloc.h	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_rw.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_rw.h	xfs: uninline xfs_get_extsz_hint	2009-12-11 15:11:22 -06:00
xfs_sb.h	[XFS] Remove the rest of the macro-to-function indirections.	2009-01-19 14:45:55 +11:00
xfs_trans_ail.c	xfs: copy li_lsn before dropping AIL lock	2009-11-17 10:26:49 -06:00
xfs_trans_buf.c	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_trans_extfree.c	[XFS] Radix tree based inode caching	2007-10-15 16:50:50 +10:00
xfs_trans_inode.c	xfs: simplify xfs_trans_iget	2009-09-01 12:46:16 -05:00
xfs_trans_item.c	xfs: fix various typos	2009-03-29 09:55:42 +02:00
xfs_trans_priv.h	[XFS] Finish removing the mount pointer from the AIL API	2008-10-30 17:39:58 +11:00
xfs_trans_space.h	xfs: remove superflous inobt macros	2009-02-09 08:37:14 +01:00
xfs_trans.c	xfs: I/O completion handlers must use NOFS allocations	2009-12-11 15:11:20 -06:00
xfs_trans.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00
xfs_types.h	xfs: remove uchar_t/ushort_t/uint_t/ulong_t types	2009-02-09 08:37:39 +01:00
xfs_utils.c	xfs: kill xfs_qmops	2009-06-08 15:33:32 +02:00
xfs_utils.h	[XFS] implement IHOLD/IRELE directly	2008-08-13 16:13:45 +10:00
xfs_vnodeops.c	xfs: fix timestamp handling in xfs_setattr	2010-01-10 12:21:58 -06:00
xfs_vnodeops.h	xfs: simplify inode teardown	2009-12-11 15:11:19 -06:00
xfs.h	xfs: event tracing support	2009-12-14 23:08:16 -06:00