mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-29 23:53:55 +08:00
998c2034c6
Kbuild test robot reports the following problem on ARM:
for 'xen_setup_callback_vector' [-Wmissing-prototypes]
1664 | void xen_setup_callback_vector(void) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
The problem is that xen_setup_callback_vector is a x86 only thing, its
definition is present in arch/x86/xen/xen-ops.h but not on ARM. In
events_base.c there is a stub for !CONFIG_XEN_PVHVM but it is not declared
as 'static'.
On x86 the situation is hardly better: drivers/xen/events/events_base.c
doesn't include 'xen-ops.h' from arch/x86/xen/, it includes its namesake
from include/xen/ which also results in a 'no previous prototype' warning.
Currently, xen_setup_callback_vector() has two call sites: one in
drivers/xen/events_base.c and another in arch/x86/xen/suspend_hvm.c. The
former is placed under #ifdef CONFIG_X86 and the later is only compiled
in when CONFIG_XEN_PVHVM.
Resolve the issue by moving xen_setup_callback_vector() declaration to
arch neutral 'include/xen/hvm.h' as the implementation lives in arch
neutral drivers/xen/events/events_base.c.
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lkml.kernel.org/r/20200520161600.361895-1-vkuznets@redhat.com
64 lines
1.3 KiB
C
64 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Simple wrappers around HVM functions */
|
|
#ifndef XEN_HVM_H__
|
|
#define XEN_HVM_H__
|
|
|
|
#include <xen/interface/hvm/params.h>
|
|
#include <asm/xen/hypercall.h>
|
|
|
|
static const char *param_name(int op)
|
|
{
|
|
#define PARAM(x) [HVM_PARAM_##x] = #x
|
|
static const char *const names[] = {
|
|
PARAM(CALLBACK_IRQ),
|
|
PARAM(STORE_PFN),
|
|
PARAM(STORE_EVTCHN),
|
|
PARAM(PAE_ENABLED),
|
|
PARAM(IOREQ_PFN),
|
|
PARAM(BUFIOREQ_PFN),
|
|
PARAM(TIMER_MODE),
|
|
PARAM(HPET_ENABLED),
|
|
PARAM(IDENT_PT),
|
|
PARAM(DM_DOMAIN),
|
|
PARAM(ACPI_S_STATE),
|
|
PARAM(VM86_TSS),
|
|
PARAM(VPT_ALIGN),
|
|
PARAM(CONSOLE_PFN),
|
|
PARAM(CONSOLE_EVTCHN),
|
|
};
|
|
#undef PARAM
|
|
|
|
if (op >= ARRAY_SIZE(names))
|
|
return "unknown";
|
|
|
|
if (!names[op])
|
|
return "reserved";
|
|
|
|
return names[op];
|
|
}
|
|
static inline int hvm_get_parameter(int idx, uint64_t *value)
|
|
{
|
|
struct xen_hvm_param xhv;
|
|
int r;
|
|
|
|
xhv.domid = DOMID_SELF;
|
|
xhv.index = idx;
|
|
r = HYPERVISOR_hvm_op(HVMOP_get_param, &xhv);
|
|
if (r < 0) {
|
|
pr_err("Cannot get hvm parameter %s (%d): %d!\n",
|
|
param_name(idx), idx, r);
|
|
return r;
|
|
}
|
|
*value = xhv.value;
|
|
return r;
|
|
}
|
|
|
|
#define HVM_CALLBACK_VIA_TYPE_VECTOR 0x2
|
|
#define HVM_CALLBACK_VIA_TYPE_SHIFT 56
|
|
#define HVM_CALLBACK_VECTOR(x) (((uint64_t)HVM_CALLBACK_VIA_TYPE_VECTOR)<<\
|
|
HVM_CALLBACK_VIA_TYPE_SHIFT | (x))
|
|
|
|
void xen_setup_callback_vector(void);
|
|
|
|
#endif /* XEN_HVM_H__ */
|