Neil Horman dc5a144991 sis900: Allocate rx replacement buffer before rx operation ... Just found a hole in my last patch. It was reported to me that shortly after we integrated this patch. The report was of an oops that took place inside of netif_rx when using the sis900 driver. Looking at my origional patch I noted that there was a spot between the new skb_alloc and the refill_rx_ring label where skb got reassigned to the pointer currently held in the rx_ring for the purposes of receiveing the frame. The result of this is however that the buffer that gets passed to netif_rx (if it is called), then gets placed right back into the rx_ring. So if you receive frames fast enough the skb being processed by the network stack can get corrupted. The reporter is testing out the fix I've written for this below (I'm not near my hardware at the moment to test myself), but I wanted to post it for review ASAP. I'll post test results when I hear them, but I think this is a pretty straightforward fix. It just uses a separate pointer to do the rx operation, so that we don't improperly reassign the pointer that we use to refill the rx ring. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>		2007-04-27 20:16:41 -04:00
..
acorn	[ARM] Acorn: move the i2c bus driver into drivers/i2c	2007-03-04 20:40:50 +00:00
acpi	acpi-thermal: fix mod_timer() interval	2007-04-24 08:23:08 -07:00
amba	uevent: use add_uevent_var() instead of open coding it	2007-04-27 10:57:29 -07:00
ata	pata_sis: Fix oops on boot	2007-04-19 19:20:52 -04:00
atm	[ATM]: Use mutex instead of binary semaphore in FORE Systems 200E-series driver	2007-04-26 01:41:49 -07:00
auxdisplay	[PATCH] cfag12864b: fix crash when built-in and no parport present	2007-02-20 17:10:14 -08:00
base	drivers/base/attribute_container.c: use mutex instead of binary semaphore	2007-04-27 10:57:34 -07:00
block	ub: Bind to first endpoint, not to last	2007-04-27 13:28:34 -07:00
bluetooth	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	2007-04-25 22:28:23 -07:00
cdrom	[PATCH] Fix soft lockup with iSeries viocd driver	2007-03-05 07:57:51 -08:00
char	[NET]: random functions can use nsec resolution instead of usec	2007-04-25 22:28:25 -07:00
clocksource	[PATCH] correct slow acpi_pm rating	2007-03-27 09:05:15 -07:00
connector	[NETLINK]: Switch cb_lock spinlock to mutex and allow to override it	2007-04-25 22:29:03 -07:00
cpufreq	[PATCH] Fix maxcpus=1 trigerring BUG() in cpufreq	2007-03-27 08:55:56 -07:00
crypto	[PATCH] geode-aes: use unsigned long for spin_lock_irqsave	2007-03-06 09:30:25 -08:00
dio
dma	[PATCH] rm pointless dmaengine exports	2007-03-16 19:25:03 -07:00
edac	[PATCH] EDAC: Add Fully-Buffered DIMM APIs to core	2007-02-12 09:48:32 -08:00
eisa	[PATCH] drivers/eisa/pci_eisa.c:pci_eisa_init() should be init	2007-03-27 09:05:15 -07:00
fc4	[PATCH] remove many unneeded #includes of sched.h	2007-02-14 08:09:54 -08:00
firmware
hid	HID: Do not discard truncated input reports	2007-04-05 16:06:30 +02:00
hwmon	hwmon/w83627ehf: Don't redefine REGION_OFFSET	2007-04-24 08:23:08 -07:00
i2c	Minor bug fixes to i2c-pasemi	2007-04-17 16:36:28 -07:00
ide	IDE: remove rwsem use from ide-proc core	2007-04-27 10:57:30 -07:00
ieee1394	IEEE1394: remove rwsem use from ieee1394 core	2007-04-27 10:57:30 -07:00
infiniband	Merge branch 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband	2007-04-27 09:39:27 -07:00
input	Input: gameport - do not touch bus's rwsem	2007-04-27 10:57:30 -07:00
isdn	[SK_BUFF]: Introduce skb_copy_to_linear_data{_offset}	2007-04-25 22:28:29 -07:00
kvm	KVM: Fix off-by-one when writing to a nonpae guest pde	2007-04-19 18:39:26 +03:00
leds	leds: Add support for Cobalt Server front LED	2007-02-15 21:37:29 +00:00
macintosh	drivers/macintosh/smu.c: fix locking snafu	2007-04-17 16:36:27 -07:00
mca
md	[PATCH] md: fix calculation for size of filemap_attr array in md/bitmap	2007-04-12 15:31:42 -07:00
media	V4L/DVB (5563): Radio-maestro.c Replace radio_ioctl to use video_ioctl2	2007-04-27 15:46:01 -03:00
message	[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}	2007-04-25 22:28:23 -07:00
mfd	[PATCH] drivers/mfd/sm501.c: fix an off-by-one	2007-04-02 10:06:08 -07:00
misc	asus-laptop: make code static	2007-03-09 21:06:40 -05:00
mmc	uevent: use add_uevent_var() instead of open coding it	2007-04-27 10:57:29 -07:00
mtd	[MTD] [MAPS] drivers/mtd/maps/ck804xrom.c: convert pci_module_init()	2007-04-27 23:34:21 +01:00
net	sis900: Allocate rx replacement buffer before rx operation	2007-04-27 20:16:41 -04:00
nubus
oprofile	[PATCH] oprofile: fix potential deadlock on oprofilefs_lock	2007-03-28 13:58:02 -07:00
parisc	[NET]: Inline net_device_stats	2007-04-25 22:28:26 -07:00
parport	[PARPORT] SUNBPP: Fix OOPS when debugging is enabled.	2007-04-23 23:33:17 -07:00
pci	define platform wakeup hook, use in pci_enable_wake()	2007-04-27 10:57:33 -07:00
pcmcia	[PATCH] omap_cf: oops-on-suspend fix	2007-04-08 19:47:55 -07:00
pnp	PNP: stop using the subsystem rwsem	2007-04-27 10:57:30 -07:00
ps3	[PATCH] C99 initializers, proper use of const in drivers/ps3	2007-03-14 15:27:50 -07:00
rapidio	[PATCH] remove many unneeded #includes of sched.h	2007-02-14 08:09:54 -08:00
rtc	[PATCH] rtc-cmos lockdep fix, irq updates	2007-04-02 10:06:09 -07:00
s390	s390: cio: Delay uevents for subchannels	2007-04-27 10:57:32 -07:00
sbus	[OPENPROM]: Use pci_device_to_OF_node().	2007-04-26 01:54:59 -07:00
scsi	SCSI: use the proper semaphore to protect the class lists	2007-04-27 10:57:30 -07:00
serial	[SPARC/64] constify of_get_property return: drivers	2007-04-26 01:54:27 -07:00
sh
sn
spi	spi: fix use of set_cs in spi_s3c24xx driver	2007-04-17 16:36:27 -07:00
tc	[PATCH] Fix build error on zs serial driver	2007-04-04 21:12:47 -07:00
telephony	[PATCH] remove many unneeded #includes of sched.h	2007-02-14 08:09:54 -08:00
usb	usb-net/pegasus: simplify carrier detection	2007-04-27 20:16:41 -04:00
video	[IGAFB]: Use pci_device_to_OF_node() on sparc.	2007-04-26 01:55:03 -07:00
w1	[PATCH] w1: Use ARRAY_SIZE macro when appropriate	2007-02-12 09:48:28 -08:00
zorro	[PATCH] mark struct file_operations const 6	2007-02-12 09:48:45 -08:00
Kconfig
Makefile	IB: Remove reference to obsolete CONFIG_IPATH_CORE	2007-04-18 20:20:53 -07:00