mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-29 15:43:59 +08:00
1d66c64c3c
The it87 and via686a hardware monitoring drivers each create a sysfs file named "alarms" in R/W mode, while they should really create it in read-only mode. Since we don't provide a store function for these files, write attempts to these files will do something undefined (I guess) and bad (I am sure). My own try resulted in a locked terminal (where I attempted the write) and a 100% CPU load until next reboot. As a side note, wouldn't it make sense to check, when creating sysfs files, that readable files have a non-NULL show method, and writable files have a non-NULL store method? I know drivers are not supposed to do stupid things, but there is already a BUG_ON for several conditions in sysfs_create_file, so maybe we could add two more? Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
||
---|---|---|
.. | ||
adm1021.c | ||
adm1025.c | ||
adm1026.c | ||
adm1031.c | ||
asb100.c | ||
ds1337.c | ||
ds1621.c | ||
eeprom.c | ||
fscher.c | ||
fscpos.c | ||
gl518sm.c | ||
gl520sm.c | ||
isp1301_omap.c | ||
it87.c | ||
Kconfig | ||
lm63.c | ||
lm75.c | ||
lm75.h | ||
lm77.c | ||
lm78.c | ||
lm80.c | ||
lm83.c | ||
lm85.c | ||
lm87.c | ||
lm90.c | ||
lm92.c | ||
m41t00.c | ||
Makefile | ||
max1619.c | ||
pc87360.c | ||
pcf8574.c | ||
pcf8591.c | ||
rtc8564.c | ||
rtc8564.h | ||
sis5595.c | ||
smsc47b397.c | ||
smsc47m1.c | ||
via686a.c | ||
w83l785ts.c | ||
w83627hf.c | ||
w83781d.c |