mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-24 21:24:00 +08:00
d477bf3af1
ti-cpufreq and cpufreq-dt-platdev drivers are registering platform-device
with same name "cpufreq-dt" using platform_device_register_*() routines.
This is leading to build warnings appended below.
Providing hardware information to OPP framework along with the platform-
device creation should be done by ti-cpufreq driver before cpufreq-dt
driver comes into place.
This patch add's TI am33xx, am43 and dra7 platforms (which use opp-v2
property) to the blacklist of devices in cpufreq-dt-platform driver to
avoid creating platform-device twice and remove build warnings.
[ 2.370167] ------------[ cut here ]------------
[ 2.375087] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x58/0x78
[ 2.383112] sysfs: cannot create duplicate filename '/devices/platform/cpufreq-dt'
[ 2.391219] Modules linked in:
[ 2.394506] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-next-20170912 #1
[ 2.402006] Hardware name: Generic AM33XX (Flattened Device Tree)
[ 2.408437] [<c0110a28>] (unwind_backtrace) from [<c010ca84>] (show_stack+0x10/0x14)
[ 2.416568] [<c010ca84>] (show_stack) from [<c0827d64>] (dump_stack+0xac/0xe0)
[ 2.424165] [<c0827d64>] (dump_stack) from [<c0137470>] (__warn+0xd8/0x104)
[ 2.431488] [<c0137470>] (__warn) from [<c01374d0>] (warn_slowpath_fmt+0x34/0x44)
[ 2.439351] [<c01374d0>] (warn_slowpath_fmt) from [<c03459d0>] (sysfs_warn_dup+0x58/0x78)
[ 2.447938] [<c03459d0>] (sysfs_warn_dup) from [<c0345ab8>] (sysfs_create_dir_ns+0x80/0x98)
[ 2.456719] [<c0345ab8>] (sysfs_create_dir_ns) from [<c082c554>] (kobject_add_internal+0x9c/0x2d4)
[ 2.466124] [<c082c554>] (kobject_add_internal) from [<c082c7d8>] (kobject_add+0x4c/0x9c)
[ 2.474712] [<c082c7d8>] (kobject_add) from [<c05803e4>] (device_add+0xcc/0x57c)
[ 2.482489] [<c05803e4>] (device_add) from [<c0584b74>] (platform_device_add+0x100/0x220)
[ 2.491085] [<c0584b74>] (platform_device_add) from [<c05855a8>] (platform_device_register_full+0xf4/0x118)
[ 2.501305] [<c05855a8>] (platform_device_register_full) from [<c067023c>] (ti_cpufreq_init+0x150/0x22c)
[ 2.511253] [<c067023c>] (ti_cpufreq_init) from [<c0101df4>] (do_one_initcall+0x3c/0x170)
[ 2.519838] [<c0101df4>] (do_one_initcall) from [<c0c00eb4>] (kernel_init_freeable+0x1fc/0x2c4)
[ 2.528974] [<c0c00eb4>] (kernel_init_freeable) from [<c083bcac>] (kernel_init+0x8/0x110)
[ 2.537565] [<c083bcac>] (kernel_init) from [<c0107d18>] (ret_from_fork+0x14/0x3c)
[ 2.545981] ---[ end trace 2fc00e213c13ab20 ]---
[ 2.551051] ------------[ cut here ]------------
[ 2.555931] WARNING: CPU: 0 PID: 1 at lib/kobject.c:240 kobject_add_internal+0x254/0x2d4
[ 2.564578] kobject_add_internal failed for cpufreq-dt with -EEXIST, don't try to register
things with the same name in the same directory.
[ 2.577977] Modules linked in:
[ 2.581261] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W 4.13.0-next-20170912 #1
[ 2.590013] Hardware name: Generic AM33XX (Flattened Device Tree)
[ 2.596437] [<c0110a28>] (unwind_backtrace) from [<c010ca84>] (show_stack+0x10/0x14)
[ 2.604573] [<c010ca84>] (show_stack) from [<c0827d64>] (dump_stack+0xac/0xe0)
[ 2.612172] [<c0827d64>] (dump_stack) from [<c0137470>] (__warn+0xd8/0x104)
[ 2.619494] [<c0137470>] (__warn) from [<c01374d0>] (warn_slowpath_fmt+0x34/0x44)
[ 2.627362] [<c01374d0>] (warn_slowpath_fmt) from [<c082c70c>] (kobject_add_internal+0x254/0x2d4)
[ 2.636666] [<c082c70c>] (kobject_add_internal) from [<c082c7d8>] (kobject_add+0x4c/0x9c)
[ 2.645255] [<c082c7d8>] (kobject_add) from [<c05803e4>] (device_add+0xcc/0x57c)
[ 2.653027] [<c05803e4>] (device_add) from [<c0584b74>] (platform_device_add+0x100/0x220)
[ 2.661615] [<c0584b74>] (platform_device_add) from [<c05855a8>] (platform_device_register_full+0xf4/0x118)
[ 2.671833] [<c05855a8>] (platform_device_register_full) from [<c067023c>] (ti_cpufreq_init+0x150/0x22c)
[ 2.681779] [<c067023c>] (ti_cpufreq_init) from [<c0101df4>] (do_one_initcall+0x3c/0x170)
[ 2.690377] [<c0101df4>] (do_one_initcall) from [<c0c00eb4>] (kernel_init_freeable+0x1fc/0x2c4)
[ 2.699510] [<c0c00eb4>] (kernel_init_freeable) from [<c083bcac>] (kernel_init+0x8/0x110)
[ 2.708106] [<c083bcac>] (kernel_init) from [<c0107d18>] (ret_from_fork+0x14/0x3c)
[ 2.716217] ---[ end trace 2fc00e213c13ab21 ]---
Fixes: edeec420de
(cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2)
Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
168 lines
4.5 KiB
C
168 lines
4.5 KiB
C
/*
|
|
* Copyright (C) 2016 Linaro.
|
|
* Viresh Kumar <viresh.kumar@linaro.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/err.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_device.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "cpufreq-dt.h"
|
|
|
|
/*
|
|
* Machines for which the cpufreq device is *always* created, mostly used for
|
|
* platforms using "operating-points" (V1) property.
|
|
*/
|
|
static const struct of_device_id whitelist[] __initconst = {
|
|
{ .compatible = "allwinner,sun4i-a10", },
|
|
{ .compatible = "allwinner,sun5i-a10s", },
|
|
{ .compatible = "allwinner,sun5i-a13", },
|
|
{ .compatible = "allwinner,sun5i-r8", },
|
|
{ .compatible = "allwinner,sun6i-a31", },
|
|
{ .compatible = "allwinner,sun6i-a31s", },
|
|
{ .compatible = "allwinner,sun7i-a20", },
|
|
{ .compatible = "allwinner,sun8i-a23", },
|
|
{ .compatible = "allwinner,sun8i-a83t", },
|
|
{ .compatible = "allwinner,sun8i-h3", },
|
|
|
|
{ .compatible = "apm,xgene-shadowcat", },
|
|
|
|
{ .compatible = "arm,integrator-ap", },
|
|
{ .compatible = "arm,integrator-cp", },
|
|
|
|
{ .compatible = "hisilicon,hi3660", },
|
|
|
|
{ .compatible = "fsl,imx27", },
|
|
{ .compatible = "fsl,imx51", },
|
|
{ .compatible = "fsl,imx53", },
|
|
{ .compatible = "fsl,imx7d", },
|
|
|
|
{ .compatible = "marvell,berlin", },
|
|
{ .compatible = "marvell,pxa250", },
|
|
{ .compatible = "marvell,pxa270", },
|
|
|
|
{ .compatible = "samsung,exynos3250", },
|
|
{ .compatible = "samsung,exynos4210", },
|
|
{ .compatible = "samsung,exynos4212", },
|
|
{ .compatible = "samsung,exynos5250", },
|
|
#ifndef CONFIG_BL_SWITCHER
|
|
{ .compatible = "samsung,exynos5800", },
|
|
#endif
|
|
|
|
{ .compatible = "renesas,emev2", },
|
|
{ .compatible = "renesas,r7s72100", },
|
|
{ .compatible = "renesas,r8a73a4", },
|
|
{ .compatible = "renesas,r8a7740", },
|
|
{ .compatible = "renesas,r8a7743", },
|
|
{ .compatible = "renesas,r8a7745", },
|
|
{ .compatible = "renesas,r8a7778", },
|
|
{ .compatible = "renesas,r8a7779", },
|
|
{ .compatible = "renesas,r8a7790", },
|
|
{ .compatible = "renesas,r8a7791", },
|
|
{ .compatible = "renesas,r8a7792", },
|
|
{ .compatible = "renesas,r8a7793", },
|
|
{ .compatible = "renesas,r8a7794", },
|
|
{ .compatible = "renesas,r8a7795", },
|
|
{ .compatible = "renesas,r8a7796", },
|
|
{ .compatible = "renesas,sh73a0", },
|
|
|
|
{ .compatible = "rockchip,rk2928", },
|
|
{ .compatible = "rockchip,rk3036", },
|
|
{ .compatible = "rockchip,rk3066a", },
|
|
{ .compatible = "rockchip,rk3066b", },
|
|
{ .compatible = "rockchip,rk3188", },
|
|
{ .compatible = "rockchip,rk3228", },
|
|
{ .compatible = "rockchip,rk3288", },
|
|
{ .compatible = "rockchip,rk3328", },
|
|
{ .compatible = "rockchip,rk3366", },
|
|
{ .compatible = "rockchip,rk3368", },
|
|
{ .compatible = "rockchip,rk3399", },
|
|
|
|
{ .compatible = "socionext,uniphier-ld6b", },
|
|
|
|
{ .compatible = "st-ericsson,u8500", },
|
|
{ .compatible = "st-ericsson,u8540", },
|
|
{ .compatible = "st-ericsson,u9500", },
|
|
{ .compatible = "st-ericsson,u9540", },
|
|
|
|
{ .compatible = "ti,omap2", },
|
|
{ .compatible = "ti,omap3", },
|
|
{ .compatible = "ti,omap4", },
|
|
{ .compatible = "ti,omap5", },
|
|
|
|
{ .compatible = "xlnx,zynq-7000", },
|
|
{ .compatible = "xlnx,zynqmp", },
|
|
|
|
{ }
|
|
};
|
|
|
|
/*
|
|
* Machines for which the cpufreq device is *not* created, mostly used for
|
|
* platforms using "operating-points-v2" property.
|
|
*/
|
|
static const struct of_device_id blacklist[] __initconst = {
|
|
{ .compatible = "calxeda,highbank", },
|
|
{ .compatible = "calxeda,ecx-2000", },
|
|
|
|
{ .compatible = "marvell,armadaxp", },
|
|
|
|
{ .compatible = "nvidia,tegra124", },
|
|
|
|
{ .compatible = "st,stih407", },
|
|
{ .compatible = "st,stih410", },
|
|
|
|
{ .compatible = "sigma,tango4", },
|
|
|
|
{ .compatible = "ti,am33xx", },
|
|
{ .compatible = "ti,am43", },
|
|
{ .compatible = "ti,dra7", },
|
|
|
|
{ }
|
|
};
|
|
|
|
static bool __init cpu0_node_has_opp_v2_prop(void)
|
|
{
|
|
struct device_node *np = of_cpu_device_node_get(0);
|
|
bool ret = false;
|
|
|
|
if (of_get_property(np, "operating-points-v2", NULL))
|
|
ret = true;
|
|
|
|
of_node_put(np);
|
|
return ret;
|
|
}
|
|
|
|
static int __init cpufreq_dt_platdev_init(void)
|
|
{
|
|
struct device_node *np = of_find_node_by_path("/");
|
|
const struct of_device_id *match;
|
|
const void *data = NULL;
|
|
|
|
if (!np)
|
|
return -ENODEV;
|
|
|
|
match = of_match_node(whitelist, np);
|
|
if (match) {
|
|
data = match->data;
|
|
goto create_pdev;
|
|
}
|
|
|
|
if (cpu0_node_has_opp_v2_prop() && !of_match_node(blacklist, np))
|
|
goto create_pdev;
|
|
|
|
of_node_put(np);
|
|
return -ENODEV;
|
|
|
|
create_pdev:
|
|
of_node_put(np);
|
|
return PTR_ERR_OR_ZERO(platform_device_register_data(NULL, "cpufreq-dt",
|
|
-1, data,
|
|
sizeof(struct cpufreq_dt_platform_data)));
|
|
}
|
|
device_initcall(cpufreq_dt_platdev_init);
|