Davide Caratti 6191da9806 net/sched: act_skbedit: fix refcount leak when replace fails ... when act_skbedit was converted to use RCU in the data plane, we added an error path, but we forgot to drop the action refcount in case of failure during a 'replace' operation: # tc actions add action skbedit ptype otherhost pass index 100 # tc action show action skbedit total acts 1 action order 0: skbedit ptype otherhost pass index 100 ref 1 bind 0 # tc actions replace action skbedit ptype otherhost drop index 100 RTNETLINK answers: Cannot allocate memory We have an error talking to the kernel # tc action show action skbedit total acts 1 action order 0: skbedit ptype otherhost pass index 100 ref 2 bind 0 Ensure we call tcf_idr_release(), in case 'params_new' allocation failed, also when the action is being replaced. Fixes: c749cdda90 ("net/sched: act_skbedit: don't use spinlock in the data path") Signed-off-by: Davide Caratti <dcaratti@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-02-24 17:31:43 -08:00
..
6lowpan	6lowpan: convert to DEFINE_SHOW_ATTRIBUTE	2018-12-19 00:28:05 +01:00
9p	9p/net: put a lower bound on msize	2018-12-25 17:07:49 +09:00
802
8021q	net: core: dev: Add extack argument to dev_change_flags()	2018-12-06 13:26:07 -08:00
appletalk
atm	Revert "net: simplify sock_poll_wait"	2018-10-23 10:57:06 -07:00
ax25	ax25: fix possible use-after-free	2019-01-23 11:18:00 -08:00
batman-adv	batman-adv: fix uninit-value in batadv_interface_tx()	2019-02-12 13:30:43 -05:00
bluetooth	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2018-12-27 13:53:32 -08:00
bpf	bpf/test_run: fix unkillable BPF_PROG_TEST_RUN	2019-02-19 00:17:03 +01:00
bpfilter	net: bpfilter: change section name of bpfilter UMH blob.	2019-01-16 15:46:46 -08:00
bridge	Revert "bridge: do not add port to router list when receives query with source 0.0.0.0"	2019-02-23 18:36:06 -08:00
caif	Revert "net: simplify sock_poll_wait"	2018-10-23 10:57:06 -07:00
can	can: bcm: check timer values before ktime conversion	2019-01-22 11:33:46 +01:00
ceph	libceph: handle an empty authorize reply	2019-02-18 18:05:33 +01:00
core	net: Do not allocate page fragments that are not skb aligned	2019-02-17 15:48:43 -08:00
dcb
dccp	dccp: fool proof ccid_hc_[rt]x_parse_options()	2019-02-01 14:49:10 -08:00
decnet	decnet: fix DN_IFREQ_SIZE	2019-01-27 23:11:55 -08:00
dns_resolver	dns: Allow the dns resolver to retrieve a server set	2018-10-04 09:40:52 -07:00
dsa	net: dsa: fix unintended change of bridge interface STP state	2019-02-20 11:08:26 -08:00
ethernet	net: ethernet: provide nvmem_get_mac_address()	2018-12-03 15:40:30 -08:00
hsr
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2018-12-24 16:19:56 -08:00
ife
ipv4	tcp: repaired skbs must init their tso_segs	2019-02-23 18:43:25 -08:00
ipv6	udpv6: fix possible user after free in error handler	2019-02-22 16:05:11 -08:00
iucv	iucv: Remove SKB list assumptions.	2018-11-10 16:55:11 -08:00
kcm
key	af_key: unconditionally clone on broadcast	2019-02-12 10:36:42 +01:00
l2tp	l2tp: copy 4 more bytes to linear part if necessary	2019-01-31 08:58:46 -08:00
l3mdev	l3mdev: add function to retreive upper master	2018-12-03 14:15:26 -08:00
lapb
llc	llc: do not use sk_eat_skb()	2018-10-22 19:59:20 -07:00
mac80211	mac80211: allocate tailroom for forwarded mesh packets	2019-02-22 14:00:40 +01:00
mac802154
mpls	net/mpls: Handle kernel side filtering of route dumps	2018-10-16 00:14:07 -07:00
ncsi	net/ncsi: Add NCSI Mellanox OEM command	2018-11-27 16:37:20 -08:00
netfilter	ipvs: fix warning on unused variable	2019-02-16 10:41:42 +01:00
netlabel
netlink	net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK	2018-12-14 11:44:31 -08:00
netrom	netrom: switch to sock timer API	2019-01-27 10:38:04 -08:00
nfc	net: Revert recent Spectre-v1 patches.	2018-12-23 16:01:35 -08:00
nsh
openvswitch	openvswitch: Avoid OOB read when parsing flow nlattrs	2019-01-16 13:35:21 -08:00
packet	net/packet: fix 4gb buffer limit due to overflow check	2019-02-12 13:37:23 -05:00
phonet	phonet: fix building with clang	2019-02-21 16:23:56 -08:00
psample
qrtr
rds	rds: fix refcount bug in rds_sock_addref	2019-01-31 09:43:27 -08:00
rfkill	rfkill: gpio: Remove unused include	2018-12-18 13:13:56 +01:00
rose	net/rose: fix NULL ax25_cb kernel panic	2019-01-27 10:40:01 -08:00
rxrpc	rxrpc: bad unlock balance in rxrpc_recvmsg	2019-02-06 10:54:07 -08:00
sched	net/sched: act_skbedit: fix refcount leak when replace fails	2019-02-24 17:31:43 -08:00
sctp	sctp: don't compare hb_timer expire date before starting it	2019-02-22 11:11:54 -08:00
smc	net/smc: fix smc_poll in SMC_INIT state	2019-02-21 10:19:20 -08:00
strparser	bpf, sockmap: convert to generic sk_msg interface	2018-10-15 12:23:19 -07:00
sunrpc	Two small fixes, one for crashes using nfs/krb5 with older enctypes, one	2019-02-16 17:38:01 -08:00
switchdev	net: switchdev: Add extack to switchdev_handle_port_obj_add() callback	2018-12-12 16:34:22 -08:00
tipc	tipc: improve function tipc_wait_for_rcvmsg()	2019-02-21 13:58:05 -08:00
tls	net: tls: Fix deadlock in free_resources tx	2019-01-28 23:07:08 -08:00
unix	missing barriers in some of unix_sock ->addr and ->path accesses	2019-02-20 20:06:28 -08:00
vmw_vsock	vsock: cope with memory allocation failure at socket creation time	2019-02-08 22:32:05 -08:00
wimax
wireless	cfg80211: prevent speculation on cfg80211_classify8021d() return	2019-02-11 15:50:56 +01:00
x25	net/x25: fix a race in x25_bind()	2019-02-23 18:41:06 -08:00
xdp	Revert "xsk: simplify AF_XDP socket teardown"	2019-02-21 16:32:25 +01:00
xfrm	xfrm: Fix inbound traffic via XFRM interfaces across network namespaces	2019-02-18 10:58:54 +01:00
compat.c	net: socket: add check for negative optlen in compat setsockopt	2019-02-22 11:49:28 -08:00
Kconfig	net: convert bridge_nf to use skb extension infrastructure	2018-12-19 11:21:37 -08:00
Makefile
socket.c	net: socket: make bond ioctls go through compat_ifreq_ioctl()	2019-01-30 10:19:31 -08:00
sysctl_net.c