mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-21 19:53:59 +08:00
c055564217
Parsing an option from the command line with OPT_BOOLEAN on a bool data type would not work on a big-endian machine due to the manner in which the boolean was being cast into an int and incremented. For example, running 'perf probe --list' on a PowerPC machine would fail to properly set the list_events bool and would therefore print out the usage information and terminate. This patch makes OPT_BOOLEAN work as expected with a bool datatype. For cases where the original OPT_BOOLEAN was intentionally being used to increment an int each time it was passed in on the command line, this patch introduces OPT_INCR with the old behaviour of OPT_BOOLEAN (the verbose variable is currently the only such example of this). I have reviewed every use of OPT_BOOLEAN to verify that a true C99 bool was passed. Where integers were used, I verified that they were only being used for boolean logic and changed them to bools to ensure that they would not be mistakenly used as ints. The major exception was the verbose variable which now uses OPT_INCR instead of OPT_BOOLEAN. Signed-off-by: Ian Munsie <imunsie@au.ibm.com> Acked-by: David S. Miller <davem@davemloft.net> Cc: <stable@kernel.org> # NOTE: wont apply to .3[34].x cleanly, please backport Cc: Git development list <git@vger.kernel.org> Cc: Ian Munsie <imunsie@au1.ibm.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> Cc: Rusty Russell <rusty@rustcorp.com.au> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Eric B Munson <ebmunson@us.ibm.com> Cc: Valdis.Kletnieks@vt.edu Cc: WANG Cong <amwang@redhat.com> Cc: Thiago Farina <tfransosi@gmail.com> Cc: Masami Hiramatsu <mhiramat@redhat.com> Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> Cc: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Cc: Mike Galbraith <efault@gmx.de> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: Anton Blanchard <anton@samba.org> Cc: John Kacur <jkacur@redhat.com> Cc: Li Zefan <lizf@cn.fujitsu.com> Cc: Steven Rostedt <rostedt@goodmis.org> LKML-Reference: <1271147857-11604-1-git-send-email-imunsie@au.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
40 lines
1.0 KiB
C
40 lines
1.0 KiB
C
/* For debugging general purposes */
|
|
#ifndef __PERF_DEBUG_H
|
|
#define __PERF_DEBUG_H
|
|
|
|
#include <stdbool.h>
|
|
#include "event.h"
|
|
|
|
extern int verbose;
|
|
extern bool dump_trace;
|
|
|
|
int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
|
|
void trace_event(event_t *event);
|
|
|
|
struct ui_progress;
|
|
|
|
#ifdef NO_NEWT_SUPPORT
|
|
static inline int browser__show_help(const char *format __used, va_list ap __used)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline struct ui_progress *ui_progress__new(const char *title __used,
|
|
u64 total __used)
|
|
{
|
|
return (struct ui_progress *)1;
|
|
}
|
|
|
|
static inline void ui_progress__update(struct ui_progress *self __used,
|
|
u64 curr __used) {}
|
|
|
|
static inline void ui_progress__delete(struct ui_progress *self __used) {}
|
|
#else
|
|
int browser__show_help(const char *format, va_list ap);
|
|
struct ui_progress *ui_progress__new(const char *title, u64 total);
|
|
void ui_progress__update(struct ui_progress *self, u64 curr);
|
|
void ui_progress__delete(struct ui_progress *self);
|
|
#endif
|
|
|
|
#endif /* __PERF_DEBUG_H */
|