Lyude ccebc23b57 drm/i915/skl: Don't try to update plane watermarks if they haven't changed ... i915 sometimes needs to disable planes in the middle of an atomic commit, and then reenable them later in the same commit. Because of this, we can't make the assumption that the state of the plane actually changed. Since the state of the plane hasn't actually changed, neither have it's watermarks. And if the watermarks hasn't changed then we haven't populated skl_results with anything, which means we'll end up zeroing out a plane's watermarks in the middle of the atomic commit without restoring them later. Simple reproduction recipe: - Get a SKL laptop, launch any kind of X session - Get two extra monitors - Keep hotplugging both displays (so that the display configuration jumps from 1 active pipe to 3 active pipes and back) - Eventually underrun Changes since v1: - Fix incorrect use of "it's" Changes since v2: - Add reproduction recipe Signed-off-by: Lyude <cpaul@redhat.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Fixes: 62e0fb8801 ("drm/i915/skl: Update plane watermarks atomically during plane updates") Signed-off-by: Lyude <cpaul@redhat.com> Testcase: kms_plane Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1472488288-27280-1-git-send-email-cpaul@redhat.com Cc: drm-intel-fixes@lists.freedesktop.org		2016-09-07 12:29:17 +02:00
..
drm	drm/i915/skl: Don't try to update plane watermarks if they haven't changed	2016-09-07 12:29:17 +02:00
host1x	gpu: host1x: Remove useless local variable	2016-06-23 11:59:33 +02:00
ipu-v3	gpu: ipu-v3: rename CSI client device	2016-08-08 11:44:20 +02:00
vga	vga_switcheroo: Sphinxify docs	2016-07-12 16:14:36 +02:00
Makefile