2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-25 05:34:00 +08:00
linux-next/fs/xfs/libxfs
Eric Sandeen c400ee3ed1 xfs: set XFS_DA_OP_OKNOENT in xfs_attr_get
It's entirely possible for userspace to ask for an xattr which
does not exist.

Normally, there is no problem whatsoever when we ask for such
a thing, but when we look at an obfuscated metadump image
on a debug kernel with selinux, we trip over this ASSERT in
xfs_da3_path_shift():

        *result = -ENOENT;      /* we're out of our tree */
        ASSERT(args->op_flags & XFS_DA_OP_OKNOENT);

It (more or less) only shows up in the above scenario, because
xfs_metadump obfuscates attr names, but chooses names which
keep the same hash value - and xfs_da3_node_lookup_int does:

        if (((retval == -ENOENT) || (retval == -ENOATTR)) &&
            (blk->hashval == args->hashval)) {
                error = xfs_da3_path_shift(state, &state->path, 1, 1,
                                                 &retval);

IOWS, we only get down to the xfs_da3_path_shift() ASSERT
if we are looking for an xattr which doesn't exist, but we
find xattrs on disk which have the same hash, and so might be
a hash collision, so we try the path shift.  When *that*
fails to find what we're looking for, we hit the assert about
XFS_DA_OP_OKNOENT.

Simply setting XFS_DA_OP_OKNOENT in xfs_attr_get solves this
rather corner-case problem with no ill side effects.  It's
fine for an attr name lookup to fail.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 10:30:48 +10:00
..
xfs_alloc_btree.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_alloc_btree.h
xfs_alloc.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_alloc.h Merge branch 'xfs-freelist-cleanup' into for-next 2015-06-23 08:48:43 +10:00
xfs_attr_leaf.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_attr_leaf.h xfs: xfs_attr_inactive leaves inconsistent attr fork state behind 2015-05-29 07:40:08 +10:00
xfs_attr_remote.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_attr_remote.h
xfs_attr_sf.h
xfs_attr.c xfs: set XFS_DA_OP_OKNOENT in xfs_attr_get 2015-08-19 10:30:48 +10:00
xfs_bit.h
xfs_bmap_btree.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_bmap_btree.h
xfs_bmap.c Merge branch 'xfs-freelist-cleanup' into for-next 2015-06-23 08:48:43 +10:00
xfs_bmap.h xfs: Add support FALLOC_FL_INSERT_RANGE for fallocate 2015-03-25 15:08:56 +11:00
xfs_btree.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_btree.h xfs: require 64-bit sector_t 2014-07-30 09:12:05 +10:00
xfs_cksum.h
xfs_da_btree.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_da_btree.h
xfs_da_format.c xfs: move most of xfs_sb.h to xfs_format.h 2014-11-28 14:27:09 +11:00
xfs_da_format.h xfs: use larger in-core attr firstused field and detect overflow 2015-04-13 11:27:10 +10:00
xfs_dir2_block.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_dir2_data.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_dir2_leaf.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_dir2_node.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_dir2_priv.h xfs: move type conversion functions to xfs_dir.h 2014-12-04 09:43:17 +11:00
xfs_dir2_sf.c Merge branch 'xfs-misc-fixes-for-3.19-2' into for-next 2014-12-04 09:46:17 +11:00
xfs_dir2.c Merge branch 'xfs-misc-fixes-for-3.19-2' into for-next 2014-12-04 09:46:17 +11:00
xfs_dir2.h xfs: move type conversion functions to xfs_dir.h 2014-12-04 09:43:17 +11:00
xfs_dquot_buf.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_format.h xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_fs.h xfs: add fs geometry bit for sparse inode chunks 2015-05-29 08:58:32 +10:00
xfs_ialloc_btree.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_ialloc_btree.h xfs: allocate sparse inode chunks on full chunk allocation failure 2015-05-29 09:18:32 +10:00
xfs_ialloc.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_ialloc.h Merge branch 'xfs-misc-fixes-for-4.2-3' into for-next 2015-06-23 08:49:01 +10:00
xfs_inode_buf.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_inode_buf.h
xfs_inode_fork.c xfs: merge xfs_inum.h into xfs_format.h 2014-11-28 14:27:10 +11:00
xfs_inode_fork.h
xfs_log_format.h xfs: merge xfs_dinode.h into xfs_format.h 2014-11-28 14:24:06 +11:00
xfs_log_recover.h
xfs_log_rlimit.c xfs: move most of xfs_sb.h to xfs_format.h 2014-11-28 14:27:09 +11:00
xfs_quota_defs.h
xfs_rtbitmap.c xfs: move most of xfs_sb.h to xfs_format.h 2014-11-28 14:27:09 +11:00
xfs_sb.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_sb.h xfs: consolidate superblock logging functions 2015-01-22 09:10:31 +11:00
xfs_shared.h xfs: saner xfs_trans_commit interface 2015-06-04 13:48:08 +10:00
xfs_symlink_remote.c xfs: create new metadata UUID field and incompat flag 2015-07-29 11:53:31 +10:00
xfs_trans_resv.c xfs: consolidate superblock logging functions 2015-01-22 09:10:31 +11:00
xfs_trans_resv.h xfs: clean up XFS_MIN_FREELIST macros 2015-06-22 10:13:30 +10:00
xfs_trans_space.h xfs: clean up XFS_MIN_FREELIST macros 2015-06-22 10:13:30 +10:00
xfs_types.h xfs: move xfs_types.h to libxfs 2015-01-09 10:46:31 +11:00