2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-24 21:24:00 +08:00
linux-next/drivers/vhost
Michael S. Tsirkin 6de7145ca3 tcm_vhost: Fix vhost_scsi_target structure alignment
Here TRANSPORT_IQN_LEN is 224, which is a multiple of 4.
Since vhost_tpgt is 2 bytes and abi_version is 4, the total size would
be 230.  But gcc needs struct size be aligned to first field size, which
is 4 bytes, so it pads the structure by extra 2 bytes to the total of
232.

This padding is very undesirable in an ABI:
- it can not be initialized easily
- it can not be checked easily
- it can leak information between kernel and userspace

Simplest solution is probably just to make the padding
explicit.

(v2: Add check for zero'ed backend->reserved field for VHOST_SCSI_SET_ENDPOINT
     and VHOST_SCSI_CLEAR_ENDPOINT ops as requested by MST)

Reported-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2012-08-20 14:52:11 -07:00
..
Kconfig tcm_vhost: Initial merge for vhost level target fabric driver 2012-07-29 13:49:10 -07:00
Kconfig.tcm tcm_vhost: Initial merge for vhost level target fabric driver 2012-07-29 13:49:10 -07:00
Makefile tcm_vhost: Initial merge for vhost level target fabric driver 2012-07-29 13:49:10 -07:00
net.c vhost: Separate vhost-net features from vhost features 2012-07-22 01:21:53 +03:00
tcm_vhost.c tcm_vhost: Fix vhost_scsi_target structure alignment 2012-08-20 14:52:11 -07:00
tcm_vhost.h tcm_vhost: Fix vhost_scsi_target structure alignment 2012-08-20 14:52:11 -07:00
test.c vhost: Separate vhost-net features from vhost features 2012-07-22 01:21:53 +03:00
test.h vhost test module 2010-12-09 16:00:21 +02:00
vhost.c vhost: make vhost work queue visible 2012-07-22 01:22:23 +03:00
vhost.h vhost: make vhost work queue visible 2012-07-22 01:22:23 +03:00