mirror of
https://github.com/edk2-porting/linux-next.git
synced 2025-01-01 10:13:58 +08:00
bed570307e
I noticed some wakeirq flakeyness with consumer drivers not using
autosuspend. For drivers not using autosuspend, the wakeirq may never
get unmasked in rpm_suspend() because of irq desc->depth.
We are configuring dedicated wakeirqs to start with IRQ_NOAUTOEN as we
naturally don't want them running until rpm_suspend() is called.
However, when a consumer driver initially calls pm_runtime_get(), we
now wrongly start with disable_irq_nosync() call on the dedicated
wakeirq that is disabled to start with.
This causes desc->depth to toggle between 1 and 2 instead of the usual
0 and 1. This can prevent enable_irq() from unmasking the wakeirq as
that only happens at desc->depth 1.
This does not necessarily show up with drivers using autosuspend as
there is time for disable_irq_nosync() before rpm_suspend() gets called
after the autosuspend timeout.
Let's fix the issue by adding wirq->status that lazily gets set on
the first rpm_suspend(). We also need PM runtime core private functions
for dev_pm_enable_wake_irq_check() and dev_pm_disable_wake_irq_check()
so we can enable the dedicated wakeirq on the first rpm_suspend().
While at it, let's also fix the comments for dev_pm_enable_wake_irq()
and dev_pm_disable_wake_irq(). Those can still be used by the consumer
drivers as needed because the IRQ core manages the interrupt usecount
for us.
Fixes: 4990d4fe32 (PM / Wakeirq: Add automated device wake IRQ handling)
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
174 lines
4.7 KiB
C
174 lines
4.7 KiB
C
#include <linux/pm_qos.h>
|
|
|
|
static inline void device_pm_init_common(struct device *dev)
|
|
{
|
|
if (!dev->power.early_init) {
|
|
spin_lock_init(&dev->power.lock);
|
|
dev->power.qos = NULL;
|
|
dev->power.early_init = true;
|
|
}
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
|
|
static inline void pm_runtime_early_init(struct device *dev)
|
|
{
|
|
dev->power.disable_depth = 1;
|
|
device_pm_init_common(dev);
|
|
}
|
|
|
|
extern void pm_runtime_init(struct device *dev);
|
|
extern void pm_runtime_reinit(struct device *dev);
|
|
extern void pm_runtime_remove(struct device *dev);
|
|
|
|
#define WAKE_IRQ_DEDICATED_ALLOCATED BIT(0)
|
|
#define WAKE_IRQ_DEDICATED_MANAGED BIT(1)
|
|
#define WAKE_IRQ_DEDICATED_MASK (WAKE_IRQ_DEDICATED_ALLOCATED | \
|
|
WAKE_IRQ_DEDICATED_MANAGED)
|
|
|
|
struct wake_irq {
|
|
struct device *dev;
|
|
unsigned int status;
|
|
int irq;
|
|
};
|
|
|
|
extern void dev_pm_arm_wake_irq(struct wake_irq *wirq);
|
|
extern void dev_pm_disarm_wake_irq(struct wake_irq *wirq);
|
|
extern void dev_pm_enable_wake_irq_check(struct device *dev,
|
|
bool can_change_status);
|
|
extern void dev_pm_disable_wake_irq_check(struct device *dev);
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
|
|
extern int device_wakeup_attach_irq(struct device *dev,
|
|
struct wake_irq *wakeirq);
|
|
extern void device_wakeup_detach_irq(struct device *dev);
|
|
extern void device_wakeup_arm_wake_irqs(void);
|
|
extern void device_wakeup_disarm_wake_irqs(void);
|
|
|
|
#else
|
|
|
|
static inline int
|
|
device_wakeup_attach_irq(struct device *dev,
|
|
struct wake_irq *wakeirq)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void device_wakeup_detach_irq(struct device *dev)
|
|
{
|
|
}
|
|
|
|
static inline void device_wakeup_arm_wake_irqs(void)
|
|
{
|
|
}
|
|
|
|
static inline void device_wakeup_disarm_wake_irqs(void)
|
|
{
|
|
}
|
|
|
|
#endif /* CONFIG_PM_SLEEP */
|
|
|
|
/*
|
|
* sysfs.c
|
|
*/
|
|
|
|
extern int dpm_sysfs_add(struct device *dev);
|
|
extern void dpm_sysfs_remove(struct device *dev);
|
|
extern void rpm_sysfs_remove(struct device *dev);
|
|
extern int wakeup_sysfs_add(struct device *dev);
|
|
extern void wakeup_sysfs_remove(struct device *dev);
|
|
extern int pm_qos_sysfs_add_resume_latency(struct device *dev);
|
|
extern void pm_qos_sysfs_remove_resume_latency(struct device *dev);
|
|
extern int pm_qos_sysfs_add_flags(struct device *dev);
|
|
extern void pm_qos_sysfs_remove_flags(struct device *dev);
|
|
extern int pm_qos_sysfs_add_latency_tolerance(struct device *dev);
|
|
extern void pm_qos_sysfs_remove_latency_tolerance(struct device *dev);
|
|
|
|
#else /* CONFIG_PM */
|
|
|
|
static inline void pm_runtime_early_init(struct device *dev)
|
|
{
|
|
device_pm_init_common(dev);
|
|
}
|
|
|
|
static inline void pm_runtime_init(struct device *dev) {}
|
|
static inline void pm_runtime_reinit(struct device *dev) {}
|
|
static inline void pm_runtime_remove(struct device *dev) {}
|
|
|
|
static inline int dpm_sysfs_add(struct device *dev) { return 0; }
|
|
static inline void dpm_sysfs_remove(struct device *dev) {}
|
|
static inline void rpm_sysfs_remove(struct device *dev) {}
|
|
static inline int wakeup_sysfs_add(struct device *dev) { return 0; }
|
|
static inline void wakeup_sysfs_remove(struct device *dev) {}
|
|
static inline int pm_qos_sysfs_add(struct device *dev) { return 0; }
|
|
static inline void pm_qos_sysfs_remove(struct device *dev) {}
|
|
|
|
static inline void dev_pm_arm_wake_irq(struct wake_irq *wirq)
|
|
{
|
|
}
|
|
|
|
static inline void dev_pm_disarm_wake_irq(struct wake_irq *wirq)
|
|
{
|
|
}
|
|
|
|
static inline void dev_pm_enable_wake_irq_check(struct device *dev,
|
|
bool can_change_status)
|
|
{
|
|
}
|
|
|
|
static inline void dev_pm_disable_wake_irq_check(struct device *dev)
|
|
{
|
|
}
|
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
|
|
/* kernel/power/main.c */
|
|
extern int pm_async_enabled;
|
|
|
|
/* drivers/base/power/main.c */
|
|
extern struct list_head dpm_list; /* The active device list */
|
|
|
|
static inline struct device *to_device(struct list_head *entry)
|
|
{
|
|
return container_of(entry, struct device, power.entry);
|
|
}
|
|
|
|
extern void device_pm_sleep_init(struct device *dev);
|
|
extern void device_pm_add(struct device *);
|
|
extern void device_pm_remove(struct device *);
|
|
extern void device_pm_move_before(struct device *, struct device *);
|
|
extern void device_pm_move_after(struct device *, struct device *);
|
|
extern void device_pm_move_last(struct device *);
|
|
extern void device_pm_check_callbacks(struct device *dev);
|
|
|
|
#else /* !CONFIG_PM_SLEEP */
|
|
|
|
static inline void device_pm_sleep_init(struct device *dev) {}
|
|
|
|
static inline void device_pm_add(struct device *dev) {}
|
|
|
|
static inline void device_pm_remove(struct device *dev)
|
|
{
|
|
pm_runtime_remove(dev);
|
|
}
|
|
|
|
static inline void device_pm_move_before(struct device *deva,
|
|
struct device *devb) {}
|
|
static inline void device_pm_move_after(struct device *deva,
|
|
struct device *devb) {}
|
|
static inline void device_pm_move_last(struct device *dev) {}
|
|
|
|
static inline void device_pm_check_callbacks(struct device *dev) {}
|
|
|
|
#endif /* !CONFIG_PM_SLEEP */
|
|
|
|
static inline void device_pm_init(struct device *dev)
|
|
{
|
|
device_pm_init_common(dev);
|
|
device_pm_sleep_init(dev);
|
|
pm_runtime_init(dev);
|
|
}
|