Darrick J. Wong be78ff0e72 xfs: recheck reflink / dirty page status before freeing CoW reservations ... Eryu Guan reported seeing occasional hangs when running generic/269 with a new fsstress that supports clonerange/deduperange. The cause of this hang is an infinite loop when we convert the CoW fork extents from unwritten to real just prior to writing the pages out; the infinite loop happens because there's nothing in the CoW fork to convert, and so it spins forever. The fundamental issue here is that when we go to perform these CoW fork conversions, we're supposed to have an extent waiting for us, but the low space CoW reaper has snuck in and blown them away! There are four conditions that can dissuade the reaper from touching our file -- no reflink iflag; dirty page cache; writeback in progress; or directio in progress. We check the four conditions prior to taking the locks, but we neglect to recheck them once we have the locks, which is how we end up whacking the writeback that's in progress. Therefore, refactor the four checks into a helper function and call it once again once we have the locks to make sure we really want to reap the inode. While we're at it, add an ASSERT for this weird condition so that we'll fail noisily if we ever screw this up again. Reported-by: Eryu Guan <eguan@redhat.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Tested-by: Eryu Guan <eguan@redhat.com> Reviewed-by: Brian Foster <bfoster@redhat.com>		2018-01-17 21:00:47 -08:00
..
libxfs	xfs: recheck reflink / dirty page status before freeing CoW reservations	2018-01-17 21:00:47 -08:00
scrub	xfs: check that br_blockcount doesn't overflow	2018-01-17 21:00:47 -08:00
Kconfig	xfs: create an ioctl to scrub AG metadata	2017-10-26 15:38:23 -07:00
kmem.c	mm, vmalloc: use __GFP_HIGHMEM implicitly	2017-05-08 17:15:13 -07:00
kmem.h	slab, slub, slob: add slab_flags_t	2017-11-15 18:21:01 -08:00
Makefile	xfs: use a b+tree for the in-core extent list	2017-11-06 11:53:41 -08:00
mrlock.h
xfs_acl.c	xfs: don't change inode mode if ACL update fails	2017-10-11 10:21:06 -07:00
xfs_acl.h	xfs: Don't clear SGID when inheriting ACLs	2017-06-27 18:23:21 -07:00
xfs_aops.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_aops.h	xfs: perform dax_device lookup at mount	2017-08-31 09:31:47 -07:00
xfs_attr_inactive.c	xfs: fail if xattr inactivation hits a hole	2017-10-26 15:38:22 -07:00
xfs_attr_list.c	xfs: remove u_int* type usage	2017-11-09 15:50:29 -08:00
xfs_attr.h	xfs: scrub extended attributes	2017-10-26 15:38:26 -07:00
xfs_bmap_item.c	xfs: log recovery should replay deferred ops in order	2017-11-27 09:34:08 -08:00
xfs_bmap_item.h	xfs: log recovery should replay deferred ops in order	2017-11-27 09:34:08 -08:00
xfs_bmap_util.c	xfs: remove support for inlining data/extents into the inode fork	2017-11-06 11:53:40 -08:00
xfs_bmap_util.h	xfs: simplify the xfs_getbmap interface	2017-10-26 15:38:20 -07:00
xfs_buf_item.c	xfs: fix compiler warnings	2017-09-02 08:22:19 -07:00
xfs_buf_item.h	xfs: remove unnecessary dirty bli format check for ordered bufs	2017-09-01 10:55:30 -07:00
xfs_buf.c	xfs: clarify units in the failed metadata io message	2018-01-09 15:18:07 -08:00
xfs_buf.h	xfs: create a new buf_ops pointer to verify structure metadata	2018-01-08 10:54:47 -08:00
xfs_dir2_readdir.c	xfs: directory scrubber must walk through data block to offset	2018-01-17 21:00:46 -08:00
xfs_discard.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_discard.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs_dquot_item.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_dquot_item.h
xfs_dquot.c	xfs: standardize quota verification function outputs	2018-01-08 10:54:47 -08:00
xfs_dquot.h
xfs_error.c	xfs: dump the first 128 bytes of any corrupt buffer	2018-01-08 10:54:47 -08:00
xfs_error.h	xfs: dump the first 128 bytes of any corrupt buffer	2018-01-08 10:54:47 -08:00
xfs_export.c
xfs_export.h
xfs_extent_busy.c	xfs: fix len comparison in xfs_extent_busy_trim	2017-02-16 17:20:12 -08:00
xfs_extent_busy.h	xfs: improve handling of busy extents in the low-level allocator	2017-02-09 10:50:25 -08:00
xfs_extfree_item.c	xfs: always honor OWN_UNKNOWN rmap removal requests	2017-12-21 08:48:38 -08:00
xfs_extfree_item.h
xfs_file.c	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
xfs_filestream.c	Merge branch 'xfs-4.9-log-recovery-fixes' into for-next	2016-10-03 09:56:28 +11:00
xfs_filestream.h
xfs_fsmap.c	xfs: move two more RT specific functions into CONFIG_XFS_RT	2017-10-16 12:26:50 -07:00
xfs_fsmap.h	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_fsops.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_fsops.h	xfs: hoist xfs_fs_geometry to libxfs	2018-01-08 10:54:48 -08:00
xfs_globals.c	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00
xfs_icache.c	xfs: recheck reflink / dirty page status before freeing CoW reservations	2018-01-17 21:00:47 -08:00
xfs_icache.h	xfs: remove leftover CoW reservations when remounting ro	2017-12-21 08:47:32 -08:00
xfs_icreate_item.c	fs: xfs: xfs_icreate_item: constify xfs_item_ops structure	2016-11-28 14:57:42 +11:00
xfs_icreate_item.h
xfs_inode_item.c	xfs: use a b+tree for the in-core extent list	2017-11-06 11:53:41 -08:00
xfs_inode_item.h	xfs: remove inode log format typedef	2017-11-01 15:03:16 -07:00
xfs_inode.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_inode.h	xfs: provide a centralized method for verifying inline fork data	2018-01-08 10:54:47 -08:00
xfs_ioctl32.c	xfs: refactor the geometry structure filling function	2018-01-08 10:54:48 -08:00
xfs_ioctl32.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_ioctl.c	xfs: refactor the geometry structure filling function	2018-01-08 10:54:48 -08:00
xfs_ioctl.h	xfs: remove u_int* type usage	2017-11-09 15:50:29 -08:00
xfs_iomap.c	xfs: fix s_maxbytes overflow problems	2018-01-02 10:16:32 -08:00
xfs_iomap.h	xfs: update i_size after unwritten conversion in dio completion	2017-09-26 10:55:19 -07:00
xfs_iops.c	xfs: truncate pagecache before writeback in xfs_setattr_size()	2017-11-03 09:45:56 -07:00
xfs_iops.h	xfs: Propagate dentry down to inode_change_ok()	2016-09-22 10:56:19 +02:00
xfs_itable.c	xfs: remove if_rdev	2017-10-26 15:38:27 -07:00
xfs_itable.h	xfs: create inode pointer verifiers	2017-10-26 15:38:23 -07:00
xfs_linux.h	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_log_cil.c	xfs: Fix leak of discard bio	2017-08-04 13:43:36 -07:00
xfs_log_priv.h	locking/atomics: COCCINELLE/treewide: Convert trivial ACCESS_ONCE() patterns to READ_ONCE()/WRITE_ONCE()	2017-10-25 11:01:08 +02:00
xfs_log_recover.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_log.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_log.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_message.c	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_message.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs_mount.c	xfs: destroy mutex pag_ici_reclaim_lock before free	2018-01-12 14:09:08 -08:00
xfs_mount.h	xfs: convert drop_writes to use the errortag mechanism	2017-06-27 18:23:20 -07:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_ondisk.h	xfs: Don't log uninitialised fields in inode structures	2017-10-11 10:21:06 -07:00
xfs_pnfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs_pnfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfs_qm_bhv.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_qm_syscalls.c	xfs: wait on new inodes during quotaoff dquot release	2017-04-28 08:11:08 -07:00
xfs_qm.c	xfs: use %px for data pointers when debugging	2018-01-12 14:09:08 -08:00
xfs_qm.h
xfs_quota.h
xfs_quotaops.c	VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)	2017-07-17 08:45:34 +01:00
xfs_refcount_item.c	xfs: log recovery should replay deferred ops in order	2017-11-27 09:34:08 -08:00
xfs_refcount_item.h	xfs: log recovery should replay deferred ops in order	2017-11-27 09:34:08 -08:00
xfs_reflink.c	xfs: set cowblocks tag for direct cow writes too	2017-12-21 08:47:37 -08:00
xfs_reflink.h	xfs: separate function to check if inode shares extents	2017-06-19 14:11:35 -07:00
xfs_rmap_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_rmap_item.h	xfs: convert RUI log formats to use variable length arrays	2016-09-19 10:24:27 +10:00
xfs_rtalloc.c	xfs: remove the ip argument to xfs_defer_finish	2017-09-01 10:55:30 -07:00
xfs_rtalloc.h	xfs: cross-reference the realtime bitmap	2018-01-17 21:00:46 -08:00
xfs_stats.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_stats.h	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_super.c	xfs: Show realtime device stats on statfs calls if realtime flags set	2018-01-08 10:41:33 -08:00
xfs_super.h	Rename superblock flags (MS_xyz -> SB_xyz)	2017-11-27 13:05:09 -08:00
xfs_symlink.c	xfs: remove "no-allocation" reservations for file creations	2017-12-08 17:51:05 -08:00
xfs_symlink.h	xfs: allow reading of already-locked remote symbolic link	2017-06-20 10:45:22 -07:00
xfs_sysctl.c	xfs: garbage collect old cowextsz reservations	2016-10-05 16:26:28 -07:00
xfs_sysctl.h	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_sysfs.c	xfs: replace log_badcrc_factor knob with error injection tag	2017-06-27 18:23:21 -07:00
xfs_sysfs.h
xfs_trace.c	fs: xfs: remove duplicate includes	2017-12-08 17:51:05 -08:00
xfs_trace.h	xfs: use %pS printk format for direct instruction addresses	2018-01-12 14:09:08 -08:00
xfs_trans_ail.c	xfs: move error injection tags into their own file	2017-11-01 15:03:16 -07:00
xfs_trans_bmap.c	xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent	2017-06-19 08:59:10 -07:00
xfs_trans_buf.c	xfs: disallow marking previously dirty buffers as ordered	2017-09-01 10:55:30 -07:00
xfs_trans_dquot.c
xfs_trans_extfree.c	xfs: set up per-AG free space reservations	2016-09-19 10:30:52 +10:00
xfs_trans_inode.c	xfs: refactor xfs_trans_roll	2017-09-01 10:55:30 -07:00
xfs_trans_priv.h	xfs: Properly retry failed inode items in case of error during buffer writeback	2017-08-22 09:22:23 -07:00
xfs_trans_refcount.c	xfs: connect refcount adjust functions to upper layers	2016-10-03 09:11:22 -07:00
xfs_trans_rmap.c	xfs: remove double-underscore integer types	2017-06-19 14:11:33 -07:00
xfs_trans.c	xfs: trace log reservations at mount time	2018-01-08 10:54:47 -08:00
xfs_trans.h	xfs: disallow marking previously dirty buffers as ordered	2017-09-01 10:55:30 -07:00
xfs_xattr.c	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs.h	xfs: always define STATIC to static noinline	2017-11-06 11:53:58 -08:00