2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-12 07:34:08 +08:00
linux-next/drivers/net/ethernet/marvell
Peter Senna Tschudin bbcf61fb30 drivers/net/ethernet/marvell/skge.c: fix error return code
The function skge_probe() return 0 for success and negative value
for most of its internal tests failures. There is one exception
that is error case going to err_out_led_off:. For this error case, the
function abort its success execution path, but returns non negative
value, making it difficult for a caller function to notice the error.

This patch fixes the error case that do not return negative value.

This was found by Coccinelle, but the code change was made by hand.
This patch is not robot generated.

A simplified version of the semantic match that finds this problem is
as follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-10-07 14:37:12 -04:00
..
Kconfig
Makefile
mv643xx_eth.c net: remove skb recycling 2012-10-07 00:40:54 -04:00
pxa168_eth.c ethernet: Remove casts to same type 2012-06-06 09:31:33 -07:00
skge.c drivers/net/ethernet/marvell/skge.c: fix error return code 2012-10-07 14:37:12 -04:00
skge.h
sky2.c sky2: Fix for interrupt handler 2012-07-09 00:05:40 -07:00
sky2.h sky2: Added support for Optima EEE 2012-07-09 00:05:40 -07:00