2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-17 01:54:01 +08:00
linux-next/drivers/media
Geert Uytterhoeven ba75faf43d [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success
When resuming from suspend-to-RAM on r8a7795/salvator-x:

    dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns 1
    PM: Device fe940000.fdp1 failed to resume noirq: error 1
    dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns 1
    PM: Device fe944000.fdp1 failed to resume noirq: error 1
    dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns 1
    PM: Device fe948000.fdp1 failed to resume noirq: error 1

According to its documentation, rcar_fcp_enable() returns 0 on success
or a negative error code if an error occurs.  Hence
fdp1_pm_runtime_resume() and vsp1_pm_runtime_resume() forward its return
value to their callers.

However, rcar_fcp_enable() forwards the return value of
pm_runtime_get_sync(), which can actually be 1 on success, leading to
the resume failure above.

To fix this, consider only negative values returned by
pm_runtime_get_sync() to be failures.

Fixes: 7b49235e83 ("[media] v4l: Add Renesas R-Car FCP driver")

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-08-24 14:00:01 -03:00
..
common [media] v4l2-tpg-core: drop SYCC, use higher precision 601 conversion matrix 2016-08-24 08:36:11 -03:00
dvb-core [media] doc-rst: add some needed escape codes 2016-07-23 08:05:02 -03:00
dvb-frontends [media] media: dvb-frontends: rtl2832_sdr: don't print error when allocating urb fails 2016-08-24 08:46:41 -03:00
firewire [media] dvb: modify core to implement interfaces/entities at MC new gen 2016-01-11 12:18:52 -02:00
i2c [media] adv7511: fix error return code in adv7511_probe() 2016-08-24 13:47:02 -03:00
mmc [media] siano: register media controller earlier 2015-02-26 09:10:39 -03:00
pci [media] media: pci: pt3: don't print error when adding adapter fails 2016-08-24 13:58:46 -03:00
platform [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success 2016-08-24 14:00:01 -03:00
radio [media] media: radio: si470x: radio-si470x-usb: don't print error when allocating urb fails 2016-08-24 08:46:58 -03:00
rc [media] media: rc: redrat3: don't print error when allocating urb fails 2016-08-24 08:47:41 -03:00
tuners [media] it913x: do not allow driver unbind 2016-07-08 17:01:23 -03:00
usb [media] media: usb: dvb-usb-v2: dvb_usb_core: don't print error when adding adapter fails 2016-08-24 13:57:58 -03:00
v4l2-core [media] vb2: add WARN_ONs checking if a valid struct device was passed 2016-08-24 10:18:42 -03:00
cec-edid.c [media] cec-edid: add module for EDID CEC helper functions 2016-06-28 09:45:51 -03:00
Kconfig [media] cec: fix Kconfig dependency problems 2016-07-08 18:34:00 -03:00
Makefile [media] cec: fix Kconfig dependency problems 2016-07-08 18:34:00 -03:00
media-device.c [media] media: fix media devnode ioctl/syscall and unregister race 2016-06-15 17:59:28 -03:00
media-devnode.c [media] media: fix media devnode ioctl/syscall and unregister race 2016-06-15 17:59:28 -03:00
media-entity.c [media] v4l2-core: Add support for touch devices 2016-08-23 16:28:04 -03:00