mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 20:53:53 +08:00
126f21f0e8
That code is already not traceable. Move it into the noinstr section so the objtool section validation does not trigger. Annotate the warning code as "safe". While it might be not under all circumstances, getting the information out is important enough. Should this ever trigger from the sensitive code which is shielded against instrumentation, e.g. low level entry, then the printk is the least of the worries. Addresses the objtool warnings: vmlinux.o: warning: objtool: context_tracking_recursion_enter()+0x7: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: __context_tracking_exit()+0x17: call to __this_cpu_preempt_check() leaves .noinstr.text section vmlinux.o: warning: objtool: __context_tracking_enter()+0x2a: call to __this_cpu_preempt_check() leaves .noinstr.text section Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com> Acked-by: Peter Zijlstra <peterz@infradead.org> Link: https://lkml.kernel.org/r/20200505134340.902709267@linutronix.de
68 lines
1.4 KiB
C
68 lines
1.4 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* lib/smp_processor_id.c
|
|
*
|
|
* DEBUG_PREEMPT variant of smp_processor_id().
|
|
*/
|
|
#include <linux/export.h>
|
|
#include <linux/kprobes.h>
|
|
#include <linux/sched.h>
|
|
|
|
noinstr static
|
|
unsigned int check_preemption_disabled(const char *what1, const char *what2)
|
|
{
|
|
int this_cpu = raw_smp_processor_id();
|
|
|
|
if (likely(preempt_count()))
|
|
goto out;
|
|
|
|
if (irqs_disabled())
|
|
goto out;
|
|
|
|
/*
|
|
* Kernel threads bound to a single CPU can safely use
|
|
* smp_processor_id():
|
|
*/
|
|
if (current->nr_cpus_allowed == 1)
|
|
goto out;
|
|
|
|
/*
|
|
* It is valid to assume CPU-locality during early bootup:
|
|
*/
|
|
if (system_state < SYSTEM_SCHEDULING)
|
|
goto out;
|
|
|
|
/*
|
|
* Avoid recursion:
|
|
*/
|
|
preempt_disable_notrace();
|
|
|
|
instrumentation_begin();
|
|
if (!printk_ratelimit())
|
|
goto out_enable;
|
|
|
|
printk(KERN_ERR "BUG: using %s%s() in preemptible [%08x] code: %s/%d\n",
|
|
what1, what2, preempt_count() - 1, current->comm, current->pid);
|
|
|
|
printk("caller is %pS\n", __builtin_return_address(0));
|
|
dump_stack();
|
|
instrumentation_end();
|
|
|
|
out_enable:
|
|
preempt_enable_no_resched_notrace();
|
|
out:
|
|
return this_cpu;
|
|
}
|
|
|
|
noinstr unsigned int debug_smp_processor_id(void)
|
|
{
|
|
return check_preemption_disabled("smp_processor_id", "");
|
|
}
|
|
EXPORT_SYMBOL(debug_smp_processor_id);
|
|
|
|
noinstr void __this_cpu_preempt_check(const char *op)
|
|
{
|
|
check_preemption_disabled("__this_cpu_", op);
|
|
}
|
|
EXPORT_SYMBOL(__this_cpu_preempt_check);
|