2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-12 07:14:03 +08:00
linux-next/net/hsr
Karicheri, Muralidharan 675c8da049 hsr: fix incorrect warning
When HSR interface is setup using ip link command, an annoying warning
appears with the trace as below:-

[  203.019828] hsr_get_node: Non-HSR frame
[  203.019833] Modules linked in:
[  203.019848] CPU: 0 PID: 158 Comm: sd-resolve Tainted: G        W       4.12.0-rc3-00052-g9fa6bf70 #2
[  203.019853] Hardware name: Generic DRA74X (Flattened Device Tree)
[  203.019869] [<c0110280>] (unwind_backtrace) from [<c010c2f4>] (show_stack+0x10/0x14)
[  203.019880] [<c010c2f4>] (show_stack) from [<c04b9f64>] (dump_stack+0xac/0xe0)
[  203.019894] [<c04b9f64>] (dump_stack) from [<c01374e8>] (__warn+0xd8/0x104)
[  203.019907] [<c01374e8>] (__warn) from [<c0137548>] (warn_slowpath_fmt+0x34/0x44)
root@am57xx-evm:~# [  203.019921] [<c0137548>] (warn_slowpath_fmt) from [<c081126c>] (hsr_get_node+0x148/0x170)
[  203.019932] [<c081126c>] (hsr_get_node) from [<c0814240>] (hsr_forward_skb+0x110/0x7c0)
[  203.019942] [<c0814240>] (hsr_forward_skb) from [<c0811d64>] (hsr_dev_xmit+0x2c/0x34)
[  203.019954] [<c0811d64>] (hsr_dev_xmit) from [<c06c0828>] (dev_hard_start_xmit+0xc4/0x3bc)
[  203.019963] [<c06c0828>] (dev_hard_start_xmit) from [<c06c13d8>] (__dev_queue_xmit+0x7c4/0x98c)
[  203.019974] [<c06c13d8>] (__dev_queue_xmit) from [<c0782f54>] (ip6_finish_output2+0x330/0xc1c)
[  203.019983] [<c0782f54>] (ip6_finish_output2) from [<c0788f0c>] (ip6_output+0x58/0x454)
[  203.019994] [<c0788f0c>] (ip6_output) from [<c07b16cc>] (mld_sendpack+0x420/0x744)

As this is an expected path to hsr_get_node() with frame coming from
the master interface, add a check to ensure packet is not from the
master port and then warn.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-12 15:21:20 -04:00
..
hsr_device.c net: Fix inconsistent teardown and release of private netdev state. 2017-06-07 15:53:24 -04:00
hsr_device.h net/hsr: Added support for HSR v1 2016-04-15 17:06:48 -04:00
hsr_forward.c hsr: fix incorrect warning 2017-06-12 15:21:20 -04:00
hsr_forward.h net/hsr: Better frame dispatch 2014-07-08 11:35:31 -07:00
hsr_framereg.c hsr: fix incorrect warning 2017-06-12 15:21:20 -04:00
hsr_framereg.h hsr: fix incorrect warning 2017-06-12 15:21:20 -04:00
hsr_main.c net/hsr: Fix NULL pointer dereference and refcnt bugs when deleting a HSR interface. 2015-03-01 13:40:23 -05:00
hsr_main.h net/hsr: Added support for HSR v1 2016-04-15 17:06:48 -04:00
hsr_netlink.c netlink: extended ACK reporting 2017-04-13 13:58:20 -04:00
hsr_netlink.h net/hsr: Use list_head (and rcu) instead of array for slave devices. 2014-07-08 11:35:31 -07:00
hsr_slave.c net-next: treewide use is_vlan_dev() helper function. 2017-02-06 16:33:29 -05:00
hsr_slave.h net/hsr: Better frame dispatch 2014-07-08 11:35:31 -07:00
Kconfig net/hsr: Added support for HSR v1 2016-04-15 17:06:48 -04:00
Makefile net/hsr: Better frame dispatch 2014-07-08 11:35:31 -07:00