2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-23 20:53:53 +08:00
linux-next/net/ieee802154/6lowpan
Alexander Aring aeedebff69 ieee802154: 6lowpan: fix memory leak
Looking at current situation of memory management in 6lowpan receive
function I detected some invalid handling. After calling
lowpan_invoke_rx_handlers we will do a kfree_skb and then NET_RX_DROP on
error handling. We don't do this before, also on
skb_share_check/skb_unshare which might manipulate the reference
counters.

After running some 'grep -r "dev_add_pack" net/' to look how others
packet-layer receive callbacks works I detected that every subsystem do
a kfree_skb, then NET_RX_DROP without calling skb functions which
might manipulate the skb reference counters. This is the reason why we
should do the same here like all others subsystems. I didn't find any
documentation how the packet-layer receive callbacks handle NET_RX_DROP
return values either.

This patch will add a kfree_skb, then NET_RX_DROP handling for the
"trivial checks", in case of skb_share_check/skb_unshare the kfree_skb
call will be done inside these functions.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
2015-10-22 12:24:42 +02:00
..
6lowpan_i.h ieee802154: handle datagram variables as u16 2015-10-01 13:38:22 +02:00
core.c 6lowpan: move shared settings to lowpan_netdev_setup 2015-10-08 14:25:34 +02:00
Kconfig ieee802154: create 6lowpan sub-directory 2015-01-08 07:25:59 +01:00
Makefile ieee802154: 6lowpan: fix Makefile entry 2015-01-08 15:48:06 +01:00
reassembly.c ieee802154: handle datagram variables as u16 2015-10-01 13:38:22 +02:00
rx.c ieee802154: 6lowpan: fix memory leak 2015-10-22 12:24:42 +02:00
tx.c 6lowpan: remove lowpan_is_addr_broadcast 2015-10-21 00:49:25 +02:00