mirror of
https://github.com/edk2-porting/linux-next.git
synced 2025-01-08 21:53:54 +08:00
f607e7fc5f
This fixes a regression in 3.0 reported by Paul Parsons regarding the removal of the msleep(1) in the ds1wm_reset() function: : The linux-3.0-rc4 DS1WM 1-wire driver is logging "bus error, retrying" : error messages on an HP iPAQ hx4700 PDA (XScale-PXA270): : : <snip> : Driver for 1-wire Dallas network protocol. : DS1WM w1 busmaster driver - (c) 2004 Szabolcs Gyurko : 1-Wire driver for the DS2760 battery monitor chip - (c) 2004-2005, Szabolcs Gyurko : ds1wm ds1wm: pass: 1 bus error, retrying : ds1wm ds1wm: pass: 2 bus error, retrying : ds1wm ds1wm: pass: 3 bus error, retrying : ds1wm ds1wm: pass: 4 bus error, retrying : ds1wm ds1wm: pass: 5 bus error, retrying : ... : : The visible result is that the battery charging LED is erratic; sometimes : it works, mostly it doesn't. : : The linux-2.6.39 DS1WM 1-wire driver worked OK. I haven't tried 3.0-rc1, : 3.0-rc2, or 3.0-rc3. This sleep should not be required on normal circuitry provided the pull-ups on the bus are correctly adapted to the slaves. Unfortunately, this is not always the case. The sleep is restored but as a parameter to the probe function in the pdata. [akpm@linux-foundation.org: coding-style fixes] Reported-by: Paul Parsons <lost.distance@yahoo.com> Tested-by: Paul Parsons <lost.distance@yahoo.com> Signed-off-by: Jean-François Dagenais <dagenaisj@sonatest.com> Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
ab8500 | ||
pcf50633 | ||
pm8xxx | ||
wm831x | ||
wm8350 | ||
wm8994 | ||
88pm860x.h | ||
ab8500.h | ||
abx500.h | ||
adp5520.h | ||
asic3.h | ||
core.h | ||
da903x.h | ||
davinci_voicecodec.h | ||
db5500-prcmu.h | ||
db8500-prcmu.h | ||
ds1wm.h | ||
ezx-pcap.h | ||
htc-egpio.h | ||
htc-pasic3.h | ||
janz.h | ||
max8925.h | ||
max8997-private.h | ||
max8997.h | ||
max8998-private.h | ||
max8998.h | ||
mc13xxx.h | ||
mc13783.h | ||
mc13892.h | ||
mcp.h | ||
rdc321x.h | ||
stmpe.h | ||
t7l66xb.h | ||
tc3589x.h | ||
tc6387xb.h | ||
tc6393xb.h | ||
ti_ssp.h | ||
tmio.h | ||
tps6105x.h | ||
tps6507x.h | ||
tps6586x.h | ||
tps65910.h | ||
twl4030-codec.h | ||
ucb1x00.h | ||
wl1273-core.h | ||
wm8400-audio.h | ||
wm8400-private.h | ||
wm8400.h |