mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-26 06:04:14 +08:00
0d025d271e
There are three usercopy warnings which are currently being silenced for
gcc 4.6 and newer:
1) "copy_from_user() buffer size is too small" compile warning/error
This is a static warning which happens when object size and copy size
are both const, and copy size > object size. I didn't see any false
positives for this one. So the function warning attribute seems to
be working fine here.
Note this scenario is always a bug and so I think it should be
changed to *always* be an error, regardless of
CONFIG_DEBUG_STRICT_USER_COPY_CHECKS.
2) "copy_from_user() buffer size is not provably correct" compile warning
This is another static warning which happens when I enable
__compiletime_object_size() for new compilers (and
CONFIG_DEBUG_STRICT_USER_COPY_CHECKS). It happens when object size
is const, but copy size is *not*. In this case there's no way to
compare the two at build time, so it gives the warning. (Note the
warning is a byproduct of the fact that gcc has no way of knowing
whether the overflow function will be called, so the call isn't dead
code and the warning attribute is activated.)
So this warning seems to only indicate "this is an unusual pattern,
maybe you should check it out" rather than "this is a bug".
I get 102(!) of these warnings with allyesconfig and the
__compiletime_object_size() gcc check removed. I don't know if there
are any real bugs hiding in there, but from looking at a small
sample, I didn't see any. According to Kees, it does sometimes find
real bugs. But the false positive rate seems high.
3) "Buffer overflow detected" runtime warning
This is a runtime warning where object size is const, and copy size >
object size.
All three warnings (both static and runtime) were completely disabled
for gcc 4.6 with the following commit:
2fb0815c9e ("gcc4: disable __compiletime_object_size for GCC 4.6+")
That commit mistakenly assumed that the false positives were caused by a
gcc bug in __compiletime_object_size(). But in fact,
__compiletime_object_size() seems to be working fine. The false
positives were instead triggered by #2 above. (Though I don't have an
explanation for why the warnings supposedly only started showing up in
gcc 4.6.)
So remove warning #2 to get rid of all the false positives, and re-enable
warnings #1 and #3 by reverting the above commit.
Furthermore, since #1 is a real bug which is detected at compile time,
upgrade it to always be an error.
Having done all that, CONFIG_DEBUG_STRICT_USER_COPY_CHECKS is no longer
needed.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Nilay Vaish <nilayvaish@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
251 lines
5.6 KiB
Plaintext
251 lines
5.6 KiB
Plaintext
# CONFIG_LOCALVERSION_AUTO is not set
|
|
CONFIG_SYSVIPC=y
|
|
CONFIG_POSIX_MQUEUE=y
|
|
CONFIG_FHANDLE=y
|
|
CONFIG_BSD_PROCESS_ACCT=y
|
|
CONFIG_BSD_PROCESS_ACCT_V3=y
|
|
CONFIG_IKCONFIG=y
|
|
CONFIG_IKCONFIG_PROC=y
|
|
CONFIG_RELAY=y
|
|
CONFIG_BLK_DEV_INITRD=y
|
|
CONFIG_RD_BZIP2=y
|
|
CONFIG_RD_LZMA=y
|
|
CONFIG_RD_LZO=y
|
|
CONFIG_EXPERT=y
|
|
CONFIG_SYSCTL_SYSCALL=y
|
|
CONFIG_SLAB=y
|
|
CONFIG_MODULES=y
|
|
CONFIG_MODULE_UNLOAD=y
|
|
CONFIG_MODULE_FORCE_UNLOAD=y
|
|
CONFIG_MODVERSIONS=y
|
|
CONFIG_BLK_DEV_INTEGRITY=y
|
|
CONFIG_PA8X00=y
|
|
CONFIG_64BIT=y
|
|
CONFIG_SMP=y
|
|
CONFIG_PREEMPT=y
|
|
# CONFIG_CROSS_MEMORY_ATTACH is not set
|
|
CONFIG_IOMMU_CCIO=y
|
|
CONFIG_PCI=y
|
|
CONFIG_PCI_LBA=y
|
|
# CONFIG_SUPERIO is not set
|
|
# CONFIG_CHASSIS_LCD_LED is not set
|
|
# CONFIG_PDC_CHASSIS is not set
|
|
# CONFIG_PDC_CHASSIS_WARN is not set
|
|
# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
|
|
CONFIG_BINFMT_MISC=m
|
|
CONFIG_NET=y
|
|
CONFIG_PACKET=y
|
|
CONFIG_UNIX=y
|
|
CONFIG_XFRM_USER=m
|
|
CONFIG_XFRM_SUB_POLICY=y
|
|
CONFIG_NET_KEY=m
|
|
CONFIG_INET=y
|
|
CONFIG_IP_MULTICAST=y
|
|
CONFIG_IP_PNP=y
|
|
CONFIG_IP_PNP_DHCP=y
|
|
CONFIG_IP_PNP_BOOTP=y
|
|
CONFIG_IP_PNP_RARP=y
|
|
CONFIG_NET_IPIP=m
|
|
CONFIG_IP_MROUTE=y
|
|
CONFIG_IP_PIMSM_V1=y
|
|
CONFIG_IP_PIMSM_V2=y
|
|
CONFIG_SYN_COOKIES=y
|
|
CONFIG_INET_AH=m
|
|
CONFIG_INET_ESP=m
|
|
CONFIG_INET_IPCOMP=m
|
|
CONFIG_INET_XFRM_MODE_BEET=m
|
|
CONFIG_INET_DIAG=m
|
|
# CONFIG_IPV6 is not set
|
|
CONFIG_IP_DCCP=m
|
|
# CONFIG_IP_DCCP_CCID3 is not set
|
|
CONFIG_TIPC=m
|
|
CONFIG_LLC2=m
|
|
CONFIG_DNS_RESOLVER=y
|
|
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
|
|
CONFIG_DEVTMPFS=y
|
|
CONFIG_DEVTMPFS_MOUNT=y
|
|
# CONFIG_STANDALONE is not set
|
|
CONFIG_PARPORT=y
|
|
CONFIG_PARPORT_PC=y
|
|
CONFIG_PARPORT_PC_FIFO=y
|
|
CONFIG_BLK_DEV_UMEM=m
|
|
CONFIG_BLK_DEV_LOOP=m
|
|
CONFIG_BLK_DEV_CRYPTOLOOP=m
|
|
CONFIG_BLK_DEV_SX8=m
|
|
CONFIG_BLK_DEV_RAM=y
|
|
CONFIG_BLK_DEV_RAM_SIZE=6144
|
|
CONFIG_CDROM_PKTCDVD=m
|
|
CONFIG_CDROM_PKTCDVD_WCACHE=y
|
|
CONFIG_ATA_OVER_ETH=m
|
|
CONFIG_IDE=y
|
|
CONFIG_BLK_DEV_IDECD=y
|
|
CONFIG_BLK_DEV_PLATFORM=y
|
|
CONFIG_BLK_DEV_GENERIC=y
|
|
CONFIG_BLK_DEV_SD=y
|
|
CONFIG_CHR_DEV_ST=m
|
|
CONFIG_BLK_DEV_SR=m
|
|
CONFIG_CHR_DEV_SG=y
|
|
CONFIG_CHR_DEV_SCH=m
|
|
CONFIG_SCSI_CONSTANTS=y
|
|
CONFIG_SCSI_LOGGING=y
|
|
CONFIG_SCSI_FC_ATTRS=y
|
|
CONFIG_SCSI_SAS_LIBSAS=m
|
|
CONFIG_ISCSI_TCP=m
|
|
CONFIG_ISCSI_BOOT_SYSFS=m
|
|
CONFIG_ATA=y
|
|
CONFIG_PATA_SIL680=y
|
|
CONFIG_FUSION=y
|
|
CONFIG_FUSION_SPI=y
|
|
CONFIG_FUSION_SAS=y
|
|
CONFIG_NETDEVICES=y
|
|
CONFIG_DUMMY=m
|
|
CONFIG_NETCONSOLE=m
|
|
CONFIG_TUN=y
|
|
CONFIG_E1000=y
|
|
CONFIG_PPP=m
|
|
CONFIG_PPP_BSDCOMP=m
|
|
CONFIG_PPP_DEFLATE=m
|
|
CONFIG_PPP_MPPE=m
|
|
CONFIG_PPPOE=m
|
|
CONFIG_PPP_ASYNC=m
|
|
CONFIG_PPP_SYNC_TTY=m
|
|
# CONFIG_WLAN is not set
|
|
CONFIG_INPUT_FF_MEMLESS=m
|
|
# CONFIG_KEYBOARD_ATKBD is not set
|
|
# CONFIG_KEYBOARD_HIL_OLD is not set
|
|
# CONFIG_KEYBOARD_HIL is not set
|
|
# CONFIG_MOUSE_PS2 is not set
|
|
CONFIG_INPUT_MISC=y
|
|
CONFIG_SERIO_SERPORT=m
|
|
CONFIG_SERIO_PARKBD=m
|
|
CONFIG_SERIO_GSCPS2=m
|
|
# CONFIG_HP_SDC is not set
|
|
CONFIG_SERIO_PCIPS2=m
|
|
CONFIG_SERIO_LIBPS2=y
|
|
CONFIG_SERIO_RAW=m
|
|
CONFIG_SERIAL_8250=y
|
|
# CONFIG_SERIAL_8250_DEPRECATED_OPTIONS is not set
|
|
CONFIG_SERIAL_8250_CONSOLE=y
|
|
CONFIG_SERIAL_8250_NR_UARTS=8
|
|
CONFIG_SERIAL_8250_RUNTIME_UARTS=8
|
|
CONFIG_SERIAL_8250_EXTENDED=y
|
|
# CONFIG_SERIAL_MUX is not set
|
|
CONFIG_SERIAL_JSM=m
|
|
CONFIG_PRINTER=y
|
|
CONFIG_HW_RANDOM=y
|
|
CONFIG_RAW_DRIVER=m
|
|
CONFIG_PTP_1588_CLOCK=y
|
|
CONFIG_SSB=m
|
|
CONFIG_SSB_DRIVER_PCICORE=y
|
|
CONFIG_AGP=y
|
|
CONFIG_AGP_PARISC=y
|
|
CONFIG_DRM=y
|
|
CONFIG_DRM_RADEON=y
|
|
CONFIG_FIRMWARE_EDID=y
|
|
CONFIG_FB_FOREIGN_ENDIAN=y
|
|
CONFIG_FB_MODE_HELPERS=y
|
|
CONFIG_FB_TILEBLITTING=y
|
|
# CONFIG_FB_STI is not set
|
|
CONFIG_BACKLIGHT_LCD_SUPPORT=y
|
|
# CONFIG_LCD_CLASS_DEVICE is not set
|
|
# CONFIG_BACKLIGHT_GENERIC is not set
|
|
CONFIG_FRAMEBUFFER_CONSOLE=y
|
|
# CONFIG_STI_CONSOLE is not set
|
|
CONFIG_LOGO=y
|
|
# CONFIG_LOGO_LINUX_MONO is not set
|
|
# CONFIG_LOGO_LINUX_VGA16 is not set
|
|
# CONFIG_LOGO_LINUX_CLUT224 is not set
|
|
CONFIG_SOUND=m
|
|
CONFIG_SND=m
|
|
CONFIG_SND_SEQUENCER=m
|
|
CONFIG_SND_SEQ_DUMMY=m
|
|
CONFIG_SND_MIXER_OSS=m
|
|
CONFIG_SND_PCM_OSS=m
|
|
CONFIG_SND_SEQUENCER_OSS=y
|
|
CONFIG_SND_VERBOSE_PRINTK=y
|
|
CONFIG_SND_AD1889=m
|
|
# CONFIG_SND_USB is not set
|
|
# CONFIG_SND_GSC is not set
|
|
CONFIG_USB=y
|
|
CONFIG_USB_OHCI_HCD=y
|
|
CONFIG_USB_STORAGE=y
|
|
CONFIG_EXT2_FS=y
|
|
CONFIG_EXT2_FS_XATTR=y
|
|
CONFIG_EXT2_FS_POSIX_ACL=y
|
|
CONFIG_EXT2_FS_SECURITY=y
|
|
CONFIG_EXT3_FS=y
|
|
# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
|
|
CONFIG_EXT4_FS=m
|
|
CONFIG_REISERFS_FS=m
|
|
CONFIG_REISERFS_PROC_INFO=y
|
|
CONFIG_XFS_FS=m
|
|
CONFIG_XFS_POSIX_ACL=y
|
|
CONFIG_QUOTA=y
|
|
CONFIG_QFMT_V1=m
|
|
CONFIG_QFMT_V2=m
|
|
CONFIG_AUTOFS4_FS=m
|
|
CONFIG_FUSE_FS=m
|
|
CONFIG_ISO9660_FS=y
|
|
CONFIG_JOLIET=y
|
|
CONFIG_MSDOS_FS=m
|
|
CONFIG_VFAT_FS=m
|
|
CONFIG_PROC_KCORE=y
|
|
CONFIG_TMPFS=y
|
|
CONFIG_TMPFS_XATTR=y
|
|
CONFIG_NFS_FS=m
|
|
CONFIG_NLS_CODEPAGE_437=m
|
|
CONFIG_NLS_CODEPAGE_737=m
|
|
CONFIG_NLS_CODEPAGE_775=m
|
|
CONFIG_NLS_CODEPAGE_850=m
|
|
CONFIG_NLS_CODEPAGE_852=m
|
|
CONFIG_NLS_CODEPAGE_855=m
|
|
CONFIG_NLS_CODEPAGE_857=m
|
|
CONFIG_NLS_CODEPAGE_860=m
|
|
CONFIG_NLS_CODEPAGE_861=m
|
|
CONFIG_NLS_CODEPAGE_862=m
|
|
CONFIG_NLS_CODEPAGE_863=m
|
|
CONFIG_NLS_CODEPAGE_864=m
|
|
CONFIG_NLS_CODEPAGE_865=m
|
|
CONFIG_NLS_CODEPAGE_866=m
|
|
CONFIG_NLS_CODEPAGE_869=m
|
|
CONFIG_NLS_CODEPAGE_936=m
|
|
CONFIG_NLS_CODEPAGE_950=m
|
|
CONFIG_NLS_CODEPAGE_932=m
|
|
CONFIG_NLS_CODEPAGE_949=m
|
|
CONFIG_NLS_CODEPAGE_874=m
|
|
CONFIG_NLS_ISO8859_8=m
|
|
CONFIG_NLS_CODEPAGE_1250=m
|
|
CONFIG_NLS_CODEPAGE_1251=m
|
|
CONFIG_NLS_ASCII=m
|
|
CONFIG_NLS_ISO8859_1=m
|
|
CONFIG_NLS_ISO8859_2=m
|
|
CONFIG_NLS_ISO8859_3=m
|
|
CONFIG_NLS_ISO8859_4=m
|
|
CONFIG_NLS_ISO8859_5=m
|
|
CONFIG_NLS_ISO8859_6=m
|
|
CONFIG_NLS_ISO8859_7=m
|
|
CONFIG_NLS_ISO8859_9=m
|
|
CONFIG_NLS_ISO8859_13=m
|
|
CONFIG_NLS_ISO8859_14=m
|
|
CONFIG_NLS_ISO8859_15=m
|
|
CONFIG_NLS_KOI8_R=m
|
|
CONFIG_NLS_KOI8_U=m
|
|
CONFIG_NLS_UTF8=m
|
|
CONFIG_UNUSED_SYMBOLS=y
|
|
CONFIG_DEBUG_FS=y
|
|
CONFIG_MAGIC_SYSRQ=y
|
|
CONFIG_DEBUG_SLAB=y
|
|
CONFIG_DEBUG_SLAB_LEAK=y
|
|
CONFIG_DEBUG_MEMORY_INIT=y
|
|
CONFIG_DEBUG_STACKOVERFLOW=y
|
|
CONFIG_LOCKUP_DETECTOR=y
|
|
CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC=y
|
|
CONFIG_PANIC_ON_OOPS=y
|
|
CONFIG_DEBUG_RT_MUTEXES=y
|
|
CONFIG_PROVE_RCU_DELAY=y
|
|
CONFIG_DEBUG_BLOCK_EXT_DEVT=y
|
|
CONFIG_LATENCYTOP=y
|
|
CONFIG_KEYS=y
|
|
# CONFIG_CRYPTO_HW is not set
|
|
CONFIG_FONTS=y
|