Robert Schlabbach a6441ea29c media: si2157: Fix "warm" tuner state detection ... Commit e955f959ac ("media: si2157: Better check for running tuner in init") completely broke the "warm" tuner detection of the si2157 driver due to a simple endian error: The Si2157 CRYSTAL_TRIM property code is 0x0402 and needs to be transmitted LSB first. However, it was inserted MSB first, causing the warm detection to always fail and spam the kernel log with tuner initialization messages each time the DVB frontend device was closed and reopened: [ 312.215682] si2157 16-0060: found a 'Silicon Labs Si2157-A30' [ 312.264334] si2157 16-0060: firmware version: 3.0.5 [ 342.248593] si2157 16-0060: found a 'Silicon Labs Si2157-A30' [ 342.295743] si2157 16-0060: firmware version: 3.0.5 [ 372.328574] si2157 16-0060: found a 'Silicon Labs Si2157-A30' [ 372.385035] si2157 16-0060: firmware version: 3.0.5 Also, the reinitializations were observed disturb _other_ tuners on multi-tuner cards such as the Hauppauge WinTV-QuadHD, leading to missed or errored packets when one of the other DVB frontend devices on that card was opened. Fix the order of the property code bytes to make the warm detection work again, also reducing the tuner initialization message in the kernel log to once per power-on, as well as fixing the interference with other tuners. Link: https://lore.kernel.org/linux-media/trinity-2a86eb9d-6264-4387-95e1-ba7b79a4050f-1638392923493@3c-app-gmx-bap03 Fixes: e955f959ac ("media: si2157: Better check for running tuner in init") Reported-by: Robert Schlabbach <robert_s@gmx.net> Signed-off-by: Robert Schlabbach <robert_s@gmx.net> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>		2021-12-07 11:29:57 +01:00
..
e4000_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
e4000.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
e4000.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
fc001x-common.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc0011.c	media: Use fallthrough pseudo-keyword	2020-08-29 08:35:27 +02:00
fc0011.h	media: move dvb kAPI headers to include/media	2017-12-28 13:16:01 -05:00
fc0012-priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc0012.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc0012.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc0013-priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc0013.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc0013.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
fc2580_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
fc2580.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
fc2580.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
it913x.c	media: tuners/it913x.c: fix missing error code	2021-01-27 08:33:01 +01:00
it913x.h	media: media tuner headers: fix kernel-doc warnings	2021-03-22 10:24:27 +01:00
Kconfig	media: tuners: Kconfig: add some missing VIDEO_V4L2 dependencies	2020-04-23 07:57:27 +02:00
m88rs6000t.c	media: m88rs6000t: avoid potential out-of-bounds reads on arrays	2021-03-22 17:41:39 +01:00
m88rs6000t.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
Makefile	media: tuners: add new i2c driver for Sharp qm1d1b0004 ISDB-S tuner	2018-05-05 07:21:09 -04:00
max2165_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
max2165.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
max2165.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mc44s803_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mc44s803.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mc44s803.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
msi001.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt20xx.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
mt20xx.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
mt2060_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt2060.c	media: mt2060: use semicolons rather than commas to separate statements	2020-11-16 10:31:07 +01:00
mt2060.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt2063.c	media: fix incorrect kernel doc usages	2021-03-11 11:59:44 +01:00
mt2063.h	media: move dvb kAPI headers to include/media	2017-12-28 13:16:01 -05:00
mt2131_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt2131.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt2131.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt2266.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mt2266.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
mxl301rf.c	media: dvb: convert tuner_info frequencies to Hz	2018-08-02 16:14:50 -04:00
mxl301rf.h	media: tuners/mxl301rf: use SPDX License Identifier	2018-05-04 14:45:21 -04:00
mxl5005s.c	media: mxl5005s: drop some dead code	2021-11-29 13:23:25 +01:00
mxl5005s.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
mxl5007t.c	media: tuners: mxl5007t: Removed unnecessary 'return'	2021-09-30 10:07:40 +02:00
mxl5007t.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
qm1d1b0004.c	media: dvb: convert tuner_info frequencies to Hz	2018-08-02 16:14:50 -04:00
qm1d1b0004.h	media: tuners: fix several typos	2019-03-01 09:40:29 -05:00
qm1d1c0042.c	media: qm1d1c0042: fix error return code in qm1d1c0042_init()	2021-01-27 12:59:17 +01:00
qm1d1c0042.h	media: tuners/qm1d1c0042: use SPDX License Identifier	2018-05-04 14:45:45 -04:00
qt1010_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
qt1010.c	media: qt1010: fix usage of unititialized value	2020-09-03 11:07:57 +02:00
qt1010.h	media: media tuner headers: fix kernel-doc warnings	2021-03-22 10:24:27 +01:00
r820t.c	media: tuners: fix several typos	2019-03-01 09:40:29 -05:00
r820t.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
si2157_priv.h	media: si2157: Add analog tuning related functions	2020-04-21 16:46:25 +02:00
si2157.c	media: si2157: Fix "warm" tuner state detection	2021-12-07 11:29:57 +01:00
si2157.h	media: si2157: Add option for not downloading firmware.	2019-10-10 07:07:14 -03:00
tda827x.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda827x.h	media: media tuner headers: fix kernel-doc warnings	2021-03-22 10:24:27 +01:00
tda8290.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tda8290.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tda9887.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
tda9887.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tda18212.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
tda18212.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 1	2019-05-21 11:28:39 +02:00
tda18218_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda18218.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda18218.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda18250_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda18250.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda18250.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tda18271-common.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tda18271-fe.c	media: Use fallthrough pseudo-keyword	2020-08-29 08:35:27 +02:00
tda18271-maps.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tda18271-priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tda18271.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tea5761.c	MAINTAINERS & files: Canonize the e-mails I use at files	2018-05-04 06:21:06 -04:00
tea5761.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tea5767.c	MAINTAINERS & files: Canonize the e-mails I use at files	2018-05-04 06:21:06 -04:00
tea5767.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tua9001_priv.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tua9001.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tua9001.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
tuner-i2c.h	media: tuners: fix error return code of hybrid_tuner_request_state()	2021-03-22 10:21:03 +01:00
tuner-simple.c	media: tuner-simple: fix regression in simple_set_radio_freq	2020-08-26 18:51:50 +02:00
tuner-simple.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
tuner-types.c	Linux 5.15-rc4	2021-10-04 07:52:13 +02:00
tuner-xc2028-types.h	media: tuners: Use the correct style for SPDX License Identifier	2019-10-24 18:57:55 -03:00
tuner-xc2028.c	media: media/tuners: Use kmemdup rather than duplicating its implementation	2019-08-14 05:03:11 -03:00
tuner-xc2028.h	media: tuners: Use the correct style for SPDX License Identifier	2019-10-24 18:57:55 -03:00
xc4000.c	media: media/tuners: Use kmemdup rather than duplicating its implementation	2019-08-14 05:03:11 -03:00
xc4000.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
xc5000.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
xc5000.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00