mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-21 11:44:01 +08:00
cb27a843de
800d78bfcc ("mmc: dw_mmc: add support for implementation specific
callbacks") -- merged in v3.7-rc1 -- introduced multiple NULL pointer
dereferences when the default dw_mci_pltfm_probe() is used, as it sets
host->drv_data to NULL, and that's only checked against NULL in 1 out of
the 7 cases where it is dereferenced.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Acked-by: Will Newton <will.newton@imgtec.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
147 lines
3.3 KiB
C
147 lines
3.3 KiB
C
/*
|
|
* Synopsys DesignWare Multimedia Card Interface driver
|
|
*
|
|
* Copyright (C) 2009 NXP Semiconductors
|
|
* Copyright (C) 2009, 2010 Imagination Technologies Ltd.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/interrupt.h>
|
|
#include <linux/module.h>
|
|
#include <linux/io.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/mmc/host.h>
|
|
#include <linux/mmc/mmc.h>
|
|
#include <linux/mmc/dw_mmc.h>
|
|
#include <linux/of.h>
|
|
|
|
#include "dw_mmc.h"
|
|
|
|
int dw_mci_pltfm_register(struct platform_device *pdev,
|
|
struct dw_mci_drv_data *drv_data)
|
|
{
|
|
struct dw_mci *host;
|
|
struct resource *regs;
|
|
int ret;
|
|
|
|
host = devm_kzalloc(&pdev->dev, sizeof(struct dw_mci), GFP_KERNEL);
|
|
if (!host)
|
|
return -ENOMEM;
|
|
|
|
regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!regs)
|
|
return -ENXIO;
|
|
|
|
host->irq = platform_get_irq(pdev, 0);
|
|
if (host->irq < 0)
|
|
return host->irq;
|
|
|
|
host->drv_data = drv_data;
|
|
host->dev = &pdev->dev;
|
|
host->irq_flags = 0;
|
|
host->pdata = pdev->dev.platform_data;
|
|
host->regs = devm_request_and_ioremap(&pdev->dev, regs);
|
|
if (!host->regs)
|
|
return -ENOMEM;
|
|
|
|
if (drv_data && drv_data->init) {
|
|
ret = drv_data->init(host);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, host);
|
|
ret = dw_mci_probe(host);
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL_GPL(dw_mci_pltfm_register);
|
|
|
|
static int __devinit dw_mci_pltfm_probe(struct platform_device *pdev)
|
|
{
|
|
return dw_mci_pltfm_register(pdev, NULL);
|
|
}
|
|
|
|
static int __devexit dw_mci_pltfm_remove(struct platform_device *pdev)
|
|
{
|
|
struct dw_mci *host = platform_get_drvdata(pdev);
|
|
|
|
platform_set_drvdata(pdev, NULL);
|
|
dw_mci_remove(host);
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(dw_mci_pltfm_remove);
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
/*
|
|
* TODO: we should probably disable the clock to the card in the suspend path.
|
|
*/
|
|
static int dw_mci_pltfm_suspend(struct device *dev)
|
|
{
|
|
int ret;
|
|
struct dw_mci *host = dev_get_drvdata(dev);
|
|
|
|
ret = dw_mci_suspend(host);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int dw_mci_pltfm_resume(struct device *dev)
|
|
{
|
|
int ret;
|
|
struct dw_mci *host = dev_get_drvdata(dev);
|
|
|
|
ret = dw_mci_resume(host);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
#else
|
|
#define dw_mci_pltfm_suspend NULL
|
|
#define dw_mci_pltfm_resume NULL
|
|
#endif /* CONFIG_PM_SLEEP */
|
|
|
|
SIMPLE_DEV_PM_OPS(dw_mci_pltfm_pmops, dw_mci_pltfm_suspend, dw_mci_pltfm_resume);
|
|
EXPORT_SYMBOL_GPL(dw_mci_pltfm_pmops);
|
|
|
|
static const struct of_device_id dw_mci_pltfm_match[] = {
|
|
{ .compatible = "snps,dw-mshc", },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
|
|
|
|
static struct platform_driver dw_mci_pltfm_driver = {
|
|
.remove = __exit_p(dw_mci_pltfm_remove),
|
|
.driver = {
|
|
.name = "dw_mmc",
|
|
.of_match_table = of_match_ptr(dw_mci_pltfm_match),
|
|
.pm = &dw_mci_pltfm_pmops,
|
|
},
|
|
};
|
|
|
|
static int __init dw_mci_init(void)
|
|
{
|
|
return platform_driver_probe(&dw_mci_pltfm_driver, dw_mci_pltfm_probe);
|
|
}
|
|
|
|
static void __exit dw_mci_exit(void)
|
|
{
|
|
platform_driver_unregister(&dw_mci_pltfm_driver);
|
|
}
|
|
|
|
module_init(dw_mci_init);
|
|
module_exit(dw_mci_exit);
|
|
|
|
MODULE_DESCRIPTION("DW Multimedia Card Interface driver");
|
|
MODULE_AUTHOR("NXP Semiconductor VietNam");
|
|
MODULE_AUTHOR("Imagination Technologies Ltd");
|
|
MODULE_LICENSE("GPL v2");
|