2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-16 17:23:55 +08:00
linux-next/drivers/target/iscsi
Jesper Juhl 9be08c5804 iscsi-target: Fix leak on failure in iscsi_copy_param_list()
We leak memory if the allocations for 'new_param->name' or
'new_param->value' fail in iscsi_target_parameters.c::iscsi_copy_param_list()

We also do a lot of variable assignments that are completely pointless
if the allocations fail.

So, let's move the allocations before the assignments and also make
sure that we free whatever was allocated to one if the allocation fail.

There's also some small CodingStyle fixups in there (curly braces on
both branches of if statement, only one variable per line) since I was
in the area anyway. And finally, error messages in the function are
put on a single line for easy grep'abillity.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2011-08-22 19:26:16 +00:00
..
iscsi_target_auth.c
iscsi_target_auth.h
iscsi_target_configfs.c target: Use ERR_CAST inlined function 2011-08-22 19:26:15 +00:00
iscsi_target_configfs.h
iscsi_target_core.h
iscsi_target_datain_values.c
iscsi_target_datain_values.h
iscsi_target_device.c
iscsi_target_device.h
iscsi_target_erl0.c
iscsi_target_erl0.h
iscsi_target_erl1.c
iscsi_target_erl1.h
iscsi_target_erl2.c
iscsi_target_erl2.h
iscsi_target_login.c
iscsi_target_login.h
iscsi_target_nego.c
iscsi_target_nego.h
iscsi_target_nodeattrib.c
iscsi_target_nodeattrib.h
iscsi_target_parameters.c iscsi-target: Fix leak on failure in iscsi_copy_param_list() 2011-08-22 19:26:16 +00:00
iscsi_target_parameters.h
iscsi_target_seq_pdu_list.c
iscsi_target_seq_pdu_list.h
iscsi_target_stat.c
iscsi_target_stat.h
iscsi_target_tmr.c
iscsi_target_tmr.h
iscsi_target_tpg.c
iscsi_target_tpg.h
iscsi_target_tq.c
iscsi_target_tq.h
iscsi_target_util.c
iscsi_target_util.h
iscsi_target.c iscsi-target: Fix CONFIG_SMP=n and CONFIG_MODULES=n build failure 2011-07-27 20:28:49 +00:00
iscsi_target.h
Kconfig target: iscsi_target depends on NET 2011-07-28 20:16:18 +00:00
Makefile