mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-19 02:34:01 +08:00
97715058b7
When CONFIG_NO_AUTO_INLINE was present in linux-next (which added '-fno-inline-functions' to KBUILD_CFLAGS), an allyesconfig build with Clang failed at the modpost stage: ERROR: "is_broadcast_mac_addr" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! ERROR: "is_zero_mac_addr" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! ERROR: "is_multicast_mac_addr" [drivers/staging/rtl8723bs/r8723bs.ko] undefined! These functions were marked as extern inline, meaning that if inlining doesn't happen, the function will be undefined, as it is above. This happens to work with GCC because the '-fno-inline-functions' option respects the __inline attribute so all instances of these functions are inlined as expected and the definition doesn't actually matter. However, with Clang and '-fno-inline-functions', a function has to be marked with the __always_inline attribute to be considered for inlining, which none of these functions are. Clang tries to find the symbol definition elsewhere as it was told and fails, which trickles down to modpost. To make sure that this code compiles regardless of compiler and make the intention of the code clearer, use 'static' to ensure these functions are always defined, regardless of inlining. Additionally, silence a checkpatch warning by switching from '__inline' to 'inline'. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
|---|---|---|
| .. | ||
| android | ||
| axis-fifo | ||
| board | ||
| clocking-wizard | ||
| comedi | ||
| emxx_udc | ||
| erofs | ||
| fbtft | ||
| fsl-dpaa2 | ||
| fwserial | ||
| gasket | ||
| gdm724x | ||
| goldfish | ||
| greybus | ||
| gs_fpgaboot | ||
| iio | ||
| ks7010 | ||
| media | ||
| most | ||
| mt7621-dma | ||
| mt7621-dts | ||
| mt7621-eth | ||
| mt7621-mmc | ||
| mt7621-pci | ||
| mt7621-pinctrl | ||
| mt7621-spi | ||
| netlogic | ||
| nvec | ||
| octeon | ||
| octeon-usb | ||
| olpc_dcon | ||
| pi433 | ||
| rtl8188eu | ||
| rtl8192e | ||
| rtl8192u | ||
| rtl8712 | ||
| rtl8723bs | ||
| rtlwifi | ||
| rts5208 | ||
| sm750fb | ||
| speakup | ||
| unisys | ||
| vboxvideo | ||
| vc04_services | ||
| vme | ||
| vt6655 | ||
| vt6656 | ||
| wilc1000 | ||
| wlan-ng | ||
| xgifb | ||
| Kconfig | ||
| Makefile | ||