mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-22 12:14:01 +08:00
09d4d9648b
Ensure that the cited expression is not a function call or an assignment to reduce the chance of false positives. Slightly modify the warning message to indicate another source of false positves. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
59 lines
1.1 KiB
Plaintext
59 lines
1.1 KiB
Plaintext
/// Find &&/|| operations that include the same argument more than once
|
|
//# A common source of false positives is when the expression, or
|
|
//# another expresssion in the same && or || operation, performs a
|
|
//# side effect.
|
|
///
|
|
// Confidence: Moderate
|
|
// Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2.
|
|
// Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2.
|
|
// Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2.
|
|
// URL: http://coccinelle.lip6.fr/
|
|
// Comments:
|
|
// Options: --no-includes --include-headers
|
|
|
|
virtual context
|
|
virtual org
|
|
virtual report
|
|
|
|
@r expression@
|
|
expression E;
|
|
position p;
|
|
@@
|
|
|
|
(
|
|
E@p || ... || E
|
|
|
|
|
E@p && ... && E
|
|
)
|
|
|
|
@bad@
|
|
expression r.E,e1,e2,fn;
|
|
position r.p;
|
|
assignment operator op;
|
|
@@
|
|
|
|
(
|
|
E@p
|
|
&
|
|
<+... \(fn(...)\|e1 op e2\|e1++\|e1--\|++e1\|--e1\) ...+>
|
|
)
|
|
|
|
@depends on context && !bad@
|
|
expression r.E;
|
|
position r.p;
|
|
@@
|
|
|
|
*E@p
|
|
|
|
@script:python depends on org && !bad@
|
|
p << r.p;
|
|
@@
|
|
|
|
cocci.print_main("duplicated argument to && or ||",p)
|
|
|
|
@script:python depends on report && !bad@
|
|
p << r.p;
|
|
@@
|
|
|
|
coccilib.report.print_report(p[0],"duplicated argument to && or ||")
|