Vladimir Davydov 95fc3c5010 memcg: do not abuse memcg_kmem_skip_account ... task_struct->memcg_kmem_skip_account was initially introduced to avoid recursion during kmem cache creation: memcg_kmem_get_cache, which is called by kmem_cache_alloc to determine the per-memcg cache to account allocation to, may issue lazy cache creation if the needed cache doesn't exist, which means issuing yet another kmem_cache_alloc. We can't just pass a flag to the nested kmem_cache_alloc disabling kmem accounting, because there are hidden allocations, e.g. in INIT_WORK. So we introduced a flag on the task_struct, memcg_kmem_skip_account, making memcg_kmem_get_cache return immediately. By its nature, the flag may also be used to disable accounting for allocations shared among different cgroups, and currently it is used this way in memcg_activate_kmem. Using it like this looks like abusing it to me. If we want to disable accounting for some allocations (which we will definitely want one day), we should either add GFP_NO_MEMCG or GFP_MEMCG flag in order to blacklist/whitelist some allocations. For now, let's simply remove memcg_stop/resume_kmem_account from memcg_activate_kmem. Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michal Hocko <mhocko@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2014-12-13 12:42:46 -08:00
..
backing-dev.c	Merge branch 'for-3.18/core' of git://git.kernel.dk/linux-block	2014-10-18 11:53:51 -07:00
balloon_compaction.c	mm/balloon_compaction: fix deflation when compaction is disabled	2014-10-29 16:33:15 -07:00
bootmem.c	mem-hotplug: reset node managed pages when hot-adding a new pgdat	2014-11-13 16:17:06 -08:00
cleancache.c	mm: dump page when hitting a VM_BUG_ON using VM_BUG_ON_PAGE	2014-01-23 16:36:50 -08:00
cma.c	mm: cma: align to physical address, not CMA region position	2014-12-13 12:42:46 -08:00
compaction.c	mm, compaction: more focused lru and pcplists draining	2014-12-10 17:41:06 -08:00
debug-pagealloc.c
debug.c	mm: move page->mem_cgroup bad page handling into generic code	2014-12-10 17:41:09 -08:00
dmapool.c	mm/dmapool.c: fixed a brace coding style issue	2014-10-09 22:26:00 -04:00
early_ioremap.c	mm: create generic early_ioremap() support	2014-04-07 16:36:15 -07:00
fadvise.c	teach SYSCALL_DEFINE<n> how to deal with long long/unsigned long long	2013-03-03 22:46:22 -05:00
failslab.c
filemap_xip.c	mm/xip: share the i_mmap_rwsem	2014-12-13 12:42:45 -08:00
filemap.c	mm: convert i_mmap_mutex to rwsem	2014-12-13 12:42:45 -08:00
fremap.c	mm: use new helper functions around the i_mmap_mutex	2014-12-13 12:42:45 -08:00
frontswap.c	mm/frontswap.c: fix the condition in BUG_ON	2014-12-10 17:41:08 -08:00
gup.c	mm: Update generic gup implementation to handle hugepage directory	2014-11-14 17:24:21 +11:00
highmem.c	mm/highmem: make kmap cache coloring aware	2014-08-06 18:01:22 -07:00
huge_memory.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2014-12-11 17:30:55 -08:00
hugetlb_cgroup.c	mm: hugetlb_cgroup: convert to lockless page counters	2014-12-10 17:41:04 -08:00
hugetlb.c	mm: convert i_mmap_mutex to rwsem	2014-12-13 12:42:45 -08:00
hwpoison-inject.c	mm/hwpoison-inject.c: remove unnecessary null test before debugfs_remove_recursive	2014-08-06 18:01:19 -07:00
init-mm.c
internal.h	mm, compaction: always update cached scanner positions	2014-12-10 17:41:06 -08:00
interval_tree.c	mm: convert a few VM_BUG_ON callers to VM_BUG_ON_VMA	2014-10-09 22:25:57 -04:00
iov_iter.c	copy_from_iter_nocache()	2014-12-08 20:25:23 -05:00
Kconfig	mm/balloon_compaction: add vmstat counters and kpageflags bit	2014-10-09 22:26:01 -04:00
Kconfig.debug
kmemcheck.c	mm/slab_common: move kmem_cache definition to internal header	2014-10-09 22:25:50 -04:00
kmemleak-test.c	mm/kmemleak-test.c: use pr_fmt for logging	2014-06-06 16:08:18 -07:00
kmemleak.c	mm: introduce kmemleak_update_trace()	2014-06-06 16:08:17 -07:00
ksm.c	mm: ksm use pr_err instead of printk	2014-10-09 22:26:00 -04:00
list_lru.c	mm: keep page cache radix tree nodes in check	2014-04-03 16:21:01 -07:00
maccess.c
madvise.c	mm: update the description for madvise_remove	2014-08-06 18:01:18 -07:00
Makefile	mm: page_cgroup: rename file to mm/swap_cgroup.c	2014-12-10 17:41:09 -08:00
memblock.c	mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range()	2014-09-10 15:42:12 -07:00
memcontrol.c	memcg: do not abuse memcg_kmem_skip_account	2014-12-13 12:42:46 -08:00
memory_hotplug.c	mm, memory_hotplug/failure: drain single zone pcplists	2014-12-10 17:41:05 -08:00
memory-failure.c	mm/memory-failure: share the i_mmap_rwsem	2014-12-13 12:42:45 -08:00
memory.c	mm/memory.c: share the i_mmap_rwsem	2014-12-13 12:42:46 -08:00
mempolicy.c	mm: mempolicy: skip inaccessible VMAs when setting MPOL_MF_LAZY	2014-10-09 22:26:02 -04:00
mempool.c	mm/mempool.c: update the kmemleak stack trace for mempool allocations	2014-06-06 16:08:17 -07:00
migrate.c	mm/balloon_compaction: redesign ballooned pages management	2014-10-09 22:26:01 -04:00
mincore.c	mm + fs: prepare for non-page entries in page cache radix trees	2014-04-03 16:21:00 -07:00
mlock.c	Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-10-13 15:44:12 +02:00
mm_init.c	mm: bring back /sys/kernel/mm	2014-01-27 21:02:39 -08:00
mmap.c	mm: convert i_mmap_mutex to rwsem	2014-12-13 12:42:45 -08:00
mmu_context.c	sched/mm: call finish_arch_post_lock_switch in idle_task_exit and use_mm	2014-02-21 08:50:17 +01:00
mmu_notifier.c	kvm: Fix page ageing bugs	2014-09-24 14:07:58 +02:00
mmzone.c	mm: numa: Change page last {nid,pid} into {cpu,pid}	2013-10-09 14:47:45 +02:00
mprotect.c	mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared	2014-10-14 02:18:28 +02:00
mremap.c	mm: convert i_mmap_mutex to rwsem	2014-12-13 12:42:45 -08:00
msync.c	msync: fix incorrect fstart calculation	2014-07-03 09:21:53 -07:00
nobootmem.c	mem-hotplug: reset node managed pages when hot-adding a new pgdat	2014-11-13 16:17:06 -08:00
nommu.c	mm/nommu: share the i_mmap_rwsem	2014-12-13 12:42:46 -08:00
oom_kill.c	Merge branch 'for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2014-12-11 18:57:19 -08:00
page_alloc.c	Merge branch 'for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2014-12-11 18:57:19 -08:00
page_counter.c	mm: memcontrol: remove obsolete kmemcg pinning tricks	2014-12-10 17:41:05 -08:00
page_io.c	fix __swap_writepage() compile failure on old gcc versions	2014-06-14 19:30:48 -05:00
page_isolation.c	mm, page_isolation: drain single zone pcplists	2014-12-10 17:41:05 -08:00
page-writeback.c	mm, memcg: fix potential undefined behaviour in page stat accounting	2014-12-10 17:41:08 -08:00
pagewalk.c	mm: use VM_BUG_ON_MM where possible	2014-10-09 22:25:58 -04:00
percpu-km.c	percpu: implmeent pcpu_nr_empty_pop_pages and chunk->nr_populated	2014-09-02 14:46:05 -04:00
percpu-vm.c	percpu: move region iterations out of pcpu_[de]populate_chunk()	2014-09-02 14:46:02 -04:00
percpu.c	percpu: off by one in BUG_ON()	2014-10-29 10:34:34 -04:00
pgtable-generic.c	mm: actually clear pmd_numa before invalidating	2014-08-29 16:28:15 -07:00
process_vm_access.c	start adding the tag to iov_iter	2014-05-06 17:32:49 -04:00
quicklist.c
readahead.c	mm/readahead.c: remove unused file_ra_state from count_history_pages	2014-08-06 18:01:15 -07:00
rmap.c	mm/rmap: share the i_mmap_rwsem	2014-12-13 12:42:45 -08:00
shmem.c	shmem: support RENAME_WHITEOUT	2014-10-24 00:14:37 +02:00
slab_common.c	memcg: use generic slab iterators for showing slabinfo	2014-12-10 17:41:07 -08:00
slab.c	Merge branch 'for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2014-12-11 18:57:19 -08:00
slab.h	memcg: use generic slab iterators for showing slabinfo	2014-12-10 17:41:07 -08:00
slob.c	mm/sl[ao]b: always track caller in kmalloc_(node_)track_caller()	2014-10-09 22:25:50 -04:00
slub.c	Merge branch 'for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2014-12-11 18:57:19 -08:00
sparse-vmemmap.c	mm/sparse: use memblock apis for early memory allocations	2014-01-21 16:19:47 -08:00
sparse.c	mm: use macros from compiler.h instead of __attribute__((...))	2014-04-07 16:35:54 -07:00
swap_cgroup.c	mm: page_cgroup: rename file to mm/swap_cgroup.c	2014-12-10 17:41:09 -08:00
swap_state.c	mm: page_cgroup: rename file to mm/swap_cgroup.c	2014-12-10 17:41:09 -08:00
swap.c	mm: memcontrol: do not kill uncharge batching in free_pages_and_swap_cache	2014-10-09 22:25:59 -04:00
swapfile.c	mm: page_cgroup: rename file to mm/swap_cgroup.c	2014-12-10 17:41:09 -08:00
truncate.c	mm: Fix comment before truncate_setsize()	2014-11-07 08:29:25 +11:00
util.c	proc/maps: make vm_is_stack() logic namespace-friendly	2014-10-09 22:25:50 -04:00
vmacache.c	mm,vmacache: optimize overflow system-wide flushing	2014-06-04 16:53:57 -07:00
vmalloc.c	mm/vmalloc.c: replace printk with pr_warn	2014-12-10 17:41:05 -08:00
vmpressure.c	mm/vmpressure.c: fix race in vmpressure_work_fn()	2014-12-02 17:32:07 -08:00
vmscan.c	Merge branch 'for-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup	2014-12-11 18:57:19 -08:00
vmstat.c	vmstat: on-demand vmstat workers V8	2014-10-09 22:26:02 -04:00
workingset.c	mm: keep page cache radix tree nodes in check	2014-04-03 16:21:01 -07:00
zbud.c	Merge Linus' tree to be be to apply submitted patches to newer code than	2014-11-20 14:42:02 +01:00
zpool.c	mm/zpool: use prefixed module loading	2014-08-29 16:28:16 -07:00
zsmalloc.c	zsmalloc: simplify init_zspage free obj linking	2014-10-09 22:26:03 -04:00
zswap.c	Merge Linus' tree to be be to apply submitted patches to newer code than	2014-11-20 14:42:02 +01:00