Maciej W. Rozycki 824122a319 MIPS: DEC/SNI: O32 wrapper stack switching fixes ... Commit 231a35d372 [[MIPS] RM: Collected changes] broke DECstation support by introducing an incompatible copy of arch/mips/dec/prom/call_o32.S in arch/mips/fw/lib/, built unconditionally. The copy happens to land earlier of the two among the modules used in the link and is therefore chosen for the DECstation rather than the intended original. As a result random kernel data is corrupted because a pointer to the "%s" formatted output template is used as a temporary stack pointer rather than being passed down to prom_printf. This also explains why prom_printf still works, up to a point -- the next argument is the actual string to output so it works just fine as the output template until enough kernel data has been corrupted to cause a crash. This change adjusts the modified wrapper in arch/mips/fw/lib/call_o32.S to let callers request no stack switching by passing a null temporary stack pointer in $a1, reworks the DECstation callers to work with the updated interface and removes the old copy from arch/mips/dec/prom/call_o32.S. A few minor readability adjustments are included as well, most importantly O32_SZREG is now used throughout where applicable rather than hardcoded multiplies of 4 and $fp is used to access the argument save area as a more usual register to operate the stack with rather than $s0. Finally an update is made to the temporary stack space used by the SNI platform to guarantee 8-byte alignment as per o32 requirements. Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/6668/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>		2014-05-13 00:29:35 +02:00
..
arc	mips: delete non-required instances of include <linux/init.h>	2014-01-24 22:39:56 +01:00
cfe	MIPS: sibyte: Declare the cfe_write() buffer as constant	2013-06-21 18:07:02 +02:00
lib	MIPS: DEC/SNI: O32 wrapper stack switching fixes	2014-05-13 00:29:35 +02:00
sni	MIPS: DEC/SNI: O32 wrapper stack switching fixes	2014-05-13 00:29:35 +02:00