mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 20:53:53 +08:00
9e630bcb77
Registration of a memory region(MR) through FRMR/fastreg(unlike FMR) needs a connection/qp. With a proxy qp, this dependency on connection will be removed, but that needs more infrastructure patches, which is a work in progress. As an intermediate fix, the get_mr returns EOPNOTSUPP when connection details are not populated. The MR registration through sendmsg() will continue to work even with fast registration, since connection in this case is formed upfront. This patch fixes the following crash: kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] SMP KASAN Modules linked in: CPU: 1 PID: 4244 Comm: syzkaller468044 Not tainted 4.16.0-rc6+ #361 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:rds_ib_get_mr+0x5c/0x230 net/rds/ib_rdma.c:544 RSP: 0018:ffff8801b059f890 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: ffff8801b07e1300 RCX: ffffffff8562d96e RDX: 000000000000000d RSI: 0000000000000001 RDI: 0000000000000068 RBP: ffff8801b059f8b8 R08: ffffed0036274244 R09: ffff8801b13a1200 R10: 0000000000000004 R11: ffffed0036274243 R12: ffff8801b13a1200 R13: 0000000000000001 R14: ffff8801ca09fa9c R15: 0000000000000000 FS: 00007f4d050af700(0000) GS:ffff8801db300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f4d050aee78 CR3: 00000001b0d9b006 CR4: 00000000001606e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __rds_rdma_map+0x710/0x1050 net/rds/rdma.c:271 rds_get_mr_for_dest+0x1d4/0x2c0 net/rds/rdma.c:357 rds_setsockopt+0x6cc/0x980 net/rds/af_rds.c:347 SYSC_setsockopt net/socket.c:1849 [inline] SyS_setsockopt+0x189/0x360 net/socket.c:1828 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 RIP: 0033:0x4456d9 RSP: 002b:00007f4d050aedb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 00000000006dac3c RCX: 00000000004456d9 RDX: 0000000000000007 RSI: 0000000000000114 RDI: 0000000000000004 RBP: 00000000006dac38 R08: 00000000000000a0 R09: 0000000000000000 R10: 0000000020000380 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fffbfb36d6f R14: 00007f4d050af9c0 R15: 0000000000000005 Code: fa 48 c1 ea 03 80 3c 02 00 0f 85 cc 01 00 00 4c 8b bb 80 04 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7f 68 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 9c 01 00 00 4d 8b 7f 68 48 b8 00 00 00 00 00 RIP: rds_ib_get_mr+0x5c/0x230 net/rds/ib_rdma.c:544 RSP: ffff8801b059f890 ---[ end trace 7e1cea13b85473b0 ]--- Reported-by: syzbot+b51c77ef956678a65834@syzkaller.appspotmail.com Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by: Avinash Repaka <avinash.repaka@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
145 lines
4.8 KiB
C
145 lines
4.8 KiB
C
/*
|
|
* Copyright (c) 2016 Oracle. All rights reserved.
|
|
*
|
|
* This software is available to you under a choice of one of two
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
* General Public License (GPL) Version 2, available from the file
|
|
* COPYING in the main directory of this source tree, or the
|
|
* OpenIB.org BSD license below:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* - Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
#ifndef _RDS_IB_MR_H
|
|
#define _RDS_IB_MR_H
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include "rds.h"
|
|
#include "ib.h"
|
|
|
|
#define RDS_MR_1M_POOL_SIZE (8192 / 2)
|
|
#define RDS_MR_1M_MSG_SIZE 256
|
|
#define RDS_MR_8K_MSG_SIZE 2
|
|
#define RDS_MR_8K_SCALE (256 / (RDS_MR_8K_MSG_SIZE + 1))
|
|
#define RDS_MR_8K_POOL_SIZE (RDS_MR_8K_SCALE * (8192 / 2))
|
|
|
|
struct rds_ib_fmr {
|
|
struct ib_fmr *fmr;
|
|
};
|
|
|
|
enum rds_ib_fr_state {
|
|
FRMR_IS_FREE, /* mr invalidated & ready for use */
|
|
FRMR_IS_INUSE, /* mr is in use or used & can be invalidated */
|
|
FRMR_IS_STALE, /* Stale MR and needs to be dropped */
|
|
};
|
|
|
|
struct rds_ib_frmr {
|
|
struct ib_mr *mr;
|
|
enum rds_ib_fr_state fr_state;
|
|
bool fr_inv;
|
|
struct ib_send_wr fr_wr;
|
|
unsigned int dma_npages;
|
|
unsigned int sg_byte_len;
|
|
};
|
|
|
|
/* This is stored as mr->r_trans_private. */
|
|
struct rds_ib_mr {
|
|
struct rds_ib_device *device;
|
|
struct rds_ib_mr_pool *pool;
|
|
struct rds_ib_connection *ic;
|
|
|
|
struct llist_node llnode;
|
|
|
|
/* unmap_list is for freeing */
|
|
struct list_head unmap_list;
|
|
unsigned int remap_count;
|
|
|
|
struct scatterlist *sg;
|
|
unsigned int sg_len;
|
|
int sg_dma_len;
|
|
|
|
union {
|
|
struct rds_ib_fmr fmr;
|
|
struct rds_ib_frmr frmr;
|
|
} u;
|
|
};
|
|
|
|
/* Our own little MR pool */
|
|
struct rds_ib_mr_pool {
|
|
unsigned int pool_type;
|
|
struct mutex flush_lock; /* serialize fmr invalidate */
|
|
struct delayed_work flush_worker; /* flush worker */
|
|
|
|
atomic_t item_count; /* total # of MRs */
|
|
atomic_t dirty_count; /* # dirty of MRs */
|
|
|
|
struct llist_head drop_list; /* MRs not reached max_maps */
|
|
struct llist_head free_list; /* unused MRs */
|
|
struct llist_head clean_list; /* unused & unmapped MRs */
|
|
wait_queue_head_t flush_wait;
|
|
|
|
atomic_t free_pinned; /* memory pinned by free MRs */
|
|
unsigned long max_items;
|
|
unsigned long max_items_soft;
|
|
unsigned long max_free_pinned;
|
|
struct ib_fmr_attr fmr_attr;
|
|
bool use_fastreg;
|
|
};
|
|
|
|
extern struct workqueue_struct *rds_ib_mr_wq;
|
|
extern bool prefer_frmr;
|
|
|
|
struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_dev,
|
|
int npages);
|
|
void rds_ib_get_mr_info(struct rds_ib_device *rds_ibdev,
|
|
struct rds_info_rdma_connection *iinfo);
|
|
void rds_ib_destroy_mr_pool(struct rds_ib_mr_pool *);
|
|
void *rds_ib_get_mr(struct scatterlist *sg, unsigned long nents,
|
|
struct rds_sock *rs, u32 *key_ret,
|
|
struct rds_connection *conn);
|
|
void rds_ib_sync_mr(void *trans_private, int dir);
|
|
void rds_ib_free_mr(void *trans_private, int invalidate);
|
|
void rds_ib_flush_mrs(void);
|
|
int rds_ib_mr_init(void);
|
|
void rds_ib_mr_exit(void);
|
|
|
|
void __rds_ib_teardown_mr(struct rds_ib_mr *);
|
|
void rds_ib_teardown_mr(struct rds_ib_mr *);
|
|
struct rds_ib_mr *rds_ib_alloc_fmr(struct rds_ib_device *, int);
|
|
struct rds_ib_mr *rds_ib_reuse_mr(struct rds_ib_mr_pool *);
|
|
int rds_ib_flush_mr_pool(struct rds_ib_mr_pool *, int, struct rds_ib_mr **);
|
|
struct rds_ib_mr *rds_ib_reg_fmr(struct rds_ib_device *, struct scatterlist *,
|
|
unsigned long, u32 *);
|
|
struct rds_ib_mr *rds_ib_try_reuse_ibmr(struct rds_ib_mr_pool *);
|
|
void rds_ib_unreg_fmr(struct list_head *, unsigned int *,
|
|
unsigned long *, unsigned int);
|
|
void rds_ib_free_fmr_list(struct rds_ib_mr *);
|
|
struct rds_ib_mr *rds_ib_reg_frmr(struct rds_ib_device *rds_ibdev,
|
|
struct rds_ib_connection *ic,
|
|
struct scatterlist *sg,
|
|
unsigned long nents, u32 *key);
|
|
void rds_ib_unreg_frmr(struct list_head *list, unsigned int *nfreed,
|
|
unsigned long *unpinned, unsigned int goal);
|
|
void rds_ib_free_frmr_list(struct rds_ib_mr *);
|
|
#endif
|