Casey Schaufler 87fbfffcc8 broken ping to ipv6 linklocal addresses on debian buster ... I am seeing ping failures to IPv6 linklocal addresses with Debian buster. Easiest example to reproduce is: $ ping -c1 -w1 ff02::1%eth1 connect: Invalid argument $ ping -c1 -w1 ff02::1%eth1 PING ff02::01%eth1(ff02::1%eth1) 56 data bytes 64 bytes from fe80::e0:f9ff:fe0c:37%eth1: icmp_seq=1 ttl=64 time=0.059 ms git bisect traced the failure to commit b9ef5513c9 ("smack: Check address length before reading address family") Arguably ping is being stupid since the buster version is not setting the address family properly (ping on stretch for example does): $ strace -e connect ping6 -c1 -w1 ff02::1%eth1 connect(5, {sa_family=AF_UNSPEC, sa_data="\4\1\0\0\0\0\377\2\0\0\0\0\0\0\0\0\0\0\0\0\0\1\3\0\0\0"}, 28) = -1 EINVAL (Invalid argument) but the command works fine on kernels prior to this commit, so this is breakage which goes against the Linux paradigm of "don't break userspace" Cc: stable@vger.kernel.org Reported-by: David Ahern <dsahern@gmail.com> Suggested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>  security/smack/smack_lsm.c | 41 +++++++++++++++++++---------------------- 1 file changed, 19 insertions(+), 22 deletions(-)		2020-02-05 14:16:27 -08:00
..
apparmor	apparmor: fix aa_xattrs_match() may sleep while holding a RCU lock	2020-01-04 15:56:44 -08:00
integrity	treewide: Use sizeof_field() macro	2019-12-09 10:36:44 -08:00
keys	security: keys: trusted: fix lost handle flush	2019-12-17 11:46:43 +02:00
loadpin	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
lockdown	powerpc updates for 5.5	2019-11-30 14:35:43 -08:00
safesetid	security/safesetid: Replace rcu_swap_protected() with rcu_replace_pointer()	2019-10-30 08:45:57 -07:00
selinux	y2038: syscall implementation cleanups	2019-12-01 14:00:59 -08:00
smack	broken ping to ipv6 linklocal addresses on debian buster	2020-02-05 14:16:27 -08:00
tomoyo	tomoyo: Suppress RCU warning at list_for_each_entry_rcu().	2019-12-16 23:02:27 +09:00
yama	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
commoncap.c	Merge branch 'next-lsm' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-07-09 12:24:21 -07:00
device_cgroup.c	device_cgroup: Export devcgroup_check_permission	2019-10-07 15:11:38 -05:00
inode.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
Kconfig	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
Kconfig.hardening	meminit fix	2019-07-28 12:33:15 -07:00
lsm_audit.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
Makefile	security: Add a static lockdown policy LSM	2019-08-19 21:54:15 -07:00
min_addr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
security.c	perf_event: Add support for LSM and SELinux checks	2019-10-17 21:31:55 +02:00