mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-22 20:23:57 +08:00
eb4ec68acf
strict pin controller returns -EINVAL in case of pin request which is already claimed by somebody else. Following is the sequence of calling pin_request() from pinctrl_bind_pins():- pinctrl_bind_pins()->pinctrl_select_state()->pinmux_enable_setting()-> pin_request() But pinctrl_bind_pins() only returns -EPROBE_DEFER which makes device driver probe successful even if the pin request is rejected by the pin controller subsystem. This commit modifies pinctrl_bind_pins() to return error if the pin is rejected by pin control subsystem. Signed-off-by: Deepak Das <deepak_das@mentor.com> [Rewrote to be cleaner] Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
104 lines
2.7 KiB
C
104 lines
2.7 KiB
C
/*
|
|
* Driver core interface to the pinctrl subsystem.
|
|
*
|
|
* Copyright (C) 2012 ST-Ericsson SA
|
|
* Written on behalf of Linaro for ST-Ericsson
|
|
* Based on bits of regulator core, gpio core and clk core
|
|
*
|
|
* Author: Linus Walleij <linus.walleij@linaro.org>
|
|
*
|
|
* License terms: GNU General Public License (GPL) version 2
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/pinctrl/devinfo.h>
|
|
#include <linux/pinctrl/consumer.h>
|
|
#include <linux/slab.h>
|
|
|
|
/**
|
|
* pinctrl_bind_pins() - called by the device core before probe
|
|
* @dev: the device that is just about to probe
|
|
*/
|
|
int pinctrl_bind_pins(struct device *dev)
|
|
{
|
|
int ret;
|
|
|
|
dev->pins = devm_kzalloc(dev, sizeof(*(dev->pins)), GFP_KERNEL);
|
|
if (!dev->pins)
|
|
return -ENOMEM;
|
|
|
|
dev->pins->p = devm_pinctrl_get(dev);
|
|
if (IS_ERR(dev->pins->p)) {
|
|
dev_dbg(dev, "no pinctrl handle\n");
|
|
ret = PTR_ERR(dev->pins->p);
|
|
goto cleanup_alloc;
|
|
}
|
|
|
|
dev->pins->default_state = pinctrl_lookup_state(dev->pins->p,
|
|
PINCTRL_STATE_DEFAULT);
|
|
if (IS_ERR(dev->pins->default_state)) {
|
|
dev_dbg(dev, "no default pinctrl state\n");
|
|
ret = 0;
|
|
goto cleanup_get;
|
|
}
|
|
|
|
dev->pins->init_state = pinctrl_lookup_state(dev->pins->p,
|
|
PINCTRL_STATE_INIT);
|
|
if (IS_ERR(dev->pins->init_state)) {
|
|
/* Not supplying this state is perfectly legal */
|
|
dev_dbg(dev, "no init pinctrl state\n");
|
|
|
|
ret = pinctrl_select_state(dev->pins->p,
|
|
dev->pins->default_state);
|
|
} else {
|
|
ret = pinctrl_select_state(dev->pins->p, dev->pins->init_state);
|
|
}
|
|
|
|
if (ret) {
|
|
dev_dbg(dev, "failed to activate initial pinctrl state\n");
|
|
goto cleanup_get;
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
/*
|
|
* If power management is enabled, we also look for the optional
|
|
* sleep and idle pin states, with semantics as defined in
|
|
* <linux/pinctrl/pinctrl-state.h>
|
|
*/
|
|
dev->pins->sleep_state = pinctrl_lookup_state(dev->pins->p,
|
|
PINCTRL_STATE_SLEEP);
|
|
if (IS_ERR(dev->pins->sleep_state))
|
|
/* Not supplying this state is perfectly legal */
|
|
dev_dbg(dev, "no sleep pinctrl state\n");
|
|
|
|
dev->pins->idle_state = pinctrl_lookup_state(dev->pins->p,
|
|
PINCTRL_STATE_IDLE);
|
|
if (IS_ERR(dev->pins->idle_state))
|
|
/* Not supplying this state is perfectly legal */
|
|
dev_dbg(dev, "no idle pinctrl state\n");
|
|
#endif
|
|
|
|
return 0;
|
|
|
|
/*
|
|
* If no pinctrl handle or default state was found for this device,
|
|
* let's explicitly free the pin container in the device, there is
|
|
* no point in keeping it around.
|
|
*/
|
|
cleanup_get:
|
|
devm_pinctrl_put(dev->pins->p);
|
|
cleanup_alloc:
|
|
devm_kfree(dev, dev->pins);
|
|
dev->pins = NULL;
|
|
|
|
/* Return deferrals */
|
|
if (ret == -EPROBE_DEFER)
|
|
return ret;
|
|
/* Return serious errors */
|
|
if (ret == -EINVAL)
|
|
return ret;
|
|
/* We ignore errors like -ENOENT meaning no pinctrl state */
|
|
|
|
return 0;
|
|
}
|