mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-28 23:23:55 +08:00
bf5c9cc8ad
The driver core ignores the return value of mei_cl_device_remove() so passing an error value doesn't solve any problem. As most mei drivers' remove callbacks return 0 unconditionally and returning a different value doesn't have any effect, change this prototype to return void and return 0 unconditionally in mei_cl_device_remove(). The only driver that could return an error value is modified to emit an explicit warning in the error case. Acked-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Link: https://lore.kernel.org/r/20210208073705.428185-3-uwe@kleine-koenig.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
76 lines
1.5 KiB
C
76 lines
1.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2013 Intel Corporation. All rights reserved.
|
|
*
|
|
* HCI based Driver for NXP pn544 NFC Chip
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/mod_devicetable.h>
|
|
#include <linux/nfc.h>
|
|
#include <net/nfc/hci.h>
|
|
#include <net/nfc/llc.h>
|
|
|
|
#include "../mei_phy.h"
|
|
#include "pn544.h"
|
|
|
|
#define PN544_DRIVER_NAME "pn544"
|
|
|
|
static int pn544_mei_probe(struct mei_cl_device *cldev,
|
|
const struct mei_cl_device_id *id)
|
|
{
|
|
struct nfc_mei_phy *phy;
|
|
int r;
|
|
|
|
pr_info("Probing NFC pn544\n");
|
|
|
|
phy = nfc_mei_phy_alloc(cldev);
|
|
if (!phy) {
|
|
pr_err("Cannot allocate memory for pn544 mei phy.\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
r = pn544_hci_probe(phy, &mei_phy_ops, LLC_NOP_NAME,
|
|
MEI_NFC_HEADER_SIZE, 0, MEI_NFC_MAX_HCI_PAYLOAD,
|
|
NULL, &phy->hdev);
|
|
if (r < 0) {
|
|
nfc_mei_phy_free(phy);
|
|
|
|
return r;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void pn544_mei_remove(struct mei_cl_device *cldev)
|
|
{
|
|
struct nfc_mei_phy *phy = mei_cldev_get_drvdata(cldev);
|
|
|
|
pr_info("Removing pn544\n");
|
|
|
|
pn544_hci_remove(phy->hdev);
|
|
|
|
nfc_mei_phy_free(phy);
|
|
}
|
|
|
|
static struct mei_cl_device_id pn544_mei_tbl[] = {
|
|
{ PN544_DRIVER_NAME, MEI_NFC_UUID, MEI_CL_VERSION_ANY},
|
|
|
|
/* required last entry */
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(mei, pn544_mei_tbl);
|
|
|
|
static struct mei_cl_driver pn544_driver = {
|
|
.id_table = pn544_mei_tbl,
|
|
.name = PN544_DRIVER_NAME,
|
|
|
|
.probe = pn544_mei_probe,
|
|
.remove = pn544_mei_remove,
|
|
};
|
|
|
|
module_mei_cl_driver(pn544_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION(DRIVER_DESC);
|