mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 04:34:11 +08:00
f9bccfcc3b
XFS has some inconsistent log message rate limiting with respect to buffer alerts. The metadata I/O error notification uses the generic ratelimited alert, the buffer push code uses a custom rate limit and the similar quiesce time failure checks are not rate limited at all (when they should be). The custom rate limit defined in the buf item code is specifically crafted for buffer alerts. It is more aggressive than generic rate limiting code because it must accommodate a high frequency of I/O error events in a relative short timeframe. Factor out the custom rate limit state from the buf item code into a per-buftarg rate limit so various alerts are limited based on the target. Define a buffer alert helper function and use it for the buffer alerts that are already ratelimited. Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Allison Collins <allison.henderson@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
142 lines
2.8 KiB
C
142 lines
2.8 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (c) 2011 Red Hat, Inc. All Rights Reserved.
|
|
*/
|
|
|
|
#include "xfs.h"
|
|
#include "xfs_fs.h"
|
|
#include "xfs_error.h"
|
|
#include "xfs_shared.h"
|
|
#include "xfs_format.h"
|
|
#include "xfs_trans_resv.h"
|
|
#include "xfs_mount.h"
|
|
|
|
/*
|
|
* XFS logging functions
|
|
*/
|
|
static void
|
|
__xfs_printk(
|
|
const char *level,
|
|
const struct xfs_mount *mp,
|
|
struct va_format *vaf)
|
|
{
|
|
if (mp && mp->m_super) {
|
|
printk("%sXFS (%s): %pV\n", level, mp->m_super->s_id, vaf);
|
|
return;
|
|
}
|
|
printk("%sXFS: %pV\n", level, vaf);
|
|
}
|
|
|
|
#define define_xfs_printk_level(func, kern_level) \
|
|
void func(const struct xfs_mount *mp, const char *fmt, ...) \
|
|
{ \
|
|
struct va_format vaf; \
|
|
va_list args; \
|
|
int level; \
|
|
\
|
|
va_start(args, fmt); \
|
|
\
|
|
vaf.fmt = fmt; \
|
|
vaf.va = &args; \
|
|
\
|
|
__xfs_printk(kern_level, mp, &vaf); \
|
|
va_end(args); \
|
|
\
|
|
if (!kstrtoint(kern_level, 0, &level) && \
|
|
level <= LOGLEVEL_ERR && \
|
|
xfs_error_level >= XFS_ERRLEVEL_HIGH) \
|
|
xfs_stack_trace(); \
|
|
} \
|
|
|
|
define_xfs_printk_level(xfs_emerg, KERN_EMERG);
|
|
define_xfs_printk_level(xfs_alert, KERN_ALERT);
|
|
define_xfs_printk_level(xfs_crit, KERN_CRIT);
|
|
define_xfs_printk_level(xfs_err, KERN_ERR);
|
|
define_xfs_printk_level(xfs_warn, KERN_WARNING);
|
|
define_xfs_printk_level(xfs_notice, KERN_NOTICE);
|
|
define_xfs_printk_level(xfs_info, KERN_INFO);
|
|
#ifdef DEBUG
|
|
define_xfs_printk_level(xfs_debug, KERN_DEBUG);
|
|
#endif
|
|
|
|
void
|
|
xfs_alert_tag(
|
|
const struct xfs_mount *mp,
|
|
int panic_tag,
|
|
const char *fmt, ...)
|
|
{
|
|
struct va_format vaf;
|
|
va_list args;
|
|
int do_panic = 0;
|
|
|
|
if (xfs_panic_mask && (xfs_panic_mask & panic_tag)) {
|
|
xfs_alert(mp, "Transforming an alert into a BUG.");
|
|
do_panic = 1;
|
|
}
|
|
|
|
va_start(args, fmt);
|
|
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
|
|
__xfs_printk(KERN_ALERT, mp, &vaf);
|
|
va_end(args);
|
|
|
|
BUG_ON(do_panic);
|
|
}
|
|
|
|
void
|
|
asswarn(
|
|
struct xfs_mount *mp,
|
|
char *expr,
|
|
char *file,
|
|
int line)
|
|
{
|
|
xfs_warn(mp, "Assertion failed: %s, file: %s, line: %d",
|
|
expr, file, line);
|
|
WARN_ON(1);
|
|
}
|
|
|
|
void
|
|
assfail(
|
|
struct xfs_mount *mp,
|
|
char *expr,
|
|
char *file,
|
|
int line)
|
|
{
|
|
xfs_emerg(mp, "Assertion failed: %s, file: %s, line: %d",
|
|
expr, file, line);
|
|
if (xfs_globals.bug_on_assert)
|
|
BUG();
|
|
else
|
|
WARN_ON(1);
|
|
}
|
|
|
|
void
|
|
xfs_hex_dump(const void *p, int length)
|
|
{
|
|
print_hex_dump(KERN_ALERT, "", DUMP_PREFIX_OFFSET, 16, 1, p, length, 1);
|
|
}
|
|
|
|
void
|
|
xfs_buf_alert_ratelimited(
|
|
struct xfs_buf *bp,
|
|
const char *rlmsg,
|
|
const char *fmt,
|
|
...)
|
|
{
|
|
struct xfs_mount *mp = bp->b_mount;
|
|
struct va_format vaf;
|
|
va_list args;
|
|
|
|
/* use the more aggressive per-target rate limit for buffers */
|
|
if (!___ratelimit(&bp->b_target->bt_ioerror_rl, rlmsg))
|
|
return;
|
|
|
|
va_start(args, fmt);
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
__xfs_printk(KERN_ALERT, mp, &vaf);
|
|
va_end(args);
|
|
}
|