mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-20 19:23:57 +08:00
7e1c4e2792
When a memblock allocation APIs are called with align = 0, the alignment is implicitly set to SMP_CACHE_BYTES. Implicit alignment is done deep in the memblock allocator and it can come as a surprise. Not that such an alignment would be wrong even when used incorrectly but it is better to be explicit for the sake of clarity and the prinicple of the least surprise. Replace all such uses of memblock APIs with the 'align' parameter explicitly set to SMP_CACHE_BYTES and stop implicit alignment assignment in the memblock internal allocation functions. For the case when memblock APIs are used via helper functions, e.g. like iommu_arena_new_node() in Alpha, the helper functions were detected with Coccinelle's help and then manually examined and updated where appropriate. The direct memblock APIs users were updated using the semantic patch below: @@ expression size, min_addr, max_addr, nid; @@ ( | - memblock_alloc_try_nid_raw(size, 0, min_addr, max_addr, nid) + memblock_alloc_try_nid_raw(size, SMP_CACHE_BYTES, min_addr, max_addr, nid) | - memblock_alloc_try_nid_nopanic(size, 0, min_addr, max_addr, nid) + memblock_alloc_try_nid_nopanic(size, SMP_CACHE_BYTES, min_addr, max_addr, nid) | - memblock_alloc_try_nid(size, 0, min_addr, max_addr, nid) + memblock_alloc_try_nid(size, SMP_CACHE_BYTES, min_addr, max_addr, nid) | - memblock_alloc(size, 0) + memblock_alloc(size, SMP_CACHE_BYTES) | - memblock_alloc_raw(size, 0) + memblock_alloc_raw(size, SMP_CACHE_BYTES) | - memblock_alloc_from(size, 0, min_addr) + memblock_alloc_from(size, SMP_CACHE_BYTES, min_addr) | - memblock_alloc_nopanic(size, 0) + memblock_alloc_nopanic(size, SMP_CACHE_BYTES) | - memblock_alloc_low(size, 0) + memblock_alloc_low(size, SMP_CACHE_BYTES) | - memblock_alloc_low_nopanic(size, 0) + memblock_alloc_low_nopanic(size, SMP_CACHE_BYTES) | - memblock_alloc_from_nopanic(size, 0, min_addr) + memblock_alloc_from_nopanic(size, SMP_CACHE_BYTES, min_addr) | - memblock_alloc_node(size, 0, nid) + memblock_alloc_node(size, SMP_CACHE_BYTES, nid) ) [mhocko@suse.com: changelog update] [akpm@linux-foundation.org: coding-style fixes] [rppt@linux.ibm.com: fix missed uses of implicit alignment] Link: http://lkml.kernel.org/r/20181016133656.GA10925@rapoport-lnx Link: http://lkml.kernel.org/r/1538687224-17535-1-git-send-email-rppt@linux.vnet.ibm.com Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com> Suggested-by: Michal Hocko <mhocko@suse.com> Acked-by: Paul Burton <paul.burton@mips.com> [MIPS] Acked-by: Michael Ellerman <mpe@ellerman.id.au> [powerpc] Acked-by: Michal Hocko <mhocko@suse.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Chris Zankel <chris@zankel.net> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Guan Xuetao <gxt@pku.edu.cn> Cc: Ingo Molnar <mingo@redhat.com> Cc: Matt Turner <mattst88@gmail.com> Cc: Michal Simek <monstr@monstr.eu> Cc: Richard Weinberger <richard@nod.at> Cc: Russell King <linux@armlinux.org.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Tony Luck <tony.luck@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
105 lines
2.1 KiB
C
105 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* linux/arch/alpha/kernel/pci-noop.c
|
|
*
|
|
* Stub PCI interfaces for Jensen-specific kernels.
|
|
*/
|
|
|
|
#include <linux/pci.h>
|
|
#include <linux/init.h>
|
|
#include <linux/memblock.h>
|
|
#include <linux/gfp.h>
|
|
#include <linux/capability.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/scatterlist.h>
|
|
#include <linux/syscalls.h>
|
|
|
|
#include "proto.h"
|
|
|
|
|
|
/*
|
|
* The PCI controller list.
|
|
*/
|
|
|
|
struct pci_controller *hose_head, **hose_tail = &hose_head;
|
|
struct pci_controller *pci_isa_hose;
|
|
|
|
|
|
struct pci_controller * __init
|
|
alloc_pci_controller(void)
|
|
{
|
|
struct pci_controller *hose;
|
|
|
|
hose = memblock_alloc(sizeof(*hose), SMP_CACHE_BYTES);
|
|
|
|
*hose_tail = hose;
|
|
hose_tail = &hose->next;
|
|
|
|
return hose;
|
|
}
|
|
|
|
struct resource * __init
|
|
alloc_resource(void)
|
|
{
|
|
return memblock_alloc(sizeof(struct resource), SMP_CACHE_BYTES);
|
|
}
|
|
|
|
SYSCALL_DEFINE3(pciconfig_iobase, long, which, unsigned long, bus,
|
|
unsigned long, dfn)
|
|
{
|
|
struct pci_controller *hose;
|
|
|
|
/* from hose or from bus.devfn */
|
|
if (which & IOBASE_FROM_HOSE) {
|
|
for (hose = hose_head; hose; hose = hose->next)
|
|
if (hose->index == bus)
|
|
break;
|
|
if (!hose)
|
|
return -ENODEV;
|
|
} else {
|
|
/* Special hook for ISA access. */
|
|
if (bus == 0 && dfn == 0)
|
|
hose = pci_isa_hose;
|
|
else
|
|
return -ENODEV;
|
|
}
|
|
|
|
switch (which & ~IOBASE_FROM_HOSE) {
|
|
case IOBASE_HOSE:
|
|
return hose->index;
|
|
case IOBASE_SPARSE_MEM:
|
|
return hose->sparse_mem_base;
|
|
case IOBASE_DENSE_MEM:
|
|
return hose->dense_mem_base;
|
|
case IOBASE_SPARSE_IO:
|
|
return hose->sparse_io_base;
|
|
case IOBASE_DENSE_IO:
|
|
return hose->dense_io_base;
|
|
case IOBASE_ROOT_BUS:
|
|
return hose->bus->number;
|
|
}
|
|
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
SYSCALL_DEFINE5(pciconfig_read, unsigned long, bus, unsigned long, dfn,
|
|
unsigned long, off, unsigned long, len, void __user *, buf)
|
|
{
|
|
if (!capable(CAP_SYS_ADMIN))
|
|
return -EPERM;
|
|
else
|
|
return -ENODEV;
|
|
}
|
|
|
|
SYSCALL_DEFINE5(pciconfig_write, unsigned long, bus, unsigned long, dfn,
|
|
unsigned long, off, unsigned long, len, void __user *, buf)
|
|
{
|
|
if (!capable(CAP_SYS_ADMIN))
|
|
return -EPERM;
|
|
else
|
|
return -ENODEV;
|
|
}
|