Brian Foster 79e641ce29 xfs: release bli from transaction properly on fs shutdown ... If a filesystem shutdown occurs with a buffer log item in the CIL and a log force occurs, the ->iop_unpin() handler is generally expected to tear down the bli properly. This entails freeing the bli memory and releasing the associated hold on the buffer so it can be released and the filesystem unmounted. If this sequence occurs while ->bli_refcount is elevated (i.e., another transaction is open and attempting to modify the buffer), however, ->iop_unpin() may not be responsible for releasing the bli. Instead, the transaction may release the final ->bli_refcount reference and thus xfs_trans_brelse() is responsible for tearing down the bli. While xfs_trans_brelse() does drop the reference count, it only attempts to release the bli if it is clean (i.e., not in the CIL/AIL). If the filesystem is shutdown and the bli is sitting dirty in the CIL as noted above, this ends up skipping the last opportunity to release the bli. In turn, this leaves the hold on the buffer and causes an unmount hang. This can be reproduced by running generic/388 in repetition. Update xfs_trans_brelse() to handle this shutdown corner case correctly. If the final bli reference is dropped and the filesystem is shutdown, remove the bli from the AIL (if necessary) and release the bli to drop the buffer hold and ensure an unmount does not hang. Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>		2017-06-19 08:59:10 -07:00
..
libxfs	xfs: remove XFS_HSIZE	2017-06-19 08:59:10 -07:00
Kconfig	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00
kmem.c	mm, vmalloc: use __GFP_HIGHMEM implicitly	2017-05-08 17:15:13 -07:00
kmem.h	mm: introduce memalloc_nofs_{save,restore} API	2017-05-03 15:52:09 -07:00
Makefile	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
mrlock.h
uuid.c
uuid.h
xfs_acl.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
xfs_acl.h
xfs_aops.c	Changes for 4.12:	2017-05-06 11:46:16 -07:00
xfs_aops.h	xfs: use iomap_dio_rw	2016-11-30 14:37:15 +11:00
xfs_attr_inactive.c	xfs: make several functions static	2016-06-01 17:38:15 +10:00
xfs_attr_list.c	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs_attr.h	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs_bmap_item.c	xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent	2017-06-19 08:59:10 -07:00
xfs_bmap_item.h	xfs: log bmap intent items	2016-10-04 11:05:44 -07:00
xfs_bmap_util.c	xfs: avoid harmless gcc-7 warnings	2017-06-19 08:59:10 -07:00
xfs_bmap_util.h	xfs: remove unused full argument from bmap	2017-01-30 16:32:25 -08:00
xfs_buf_item.c	xfs: reset b_first_retry_time when clear the retry status of xfs_buf_t	2017-02-03 14:39:07 -08:00
xfs_buf_item.h
xfs_buf.c	xfs: push buffer of flush locked dquot to avoid quotacheck deadlock	2017-06-19 08:59:10 -07:00
xfs_buf.h	xfs: push buffer of flush locked dquot to avoid quotacheck deadlock	2017-06-19 08:59:10 -07:00
xfs_dir2_readdir.c	xfs: refactor dir2 leaf readahead shadow buffer cleverness	2017-06-19 08:59:10 -07:00
xfs_discard.c	xfs: Allow user to kill fstrim process	2017-04-27 10:45:34 -07:00
xfs_discard.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_dquot_item.c	xfs: allocate log vector buffers outside CIL context lock	2016-07-22 09:52:35 +10:00
xfs_dquot_item.h
xfs_dquot.c	xfs: don't wrap ID in xfs_dq_get_next_id	2017-01-17 11:43:38 -08:00
xfs_dquot.h
xfs_error.c	Merge branch 'xfs-4.8-misc-fixes-3' into for-next	2016-07-20 11:51:08 +10:00
xfs_error.h	xfs: simulate per-AG reservations being critically low	2016-10-05 16:26:31 -07:00
xfs_export.c	xfs: abstract block export operations from nfsd layouts	2016-07-15 15:31:29 -04:00
xfs_export.h
xfs_extent_busy.c	xfs: fix len comparison in xfs_extent_busy_trim	2017-02-16 17:20:12 -08:00
xfs_extent_busy.h	xfs: improve handling of busy extents in the low-level allocator	2017-02-09 10:50:25 -08:00
xfs_extfree_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_extfree_item.h	xfs: refactor redo intent item processing	2016-08-03 11:23:49 +10:00
xfs_file.c	xfs: Move handling of missing page into one place in xfs_find_get_desired_pgoff()	2017-05-25 09:42:25 -07:00
xfs_filestream.c	Merge branch 'xfs-4.9-log-recovery-fixes' into for-next	2016-10-03 09:56:28 +11:00
xfs_filestream.h
xfs_fsmap.c	xfs: only return detailed fsmap info if the caller has CAP_SYS_ADMIN	2017-05-16 12:26:16 -07:00
xfs_fsmap.h	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_fsops.c	xfs: remove boilerplate around xfs_btree_init_block	2017-01-30 16:32:24 -08:00
xfs_fsops.h	xfs: preallocate blocks for worst-case btree expansion	2016-10-05 16:26:27 -07:00
xfs_globals.c	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00
xfs_icache.c	xfs: fix spurious spin_is_locked() assert failures on non-smp kernels	2017-06-08 08:23:07 -07:00
xfs_icache.h	xfs: update ag iterator to support wait on new inodes	2017-04-28 08:11:08 -07:00
xfs_icreate_item.c	fs: xfs: xfs_icreate_item: constify xfs_item_ops structure	2016-11-28 14:57:42 +11:00
xfs_icreate_item.h
xfs_inode_item.c	xfs: remove xfs_trans_ail_delete_bulk	2017-04-25 09:40:42 -07:00
xfs_inode_item.h	xfs: remove timestamps from incore inode	2016-02-09 16:54:58 +11:00
xfs_inode.c	xfs: drop iolock from reclaim context to appease lockdep	2017-04-12 08:43:23 -07:00
xfs_inode.h	xfs: support ability to wait on new inodes	2017-04-28 08:11:08 -07:00
xfs_ioctl32.c	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_ioctl32.h
xfs_ioctl.c	xfs: remove XFS_HSIZE	2017-06-19 08:59:10 -07:00
xfs_ioctl.h	xfs: don't pass ioflags around in the ioctl path	2016-07-20 11:29:35 +10:00
xfs_iomap.c	dax, xfs, ext4: compile out iomap-dax paths in the FS_DAX=n case	2017-05-13 17:52:16 -07:00
xfs_iomap.h	xfs: introduce xfs_aligned_fsb_count	2017-02-06 17:47:46 -08:00
xfs_iops.c	xfs: report crtime and attribute flags to statx	2017-04-03 01:05:59 -04:00
xfs_iops.h	xfs: Propagate dentry down to inode_change_ok()	2016-09-22 10:56:19 +02:00
xfs_itable.c	xfs: fix kernel memory exposure problems	2017-04-03 15:18:15 -07:00
xfs_itable.h
xfs_linux.h	xfs: remove custom do_div implementations	2017-04-12 08:42:51 -07:00
xfs_log_cil.c	xfs: remove lsn relevant fields from xfs_trans structure and its users	2017-06-19 08:59:10 -07:00
xfs_log_priv.h	xfs: dump transaction usage details on log reservation overrun	2017-06-19 08:59:10 -07:00
xfs_log_recover.c	scripts/spelling.txt: add "intialise(d)" pattern and fix typo instances	2017-05-08 17:15:13 -07:00
xfs_log.c	xfs: dump transaction usage details on log reservation overrun	2017-06-19 08:59:10 -07:00
xfs_log.h	xfs: remove unused struct declarations	2017-01-30 16:32:25 -08:00
xfs_message.c	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_message.h
xfs_mount.c	xfs: publish UUID in struct super_block	2017-04-28 08:10:53 -07:00
xfs_mount.h	xfs: more do_div cleanups	2017-04-25 09:40:41 -07:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_ondisk.h	xfs: define the on-disk refcount btree format	2016-10-03 09:11:18 -07:00
xfs_pnfs.c	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_pnfs.h	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_qm_bhv.c
xfs_qm_syscalls.c	xfs: wait on new inodes during quotaoff dquot release	2017-04-28 08:11:08 -07:00
xfs_qm.c	xfs: push buffer of flush locked dquot to avoid quotacheck deadlock	2017-06-19 08:59:10 -07:00
xfs_qm.h	xfs: Split default quota limits by quota type	2016-02-08 11:27:55 +11:00
xfs_quota.h
xfs_quotaops.c	xfs: wire up Q_XGETNEXTQUOTA / get_nextdqblk	2016-02-08 11:27:38 +11:00
xfs_refcount_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_refcount_item.h	xfs: log refcount intent items	2016-10-03 09:11:21 -07:00
xfs_reflink.c	xfs: reserve enough blocks to handle btree splits when remapping	2017-05-03 13:21:40 -07:00
xfs_reflink.h	xfs: only reclaim unwritten COW extents periodically	2017-03-07 16:45:58 -08:00
xfs_rmap_item.c	xfs: better log intent item refcount checking	2017-04-25 09:40:42 -07:00
xfs_rmap_item.h	xfs: convert RUI log formats to use variable length arrays	2016-09-19 10:24:27 +10:00
xfs_rtalloc.c	xfs: simplify xfs_rtallocate_extent	2017-02-17 16:52:52 -08:00
xfs_rtalloc.h	xfs: add a couple of queries to iterate free extents in the rtbitmap	2017-04-03 15:18:17 -07:00
xfs_stats.c	xfs: make xfs btree stats less huge	2016-12-05 14:38:58 +11:00
xfs_stats.h	xfs: make xfs btree stats less huge	2016-12-05 14:38:58 +11:00
xfs_super.c	Merge branch 'libnvdimm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm	2017-05-12 15:43:10 -07:00
xfs_super.h	xfs: don't block the log commit handler for discards	2017-02-09 11:36:40 -08:00
xfs_symlink.c	xfs: remove i_iolock and use i_rwsem in the VFS inode instead	2016-11-30 14:33:25 +11:00
xfs_symlink.h
xfs_sysctl.c	xfs: garbage collect old cowextsz reservations	2016-10-05 16:26:28 -07:00
xfs_sysctl.h	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_sysfs.c	xfs: define bug_on_assert debug mode sysfs tunable	2017-06-19 08:59:10 -07:00
xfs_sysfs.h	xfs: configurable error behavior via sysfs	2016-05-18 10:58:51 +10:00
xfs_trace.c	xfs: implement the GETFSMAP ioctl	2017-04-03 15:18:17 -07:00
xfs_trace.h	xfs: remove lsn relevant fields from xfs_trans structure and its users	2017-06-19 08:59:10 -07:00
xfs_trans_ail.c	xfs: remove xfs_trans_ail_delete_bulk	2017-04-25 09:40:42 -07:00
xfs_trans_bmap.c	xfs: try to avoid blowing out the transaction reservation when bunmaping a shared extent	2017-06-19 08:59:10 -07:00
xfs_trans_buf.c	xfs: release bli from transaction properly on fs shutdown	2017-06-19 08:59:10 -07:00
xfs_trans_dquot.c	xfs: Split default quota limits by quota type	2016-02-08 11:27:55 +11:00
xfs_trans_extfree.c	xfs: set up per-AG free space reservations	2016-09-19 10:30:52 +10:00
xfs_trans_inode.c	fs: Replace current_fs_time() with current_time()	2016-09-27 21:06:22 -04:00
xfs_trans_priv.h	xfs: remove xfs_trans_ail_delete_bulk	2017-04-25 09:40:42 -07:00
xfs_trans_refcount.c	xfs: connect refcount adjust functions to upper layers	2016-10-03 09:11:22 -07:00
xfs_trans_rmap.c	xfs: add shared rmap map/unmap/convert log item types	2016-10-05 16:26:29 -07:00
xfs_trans.c	Changes for 4.12:	2017-05-06 11:46:16 -07:00
xfs_trans.h	xfs: remove lsn relevant fields from xfs_trans structure and its users	2017-06-19 08:59:10 -07:00
xfs_xattr.c	xfs: several xattr functions can be void	2016-12-05 12:32:14 +11:00
xfs.h	xfs: define fatal assert build time tunable	2017-06-19 08:59:10 -07:00