mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-17 09:43:59 +08:00
74befa447e
When a driver for an interrupt controller is missing, of_irq_get()
returns -EPROBE_DEFER ad infinitum, causing
fwnode_mdiobus_phy_device_register(), and ultimately, the entire
of_mdiobus_register() call, to fail. In turn, any phy_connect() call
towards a PHY on this MDIO bus will also fail.
This is not what is expected to happen, because the PHY library falls
back to poll mode when of_irq_get() returns a hard error code, and the
MDIO bus, PHY and attached Ethernet controller work fine, albeit
suboptimally, when the PHY library polls for link status. However,
-EPROBE_DEFER has special handling given the assumption that at some
point probe deferral will stop, and the driver for the supplier will
kick in and create the IRQ domain.
Reasons for which the interrupt controller may be missing:
- It is not yet written. This may happen if a more recent DT blob (with
an interrupt-parent for the PHY) is used to boot an old kernel where
the driver didn't exist, and that kernel worked with the
vintage-correct DT blob using poll mode.
- It is compiled out. Behavior is the same as above.
- It is compiled as a module. The kernel will wait for a number of
seconds specified in the "deferred_probe_timeout" boot parameter for
user space to load the required module. The current default is 0,
which times out at the end of initcalls. It is possible that this
might cause regressions unless users adjust this boot parameter.
The proposed solution is to use the driver_deferred_probe_check_state()
helper function provided by the driver core, which gives up after some
-EPROBE_DEFER attempts, taking "deferred_probe_timeout" into consideration.
The return code is changed from -EPROBE_DEFER into -ENODEV or
-ETIMEDOUT, depending on whether the kernel is compiled with support for
modules or not.
Fixes:
|
||
|---|---|---|
| .. | ||
| acpi_mdio.c | ||
| fwnode_mdio.c | ||
| Kconfig | ||
| Makefile | ||
| mdio-aspeed.c | ||
| mdio-bcm-iproc.c | ||
| mdio-bcm-unimac.c | ||
| mdio-bitbang.c | ||
| mdio-cavium.c | ||
| mdio-cavium.h | ||
| mdio-gpio.c | ||
| mdio-hisi-femac.c | ||
| mdio-i2c.c | ||
| mdio-ipq4019.c | ||
| mdio-ipq8064.c | ||
| mdio-moxart.c | ||
| mdio-mscc-miim.c | ||
| mdio-mux-bcm6368.c | ||
| mdio-mux-bcm-iproc.c | ||
| mdio-mux-gpio.c | ||
| mdio-mux-meson-g12a.c | ||
| mdio-mux-mmioreg.c | ||
| mdio-mux-multiplexer.c | ||
| mdio-mux.c | ||
| mdio-mvusb.c | ||
| mdio-octeon.c | ||
| mdio-sun4i.c | ||
| mdio-thunder.c | ||
| mdio-xgene.c | ||
| of_mdio.c | ||