mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-21 11:44:01 +08:00
1e31aa9270
Avoid declaring ALIGN() and __aligned() in include/uapi/linux/mic_common.h since they pollute user space namespace. Also, mic_aligned_size() can be simply replaced simply by sizeof() since all structures where mic_aligned_size() is used are declared using __attribute__ ((aligned(8))); -- >From mail from H Peter Anvin about this: On Fri, Nov 08, 2013 H Peter Anvin <h.peter.anvin@intel.com> wrote: Subject: Namespace pollution in mic_common.h This puts two macros, ALIGN() and __aligned(), into arbitrary user space namespace. This really isn't safe or acceptable, especially since those symbols are highly generic. ... When these structures are forced-aligned, they will in fact have padding automatically added by the compiler to an 8-byte boundary anyway, so mic_aligned_size() does nothing. ... Reported-by: H Peter Anvin <h.peter.anvin@intel.com> Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
77 lines
2.2 KiB
C
77 lines
2.2 KiB
C
/*
|
|
* Intel MIC Platform Software Stack (MPSS)
|
|
*
|
|
* Copyright(c) 2013 Intel Corporation.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License, version 2, as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* The full GNU General Public License is included in this distribution in
|
|
* the file called "COPYING".
|
|
*
|
|
* Disclaimer: The codes contained in these modules may be specific to
|
|
* the Intel Software Development Platform codenamed: Knights Ferry, and
|
|
* the Intel product codenamed: Knights Corner, and are not backward
|
|
* compatible with other Intel products. Additionally, Intel will NOT
|
|
* support the codes or instruction set in future products.
|
|
*
|
|
* Intel MIC Card driver.
|
|
*
|
|
*/
|
|
#ifndef __MIC_CARD_VIRTIO_H
|
|
#define __MIC_CARD_VIRTIO_H
|
|
|
|
#include <linux/mic_common.h>
|
|
#include "mic_device.h"
|
|
|
|
/*
|
|
* 64 bit I/O access
|
|
*/
|
|
#ifndef ioread64
|
|
#define ioread64 readq
|
|
#endif
|
|
#ifndef iowrite64
|
|
#define iowrite64 writeq
|
|
#endif
|
|
|
|
static inline unsigned mic_desc_size(struct mic_device_desc __iomem *desc)
|
|
{
|
|
return sizeof(*desc)
|
|
+ ioread8(&desc->num_vq) * sizeof(struct mic_vqconfig)
|
|
+ ioread8(&desc->feature_len) * 2
|
|
+ ioread8(&desc->config_len);
|
|
}
|
|
|
|
static inline struct mic_vqconfig __iomem *
|
|
mic_vq_config(struct mic_device_desc __iomem *desc)
|
|
{
|
|
return (struct mic_vqconfig __iomem *)(desc + 1);
|
|
}
|
|
|
|
static inline __u8 __iomem *
|
|
mic_vq_features(struct mic_device_desc __iomem *desc)
|
|
{
|
|
return (__u8 __iomem *)(mic_vq_config(desc) + ioread8(&desc->num_vq));
|
|
}
|
|
|
|
static inline __u8 __iomem *
|
|
mic_vq_configspace(struct mic_device_desc __iomem *desc)
|
|
{
|
|
return mic_vq_features(desc) + ioread8(&desc->feature_len) * 2;
|
|
}
|
|
static inline unsigned mic_total_desc_size(struct mic_device_desc __iomem *desc)
|
|
{
|
|
return mic_aligned_desc_size(desc) + sizeof(struct mic_device_ctrl);
|
|
}
|
|
|
|
int mic_devices_init(struct mic_driver *mdrv);
|
|
void mic_devices_uninit(struct mic_driver *mdrv);
|
|
|
|
#endif
|