Darrick J. Wong 6ff646b2ce xfs: fix rmap key and record comparison functions ... Keys for extent interval records in the reverse mapping btree are supposed to be computed as follows: (physical block, owner, fork, is_btree, is_unwritten, offset) This provides users the ability to look up a reverse mapping from a bmbt record -- start with the physical block; then if there are multiple records for the same block, move on to the owner; then the inode fork type; and so on to the file offset. However, the key comparison functions incorrectly remove the fork/btree/unwritten information that's encoded in the on-disk offset. This means that lookup comparisons are only done with: (physical block, owner, offset) This means that queries can return incorrect results. On consistent filesystems this hasn't been an issue because blocks are never shared between forks or with bmbt blocks; and are never unwritten. However, this bug means that online repair cannot always detect corruption in the key information in internal rmapbt nodes. Found by fuzzing keys[1].attrfork = ones on xfs/371. Fixes: 4b8ed67794 ("xfs: add rmap btree operations") Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de>		2020-11-10 16:47:56 -08:00
..
libxfs	xfs: fix rmap key and record comparison functions	2020-11-10 16:47:56 -08:00
scrub	xfs: set the unwritten bit in rmap lookup flags in xchk_bmap_get_rmapextents	2020-11-10 16:47:51 -08:00
Kconfig	xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n	2020-10-16 15:34:28 -07:00
kmem.c	xfs: remove kmem_realloc()	2020-09-06 18:05:51 -07:00
kmem.h	xfs: Remove kmem_zalloc_large()	2020-09-15 20:52:41 -07:00
Makefile	xfs: refactor log recovery item sorting into a generic dispatch structure	2020-05-08 08:49:58 -07:00
mrlock.h
xfs_acl.c	xfs: Remove kmem_zalloc_large()	2020-09-15 20:52:41 -07:00
xfs_acl.h	xfs: improve xfs_forget_acl	2020-03-02 20:55:55 -08:00
xfs_aops.c	xfs: fix missing CoW blocks writeback conversion retry	2020-11-04 08:52:47 -08:00
xfs_aops.h	xfs: add a xfs_inode_buftarg helper	2019-10-28 08:37:54 -07:00
xfs_attr_inactive.c	xfs: cleanup xfs_idestroy_fork	2020-05-19 09:40:59 -07:00
xfs_attr_list.c	xfs: Convert xfs_attr_sf macros to inline functions	2020-09-15 20:52:42 -07:00
xfs_bio_io.c
xfs_bmap_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_bmap_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_bmap_util.c	xfs: fix fallocate functions when rtextsize is larger than 1	2020-10-21 09:05:19 -07:00
xfs_bmap_util.h	xfs: simplify xfs_iomap_eof_align_last_fsb	2019-11-03 10:22:30 -08:00
xfs_buf_item_recover.c	xfs: fix finobt btree block recovery ordering	2020-09-30 07:28:52 -07:00
xfs_buf_item.c	xfs: remove xlog_recover_iodone	2020-09-15 20:52:39 -07:00
xfs_buf_item.h	xfs: move the buffer retry logic to xfs_buf.c	2020-09-15 20:52:38 -07:00
xfs_buf.c	xfs: reuse _xfs_buf_read for re-reading the superblock	2020-09-15 20:52:39 -07:00
xfs_buf.h	xfs: reuse _xfs_buf_read for re-reading the superblock	2020-09-15 20:52:39 -07:00
xfs_dir2_readdir.c	xfs: move the fork format fields into struct xfs_ifork	2020-05-19 09:40:58 -07:00
xfs_discard.c	xfs: remove XFS_BUF_TO_AGF	2020-03-11 09:11:39 -07:00
xfs_discard.h
xfs_dquot_item_recover.c	xfs: rename the ondisk dquot d_flags to d_type	2020-07-28 20:24:14 -07:00
xfs_dquot_item.c	xfs: stop using q_core.d_id in the quota code	2020-07-28 20:24:14 -07:00
xfs_dquot_item.h	xfs: factor out quotaoff intent AIL removal and memory free	2020-03-18 08:12:23 -07:00
xfs_dquot.c	xfs: fix some comments	2020-09-25 11:34:07 -07:00
xfs_dquot.h	xfs: refactor default quota grace period setting code	2020-09-15 20:52:40 -07:00
xfs_error.c	xfs: random buffer write failure errortag	2020-05-07 08:27:48 -07:00
xfs_error.h	xfs: xfs_buf_corruption_error should take __this_address	2020-03-12 07:58:12 -07:00
xfs_export.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_export.h
xfs_extent_busy.c	xfs: cleanup use of the XFS_ALLOC_ flags	2019-11-03 10:22:31 -08:00
xfs_extent_busy.h
xfs_extfree_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_extfree_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_file.c	xfs: fix fallocate functions when rtextsize is larger than 1	2020-10-21 09:05:19 -07:00
xfs_filestream.c	xfs: drop the obsolete comment on filestream locking	2020-09-25 11:34:08 -07:00
xfs_filestream.h
xfs_fsmap.c	xfs: fix deadlock and streamline xfs_getfsmap performance	2020-10-07 08:40:29 -07:00
xfs_fsmap.h	xfs: fix deadlock and streamline xfs_getfsmap performance	2020-10-07 08:40:29 -07:00
xfs_fsops.c	xfs: remove unused shutdown types	2020-05-07 08:27:48 -07:00
xfs_fsops.h
xfs_globals.c
xfs_health.c
xfs_icache.c	xfs: Remove unneeded semicolon	2020-09-15 20:52:42 -07:00
xfs_icache.h	xfs: remove SYNC_WAIT and SYNC_TRYLOCK	2020-07-14 08:47:33 -07:00
xfs_icreate_item.c	xfs: Remove kmem_zone_zalloc() usage	2020-07-28 20:24:14 -07:00
xfs_icreate_item.h
xfs_inode_item_recover.c	xfs: widen ondisk inode timestamps to deal with y2038+	2020-09-15 20:52:41 -07:00
xfs_inode_item.c	xfs: widen ondisk inode timestamps to deal with y2038+	2020-09-15 20:52:41 -07:00
xfs_inode_item.h	xfs: move the buffer retry logic to xfs_buf.c	2020-09-15 20:52:38 -07:00
xfs_inode.c	xfs: drop extra transaction roll from inode extent truncate	2020-09-21 09:54:29 -07:00
xfs_inode.h	xfs: widen ondisk inode timestamps to deal with y2038+	2020-09-15 20:52:41 -07:00
xfs_ioctl32.c	xfs: lift cursor copy in/out into xfs_ioc_attr_list	2020-03-02 20:55:54 -08:00
xfs_ioctl32.h	xfs: rename compat_time_t to old_time32_t	2020-01-06 08:57:36 -08:00
xfs_ioctl.c	xfs: fix deadlock and streamline xfs_getfsmap performance	2020-10-07 08:40:29 -07:00
xfs_ioctl.h	xfs: embedded the attrlist cursor into struct xfs_attr_list_context	2020-03-02 20:55:55 -08:00
xfs_iomap.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_iomap.h	xfs: simplify the xfs_iomap_write_direct calling	2019-11-03 10:22:30 -08:00
xfs_iops.c	xfs: flush new eof page on truncate to avoid post-eof corruption	2020-11-04 08:52:46 -08:00
xfs_iops.h
xfs_itable.c	xfs: move the fork format fields into struct xfs_ifork	2020-05-19 09:40:58 -07:00
xfs_itable.h
xfs_iwalk.c	xfs: kill the XFS_WANT_CORRUPT_* macros	2019-11-12 17:19:02 -08:00
xfs_iwalk.h	xfs: remove all *_ITER_CONTINUE values	2019-08-30 22:43:56 -07:00
xfs_linux.h	xfs: fix fallocate functions when rtextsize is larger than 1	2020-10-21 09:05:19 -07:00
xfs_log_cil.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_log_priv.h	xfs: Modify xlog_ticket_alloc() to use kernel's MM API	2020-07-28 20:24:14 -07:00
xfs_log_recover.c	xfs: cancel intents immediately if process_intents fails	2020-10-21 16:28:46 -07:00
xfs_log.c	xfs: expose the log push threshold	2020-10-07 08:40:29 -07:00
xfs_log.h	xfs: expose the log push threshold	2020-10-07 08:40:29 -07:00
xfs_message.c	xfs: refactor ratelimited buffer error messages into helper	2020-05-07 08:27:46 -07:00
xfs_message.h	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
xfs_mount.c	xfs: remove xfs_getsb	2020-09-15 20:52:39 -07:00
xfs_mount.h	xfs: remove xfs_getsb	2020-09-15 20:52:39 -07:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_ondisk.h	xfs: Remove typedef xfs_attr_shortform_t	2020-09-15 20:52:42 -07:00
xfs_pnfs.c	xfs: define printk_once variants for xfs messages	2020-05-04 09:03:15 -07:00
xfs_pnfs.h
xfs_pwork.c	block: remove the bd_queue field from struct block_device	2020-07-01 08:08:20 -06:00
xfs_pwork.h
xfs_qm_bhv.c	xfs: rename XFS_DQ_{USER,GROUP,PROJ} to XFS_DQTYPE_*	2020-07-28 20:24:14 -07:00
xfs_qm_syscalls.c	xfs: refactor default quota grace period setting code	2020-09-15 20:52:40 -07:00
xfs_qm.c	xfs: do the ASSERT for the arguments O_{u,g,p}dqpp	2020-10-07 08:40:29 -07:00
xfs_qm.h	xfs: refactor quota expiration timer modification	2020-09-15 20:52:40 -07:00
xfs_quota.h	xfs: move the buffer retry logic to xfs_buf.c	2020-09-15 20:52:38 -07:00
xfs_quotaops.c	xfs: create xfs_dqtype_t to represent quota types	2020-07-28 20:24:14 -07:00
xfs_refcount_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_refcount_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_reflink.c	xfs: only flush the unshared range in xfs_reflink_unshare	2020-11-04 17:41:56 -08:00
xfs_reflink.h	xfs: move helpers that lock and unlock two inodes against userspace IO	2020-07-06 10:46:57 -07:00
xfs_rmap_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_rmap_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_rtalloc.c	xfs: annotate grabbing the realtime bitmap/summary locks in growfs	2020-10-13 08:41:31 -07:00
xfs_rtalloc.h
xfs_stats.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_stats.h	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_super.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
xfs_super.h	xfs: include QUOTA, FATAL ASSERT build options in XFS_BUILD_OPTIONS	2019-10-21 09:04:57 -07:00
xfs_symlink.c	xfs: move the fork format fields into struct xfs_ifork	2020-05-19 09:40:58 -07:00
xfs_symlink.h	xfs: Correct comment tyops -> typos	2019-11-10 10:21:57 -08:00
xfs_sysctl.c	xfs: remove deprecated sysctl options	2020-09-25 11:34:08 -07:00
xfs_sysctl.h
xfs_sysfs.c	xfs: avoid unused to_mp() function warning	2019-09-24 09:40:19 -07:00
xfs_sysfs.h	xfs: Fix UBSAN null-ptr-deref in xfs_sysfs_init	2020-08-07 11:50:17 -07:00
xfs_trace.c	xfs: support bulk loading of staged btrees	2020-03-18 08:12:23 -07:00
xfs_trace.h	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_trans_ail.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_trans_buf.c	xfs: simplify xfs_trans_getsb	2020-09-15 20:52:39 -07:00
xfs_trans_dquot.c	xfs: fix the indent in xfs_trans_mod_dquot	2020-10-07 08:40:29 -07:00
xfs_trans_priv.h	xfs: refactor adding recovered intent items to the log	2020-05-08 08:50:00 -07:00
xfs_trans.c	xfs: do the assert for all the log done items in xfs_trans_cancel	2020-09-25 11:34:07 -07:00
xfs_trans.h	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_xattr.c	xfs: remove duplicate headers	2020-05-08 08:51:34 -07:00
xfs.h