Sabrina Dubroca 6db959c82e tls: reset crypto_info when do_tls_setsockopt_tx fails ... The current code copies directly from userspace to ctx->crypto_send, but doesn't always reinitialize it to 0 on failure. This causes any subsequent attempt to use this setsockopt to fail because of the TLS_CRYPTO_INFO_READY check, eventhough crypto_info is not actually ready. This should result in a correctly set up socket after the 3rd call, but currently it does not: size_t s = sizeof(struct tls12_crypto_info_aes_gcm_128); struct tls12_crypto_info_aes_gcm_128 crypto_good = { .info.version = TLS_1_2_VERSION, .info.cipher_type = TLS_CIPHER_AES_GCM_128, }; struct tls12_crypto_info_aes_gcm_128 crypto_bad_type = crypto_good; crypto_bad_type.info.cipher_type = 42; setsockopt(sock, SOL_TLS, TLS_TX, &crypto_bad_type, s); setsockopt(sock, SOL_TLS, TLS_TX, &crypto_good, s - 1); setsockopt(sock, SOL_TLS, TLS_TX, &crypto_good, s); Fixes: 3c4d755915 ("tls: kernel TLS support") Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-01-17 16:16:04 -05:00
..
Kconfig	tls: update Kconfig	2017-06-17 22:56:46 -04:00
Makefile	tls: kernel TLS support	2017-06-15 12:12:40 -04:00
tls_main.c	tls: reset crypto_info when do_tls_setsockopt_tx fails	2018-01-17 16:16:04 -05:00
tls_sw.c	tls: fix sw_ctx leak	2018-01-17 16:16:03 -05:00