mirror of
https://github.com/edk2-porting/linux-next.git
synced 2025-01-10 22:54:11 +08:00
163cd1059a
To provide backward compatibility to older systems, the SOF HDA driver
allows user to specify which HDMI codec driver to use at runtime via
kernel parameter. This mechanism has a subtle flaw in that it assumes
the codec drivers not to be loaded when the SOF PCI driver is loaded.
The problem is rooted in use of the hdev->type field.
snd_hdac_ext_bus_device_init() initializes this field to HDA_DEV_ASOC.
This signals the HDA core that ASoC drivers should be considered in
driver matching (hda_bus_match()). The SOF and SST drivers continue by
overriding this field to HDA_DEV_LEGACY and proceeding to load driver
modules with request_module(). Correct drivers will get loaded and
attached.
If however the codec drivers are already loaded when
snd_hdac_ext_bus_device_init() is called, the matching will not work as
expected as device type is still set to HDA_DEV_ASOC. Specifically if
hdac-hdmi is attached when machine driver is configured to use hdac-hda,
this leads to out-of-bounds memory access in
hda_dsp_hdmi_build_controls().
Fix the issue by adding codec type as a parameter to
snd_hdac_ext_bus_device_init() and ensuring type is set correctly from
the start.
Fixes:
|
||
|---|---|---|
| .. | ||
| bxt-sst.c | ||
| cnl-sst-dsp.c | ||
| cnl-sst-dsp.h | ||
| cnl-sst.c | ||
| Makefile | ||
| skl-debug.c | ||
| skl-i2s.h | ||
| skl-messages.c | ||
| skl-nhlt.c | ||
| skl-pcm.c | ||
| skl-ssp-clk.c | ||
| skl-ssp-clk.h | ||
| skl-sst-cldma.c | ||
| skl-sst-cldma.h | ||
| skl-sst-dsp.c | ||
| skl-sst-dsp.h | ||
| skl-sst-ipc.c | ||
| skl-sst-ipc.h | ||
| skl-sst-utils.c | ||
| skl-sst.c | ||
| skl-topology.c | ||
| skl-topology.h | ||
| skl.c | ||
| skl.h | ||