2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-23 20:53:53 +08:00
linux-next/drivers/media/video/uvc
Julia Lawall d2be76437c V4L/DVB (13012): uvc: introduce missing kfree
Move the kzalloc and associated test after the stream/query test, to avoid
the need to free the allocated if the stream/query test fails.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-09-19 00:52:54 -03:00
..
Kconfig V4L/DVB (11439): UVC: uvc_status_cleanup(): undefined reference to `input_unregister_device' 2009-04-06 21:44:52 -03:00
Makefile V4L/DVB (8178): uvc: Fix compilation breakage for the other drivers, if uvc is selected 2008-07-02 08:58:15 -03:00
uvc_ctrl.c V4L/DVB (12379): uvcvideo: Multiple streaming interfaces support 2009-09-12 12:18:33 -03:00
uvc_driver.c V4L/DVB (12379): uvcvideo: Multiple streaming interfaces support 2009-09-12 12:18:33 -03:00
uvc_isight.c V4L/DVB (12378): uvcvideo: Restructure the driver to support multiple simultaneous streams. 2009-09-12 12:18:32 -03:00
uvc_queue.c V4L/DVB (11945): uvcvideo: Don't accept to change the format when buffers are allocated. 2009-06-16 19:07:30 -03:00
uvc_status.c V4L/DVB (12380): uvcvideo: Avoid flooding the kernel log with "unknown event type" messages 2009-08-13 20:39:05 -03:00
uvc_v4l2.c V4L/DVB (12379): uvcvideo: Multiple streaming interfaces support 2009-09-12 12:18:33 -03:00
uvc_video.c V4L/DVB (13012): uvc: introduce missing kfree 2009-09-19 00:52:54 -03:00
uvcvideo.h V4L/DVB (12379): uvcvideo: Multiple streaming interfaces support 2009-09-12 12:18:33 -03:00