2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-27 14:43:58 +08:00
linux-next/net/nfc/nci
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
core.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
data.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hci.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
Kconfig NFC: NCI: move generic spi driver to a module 2015-10-27 04:21:38 +01:00
lib.c nfc: Fix FSF address in file headers 2013-12-11 10:56:21 -05:00
Makefile NFC: NCI: move generic spi driver to a module 2015-10-27 04:21:38 +01:00
ntf.c nfc: nci: Add an additional parameter to identify a connection id 2016-05-04 01:43:21 +02:00
rsp.c nfc: nci: Add an additional parameter to identify a connection id 2016-05-04 01:43:21 +02:00
spi.c NFC: NCI: allow spi driver to choose transfer clock 2015-10-27 04:23:34 +01:00
uart.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00