2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-19 10:44:14 +08:00
linux-next/drivers/usb
Alan Stern 524134d422 USB: don't cancel queued resets when unbinding drivers
The USB stack provides a mechanism for drivers to request an
asynchronous device reset (usb_queue_reset_device()).  The mechanism
uses a work item (reset_ws) embedded in the usb_interface structure
used by the driver, and the reset is carried out by a work queue
routine.

The asynchronous reset can race with driver unbinding.  When this
happens, we try to cancel the queued reset before unbinding the
driver, on the theory that the driver won't care about any resets once
it is unbound.

However, thanks to the fact that lockdep now tracks work queue
accesses, this can provoke a lockdep warning in situations where the
device reset causes another interface's driver to be unbound; see

	http://marc.info/?l=linux-usb&m=141893165203776&w=2

for an example.  The reason is that the work routine for reset_ws in
one interface calls cancel_queued_work() for the reset_ws in another
interface.  Lockdep thinks this might lead to a work routine trying to
cancel itself.  The simplest solution is not to cancel queued resets
when unbinding drivers.

This means we now need to acquire a reference to the usb_interface
when queuing a reset_ws work item and to drop the reference when the
work routine finishes.  We also need to make sure that the
usb_interface structure doesn't outlive its parent usb_device; this
means acquiring and dropping a reference when the interface is created
and destroyed.

In addition, cancelling a queued reset can fail (if the device is in
the middle of an earlier reset), and this can cause usb_reset_device()
to try to rebind an interface that has been deallocated (see
http://marc.info/?l=linux-usb&m=142175717016628&w=2 for details).
Acquiring the extra references prevents this failure.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Russell King - ARM Linux <linux@arm.linux.org.uk>
Reported-by: Olivier Sobrie <olivier@sobrie.be>
Tested-by: Olivier Sobrie <olivier@sobrie.be>
Cc: stable <stable@vger.kernel.org> # 3.19
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25 20:54:17 +08:00
..
atm
c67x00 usb: c67x00: drop owner assignment from platform_drivers 2014-10-20 16:21:46 +02:00
chipidea Revert "usb: chipidea: remove duplicate dev_set_drvdata for host_start" 2015-01-09 09:45:30 -08:00
class USB: cdc-acm: check for valid interfaces 2014-11-24 17:21:42 -08:00
common usb: move the OTG state from the USB PHY to the OTG structure 2014-11-03 10:01:25 -06:00
core USB: don't cancel queued resets when unbinding drivers 2015-01-25 20:54:17 +08:00
dwc2 usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop() 2014-12-22 10:28:55 -06:00
dwc3 usb: dwc3: gadget: Stop TRB preparation after limit is reached 2015-01-14 11:29:05 -06:00
early
gadget Merge 3.19-rc5 into usb-next 2015-01-19 07:06:01 +08:00
host USB: host: Introduce flag to enable use of 64-bit dma_mask for ehci-platform 2015-01-25 20:48:28 +08:00
image USB: use %*ph specifier in mikrotek driver 2015-01-09 11:37:18 -08:00
misc USB: use %*ph specifier in uss720 driver 2015-01-09 11:37:18 -08:00
mon
musb usb: musb: stuff leak of struct usb_hcd 2014-12-22 10:36:24 -06:00
phy usb: fixes for v3.19-rc6 2015-01-14 16:27:23 -08:00
renesas_usbhs usb: renesas_usbhs: expand USB-DMAC channels for R-Car Gen2 2014-11-12 09:11:31 -06:00
serial usb: serial: handle -ENODEV quietly in generic_submit_read_urb 2015-01-12 10:23:54 +01:00
storage uas: Add US_FL_NO_ATA_1X for 2 more Seagate disk enclosures 2015-01-09 10:02:52 -08:00
usbip Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
wusbcore wusb: replace memset by memzero_explicit 2014-12-02 16:15:02 -08:00
Kconfig usb: Add LED triggers for USB activity 2014-09-25 17:05:12 +02:00
Makefile usbip: move usbip kernel code out of staging 2014-08-25 10:40:06 -07:00
README usb: hub: rename khubd to hub_wq in documentation and comments 2014-09-23 22:33:19 -07:00
usb-skeleton.c

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.