mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-26 22:24:09 +08:00
272725c7db
Replace uses of fb->bits_per_pixel with fb->format->cpp[0]*8. Less duplicated information is a good thing. Note that I didn't put parens around the cpp*8 in the below cocci script, on account of not wanting spurious parens all over the place. Instead I did the unsafe way, and tried to look over the entire diff to spot if any dangerous expressions were produced. I didn't see any. There are some cases where previously the code did X*bpp/8, so the division happened after the multiplication. Those are now just X*cpp so the division effectively happens before the multiplication, but that is perfectly fine since bpp is always a multiple of 8. @@ struct drm_framebuffer *FB; expression E; @@ drm_helper_mode_fill_fb_struct(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ i9xx_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ ironlake_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer *FB; expression E; @@ skylake_get_initial_plane_config(...) { ... - FB->bits_per_pixel = E; ... } @@ struct drm_framebuffer FB; expression E; @@ ( - E * FB.bits_per_pixel / 8 + E * FB.format->cpp[0] | - FB.bits_per_pixel / 8 + FB.format->cpp[0] | - E * FB.bits_per_pixel >> 3 + E * FB.format->cpp[0] | - FB.bits_per_pixel >> 3 + FB.format->cpp[0] | - (FB.bits_per_pixel + 7) / 8 + FB.format->cpp[0] | - FB.bits_per_pixel + FB.format->cpp[0] * 8 | - FB.format->cpp[0] * 8 != 8 + FB.format->cpp[0] != 1 ) @@ struct drm_framebuffer *FB; expression E; @@ ( - E * FB->bits_per_pixel / 8 + E * FB->format->cpp[0] | - FB->bits_per_pixel / 8 + FB->format->cpp[0] | - E * FB->bits_per_pixel >> 3 + E * FB->format->cpp[0] | - FB->bits_per_pixel >> 3 + FB->format->cpp[0] | - (FB->bits_per_pixel + 7) / 8 + FB->format->cpp[0] | - FB->bits_per_pixel + FB->format->cpp[0] * 8 | - FB->format->cpp[0] * 8 != 8 + FB->format->cpp[0] != 1 ) @@ struct drm_plane_state *state; expression E; @@ ( - E * state->fb->bits_per_pixel / 8 + E * state->fb->format->cpp[0] | - state->fb->bits_per_pixel / 8 + state->fb->format->cpp[0] | - E * state->fb->bits_per_pixel >> 3 + E * state->fb->format->cpp[0] | - state->fb->bits_per_pixel >> 3 + state->fb->format->cpp[0] | - (state->fb->bits_per_pixel + 7) / 8 + state->fb->format->cpp[0] | - state->fb->bits_per_pixel + state->fb->format->cpp[0] * 8 | - state->fb->format->cpp[0] * 8 != 8 + state->fb->format->cpp[0] != 1 ) @@ @@ - (8 * 8) + 8 * 8 @@ struct drm_framebuffer FB; @@ - (FB.format->cpp[0]) + FB.format->cpp[0] @@ struct drm_framebuffer *FB; @@ - (FB->format->cpp[0]) + FB->format->cpp[0] @@ @@ struct drm_framebuffer { ... - int bits_per_pixel; ... }; v2: Clean up the 'cpp*8 != 8' and '(8 * 8)' cases (Laurent) v3: Adjusted the semantic patch a bit and regenerated due to code changes Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1) Link: http://patchwork.freedesktop.org/patch/msgid/1481751140-18352-1-git-send-email-ville.syrjala@linux.intel.com
320 lines
8.1 KiB
C
320 lines
8.1 KiB
C
/* exynos_drm_fbdev.c
|
|
*
|
|
* Copyright (c) 2011 Samsung Electronics Co., Ltd.
|
|
* Authors:
|
|
* Inki Dae <inki.dae@samsung.com>
|
|
* Joonyoung Shim <jy0922.shim@samsung.com>
|
|
* Seung-Woo Kim <sw0312.kim@samsung.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_crtc.h>
|
|
#include <drm/drm_fb_helper.h>
|
|
#include <drm/drm_crtc_helper.h>
|
|
#include <drm/exynos_drm.h>
|
|
|
|
#include "exynos_drm_drv.h"
|
|
#include "exynos_drm_fb.h"
|
|
#include "exynos_drm_fbdev.h"
|
|
#include "exynos_drm_iommu.h"
|
|
|
|
#define MAX_CONNECTOR 4
|
|
#define PREFERRED_BPP 32
|
|
|
|
#define to_exynos_fbdev(x) container_of(x, struct exynos_drm_fbdev,\
|
|
drm_fb_helper)
|
|
|
|
struct exynos_drm_fbdev {
|
|
struct drm_fb_helper drm_fb_helper;
|
|
struct exynos_drm_gem *exynos_gem;
|
|
};
|
|
|
|
static int exynos_drm_fb_mmap(struct fb_info *info,
|
|
struct vm_area_struct *vma)
|
|
{
|
|
struct drm_fb_helper *helper = info->par;
|
|
struct exynos_drm_fbdev *exynos_fbd = to_exynos_fbdev(helper);
|
|
struct exynos_drm_gem *exynos_gem = exynos_fbd->exynos_gem;
|
|
unsigned long vm_size;
|
|
int ret;
|
|
|
|
vma->vm_flags |= VM_IO | VM_DONTEXPAND | VM_DONTDUMP;
|
|
|
|
vm_size = vma->vm_end - vma->vm_start;
|
|
|
|
if (vm_size > exynos_gem->size)
|
|
return -EINVAL;
|
|
|
|
ret = dma_mmap_attrs(to_dma_dev(helper->dev), vma, exynos_gem->cookie,
|
|
exynos_gem->dma_addr, exynos_gem->size,
|
|
exynos_gem->dma_attrs);
|
|
if (ret < 0) {
|
|
DRM_ERROR("failed to mmap.\n");
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct fb_ops exynos_drm_fb_ops = {
|
|
.owner = THIS_MODULE,
|
|
DRM_FB_HELPER_DEFAULT_OPS,
|
|
.fb_mmap = exynos_drm_fb_mmap,
|
|
.fb_fillrect = drm_fb_helper_cfb_fillrect,
|
|
.fb_copyarea = drm_fb_helper_cfb_copyarea,
|
|
.fb_imageblit = drm_fb_helper_cfb_imageblit,
|
|
};
|
|
|
|
static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
|
|
struct drm_fb_helper_surface_size *sizes,
|
|
struct exynos_drm_gem *exynos_gem)
|
|
{
|
|
struct fb_info *fbi;
|
|
struct drm_framebuffer *fb = helper->fb;
|
|
unsigned int size = fb->width * fb->height * fb->format->cpp[0];
|
|
unsigned int nr_pages;
|
|
unsigned long offset;
|
|
|
|
fbi = drm_fb_helper_alloc_fbi(helper);
|
|
if (IS_ERR(fbi)) {
|
|
DRM_ERROR("failed to allocate fb info.\n");
|
|
return PTR_ERR(fbi);
|
|
}
|
|
|
|
fbi->par = helper;
|
|
fbi->flags = FBINFO_FLAG_DEFAULT;
|
|
fbi->fbops = &exynos_drm_fb_ops;
|
|
|
|
drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth);
|
|
drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height);
|
|
|
|
nr_pages = exynos_gem->size >> PAGE_SHIFT;
|
|
|
|
exynos_gem->kvaddr = (void __iomem *) vmap(exynos_gem->pages, nr_pages,
|
|
VM_MAP, pgprot_writecombine(PAGE_KERNEL));
|
|
if (!exynos_gem->kvaddr) {
|
|
DRM_ERROR("failed to map pages to kernel space.\n");
|
|
drm_fb_helper_release_fbi(helper);
|
|
return -EIO;
|
|
}
|
|
|
|
offset = fbi->var.xoffset * fb->format->cpp[0];
|
|
offset += fbi->var.yoffset * fb->pitches[0];
|
|
|
|
fbi->screen_base = exynos_gem->kvaddr + offset;
|
|
fbi->screen_size = size;
|
|
fbi->fix.smem_len = size;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int exynos_drm_fbdev_create(struct drm_fb_helper *helper,
|
|
struct drm_fb_helper_surface_size *sizes)
|
|
{
|
|
struct exynos_drm_fbdev *exynos_fbdev = to_exynos_fbdev(helper);
|
|
struct exynos_drm_gem *exynos_gem;
|
|
struct drm_device *dev = helper->dev;
|
|
struct drm_mode_fb_cmd2 mode_cmd = { 0 };
|
|
struct platform_device *pdev = dev->platformdev;
|
|
unsigned long size;
|
|
int ret;
|
|
|
|
DRM_DEBUG_KMS("surface width(%d), height(%d) and bpp(%d\n",
|
|
sizes->surface_width, sizes->surface_height,
|
|
sizes->surface_bpp);
|
|
|
|
mode_cmd.width = sizes->surface_width;
|
|
mode_cmd.height = sizes->surface_height;
|
|
mode_cmd.pitches[0] = sizes->surface_width * (sizes->surface_bpp >> 3);
|
|
mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
|
|
sizes->surface_depth);
|
|
|
|
size = mode_cmd.pitches[0] * mode_cmd.height;
|
|
|
|
exynos_gem = exynos_drm_gem_create(dev, EXYNOS_BO_CONTIG, size);
|
|
/*
|
|
* If physically contiguous memory allocation fails and if IOMMU is
|
|
* supported then try to get buffer from non physically contiguous
|
|
* memory area.
|
|
*/
|
|
if (IS_ERR(exynos_gem) && is_drm_iommu_supported(dev)) {
|
|
dev_warn(&pdev->dev, "contiguous FB allocation failed, falling back to non-contiguous\n");
|
|
exynos_gem = exynos_drm_gem_create(dev, EXYNOS_BO_NONCONTIG,
|
|
size);
|
|
}
|
|
|
|
if (IS_ERR(exynos_gem))
|
|
return PTR_ERR(exynos_gem);
|
|
|
|
exynos_fbdev->exynos_gem = exynos_gem;
|
|
|
|
helper->fb =
|
|
exynos_drm_framebuffer_init(dev, &mode_cmd, &exynos_gem, 1);
|
|
if (IS_ERR(helper->fb)) {
|
|
DRM_ERROR("failed to create drm framebuffer.\n");
|
|
ret = PTR_ERR(helper->fb);
|
|
goto err_destroy_gem;
|
|
}
|
|
|
|
ret = exynos_drm_fbdev_update(helper, sizes, exynos_gem);
|
|
if (ret < 0)
|
|
goto err_destroy_framebuffer;
|
|
|
|
return ret;
|
|
|
|
err_destroy_framebuffer:
|
|
drm_framebuffer_cleanup(helper->fb);
|
|
err_destroy_gem:
|
|
exynos_drm_gem_destroy(exynos_gem);
|
|
|
|
/*
|
|
* if failed, all resources allocated above would be released by
|
|
* drm_mode_config_cleanup() when drm_load() had been called prior
|
|
* to any specific driver such as fimd or hdmi driver.
|
|
*/
|
|
|
|
return ret;
|
|
}
|
|
|
|
static const struct drm_fb_helper_funcs exynos_drm_fb_helper_funcs = {
|
|
.fb_probe = exynos_drm_fbdev_create,
|
|
};
|
|
|
|
static bool exynos_drm_fbdev_is_anything_connected(struct drm_device *dev)
|
|
{
|
|
struct drm_connector *connector;
|
|
bool ret = false;
|
|
|
|
mutex_lock(&dev->mode_config.mutex);
|
|
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
|
|
if (connector->status != connector_status_connected)
|
|
continue;
|
|
|
|
ret = true;
|
|
break;
|
|
}
|
|
mutex_unlock(&dev->mode_config.mutex);
|
|
|
|
return ret;
|
|
}
|
|
|
|
int exynos_drm_fbdev_init(struct drm_device *dev)
|
|
{
|
|
struct exynos_drm_fbdev *fbdev;
|
|
struct exynos_drm_private *private = dev->dev_private;
|
|
struct drm_fb_helper *helper;
|
|
unsigned int num_crtc;
|
|
int ret;
|
|
|
|
if (!dev->mode_config.num_crtc || !dev->mode_config.num_connector)
|
|
return 0;
|
|
|
|
if (!exynos_drm_fbdev_is_anything_connected(dev))
|
|
return 0;
|
|
|
|
fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
|
|
if (!fbdev)
|
|
return -ENOMEM;
|
|
|
|
private->fb_helper = helper = &fbdev->drm_fb_helper;
|
|
|
|
drm_fb_helper_prepare(dev, helper, &exynos_drm_fb_helper_funcs);
|
|
|
|
num_crtc = dev->mode_config.num_crtc;
|
|
|
|
ret = drm_fb_helper_init(dev, helper, num_crtc, MAX_CONNECTOR);
|
|
if (ret < 0) {
|
|
DRM_ERROR("failed to initialize drm fb helper.\n");
|
|
goto err_init;
|
|
}
|
|
|
|
ret = drm_fb_helper_single_add_all_connectors(helper);
|
|
if (ret < 0) {
|
|
DRM_ERROR("failed to register drm_fb_helper_connector.\n");
|
|
goto err_setup;
|
|
|
|
}
|
|
|
|
ret = drm_fb_helper_initial_config(helper, PREFERRED_BPP);
|
|
if (ret < 0) {
|
|
DRM_ERROR("failed to set up hw configuration.\n");
|
|
goto err_setup;
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_setup:
|
|
drm_fb_helper_fini(helper);
|
|
|
|
err_init:
|
|
private->fb_helper = NULL;
|
|
kfree(fbdev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void exynos_drm_fbdev_destroy(struct drm_device *dev,
|
|
struct drm_fb_helper *fb_helper)
|
|
{
|
|
struct exynos_drm_fbdev *exynos_fbd = to_exynos_fbdev(fb_helper);
|
|
struct exynos_drm_gem *exynos_gem = exynos_fbd->exynos_gem;
|
|
struct drm_framebuffer *fb;
|
|
|
|
vunmap(exynos_gem->kvaddr);
|
|
|
|
/* release drm framebuffer and real buffer */
|
|
if (fb_helper->fb && fb_helper->fb->funcs) {
|
|
fb = fb_helper->fb;
|
|
if (fb) {
|
|
drm_framebuffer_unregister_private(fb);
|
|
drm_framebuffer_remove(fb);
|
|
}
|
|
}
|
|
|
|
drm_fb_helper_unregister_fbi(fb_helper);
|
|
drm_fb_helper_release_fbi(fb_helper);
|
|
|
|
drm_fb_helper_fini(fb_helper);
|
|
}
|
|
|
|
void exynos_drm_fbdev_fini(struct drm_device *dev)
|
|
{
|
|
struct exynos_drm_private *private = dev->dev_private;
|
|
struct exynos_drm_fbdev *fbdev;
|
|
|
|
if (!private || !private->fb_helper)
|
|
return;
|
|
|
|
fbdev = to_exynos_fbdev(private->fb_helper);
|
|
|
|
exynos_drm_fbdev_destroy(dev, private->fb_helper);
|
|
kfree(fbdev);
|
|
private->fb_helper = NULL;
|
|
}
|
|
|
|
void exynos_drm_fbdev_restore_mode(struct drm_device *dev)
|
|
{
|
|
struct exynos_drm_private *private = dev->dev_private;
|
|
|
|
if (!private || !private->fb_helper)
|
|
return;
|
|
|
|
drm_fb_helper_restore_fbdev_mode_unlocked(private->fb_helper);
|
|
}
|
|
|
|
void exynos_drm_output_poll_changed(struct drm_device *dev)
|
|
{
|
|
struct exynos_drm_private *private = dev->dev_private;
|
|
struct drm_fb_helper *fb_helper = private->fb_helper;
|
|
|
|
if (fb_helper)
|
|
drm_fb_helper_hotplug_event(fb_helper);
|
|
else
|
|
exynos_drm_fbdev_init(dev);
|
|
}
|