mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-25 13:43:55 +08:00
84cb8eb26c
Recent refactoring of add_metainfo() caused use_all_metadata() to add
metainfo to ife action metalist without taking reference to module. This
causes warning in module_put called from ife action cleanup function.
Implement add_metainfo_and_get_ops() function that returns with reference
to module taken if metainfo was added successfully, and call it from
use_all_metadata(), instead of calling __add_metainfo() directly.
Example warning:
[ 646.344393] WARNING: CPU: 1 PID: 2278 at kernel/module.c:1139 module_put+0x1cb/0x230
[ 646.352437] Modules linked in: act_meta_skbtcindex act_meta_mark act_meta_skbprio act_ife ife veth nfsv3 nfs fscache xt_CHECKSUM iptable_mangle ipt_MASQUERADE iptable_nat nf_nat_ipv4 nf_nat xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 libcrc32c tun ebtable_filter ebtables ip6table_filter ip6_tables bridge stp llc mlx5_ib ib_uverbs ib_core intel_rapl sb_edac x86_pkg_temp_thermal mlx5_core coretemp kvm_intel kvm nfsd igb irqbypass crct10dif_pclmul devlink crc32_pclmul mei_me joydev ses crc32c_intel enclosure auth_rpcgss i2c_algo_bit ioatdma ptp mei pps_core ghash_clmulni_intel iTCO_wdt iTCO_vendor_support pcspkr dca ipmi_ssif lpc_ich target_core_mod i2c_i801 ipmi_si ipmi_devintf pcc_cpufreq wmi ipmi_msghandler nfs_acl lockd acpi_pad acpi_power_meter grace sunrpc mpt3sas raid_class scsi_transport_sas
[ 646.425631] CPU: 1 PID: 2278 Comm: tc Not tainted 4.19.0-rc1+ #799
[ 646.432187] Hardware name: Supermicro SYS-2028TP-DECR/X10DRT-P, BIOS 2.0b 03/30/2017
[ 646.440595] RIP: 0010:module_put+0x1cb/0x230
[ 646.445238] Code: f3 66 94 02 e8 26 ff fa ff 85 c0 74 11 0f b6 1d 51 30 94 02 80 fb 01 77 60 83 e3 01 74 13 65 ff 0d 3a 83 db 73 e9 2b ff ff ff <0f> 0b e9 00 ff ff ff e8 59 01 fb ff 85 c0 75 e4 48 c7 c2 20 62 6b
[ 646.464997] RSP: 0018:ffff880354d37068 EFLAGS: 00010286
[ 646.470599] RAX: 0000000000000000 RBX: ffffffffc0a52518 RCX: ffffffff8c2668db
[ 646.478118] RDX: 0000000000000003 RSI: dffffc0000000000 RDI: ffffffffc0a52518
[ 646.485641] RBP: ffffffffc0a52180 R08: fffffbfff814a4a4 R09: fffffbfff814a4a3
[ 646.493164] R10: ffffffffc0a5251b R11: fffffbfff814a4a4 R12: 1ffff1006a9a6e0d
[ 646.500687] R13: 00000000ffffffff R14: ffff880362bab890 R15: dead000000000100
[ 646.508213] FS: 00007f4164c99800(0000) GS:ffff88036fe40000(0000) knlGS:0000000000000000
[ 646.516961] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 646.523080] CR2: 00007f41638b8420 CR3: 0000000351df0004 CR4: 00000000001606e0
[ 646.530595] Call Trace:
[ 646.533408] ? find_symbol_in_section+0x260/0x260
[ 646.538509] tcf_ife_cleanup+0x11b/0x200 [act_ife]
[ 646.543695] tcf_action_cleanup+0x29/0xa0
[ 646.548078] __tcf_action_put+0x5a/0xb0
[ 646.552289] ? nla_put+0x65/0xe0
[ 646.555889] __tcf_idr_release+0x48/0x60
[ 646.560187] tcf_generic_walker+0x448/0x6b0
[ 646.564764] ? tcf_action_dump_1+0x450/0x450
[ 646.569411] ? __lock_is_held+0x84/0x110
[ 646.573720] ? tcf_ife_walker+0x10c/0x20f [act_ife]
[ 646.578982] tca_action_gd+0x972/0xc40
[ 646.583129] ? tca_get_fill.constprop.17+0x250/0x250
[ 646.588471] ? mark_lock+0xcf/0x980
[ 646.592324] ? check_chain_key+0x140/0x1f0
[ 646.596832] ? debug_show_all_locks+0x240/0x240
[ 646.601839] ? memset+0x1f/0x40
[ 646.605350] ? nla_parse+0xca/0x1a0
[ 646.609217] tc_ctl_action+0x215/0x230
[ 646.613339] ? tcf_action_add+0x220/0x220
[ 646.617748] rtnetlink_rcv_msg+0x56a/0x6d0
[ 646.622227] ? rtnl_fdb_del+0x3f0/0x3f0
[ 646.626466] netlink_rcv_skb+0x18d/0x200
[ 646.630752] ? rtnl_fdb_del+0x3f0/0x3f0
[ 646.634959] ? netlink_ack+0x500/0x500
[ 646.639106] netlink_unicast+0x2d0/0x370
[ 646.643409] ? netlink_attachskb+0x340/0x340
[ 646.648050] ? _copy_from_iter_full+0xe9/0x3e0
[ 646.652870] ? import_iovec+0x11e/0x1c0
[ 646.657083] netlink_sendmsg+0x3b9/0x6a0
[ 646.661388] ? netlink_unicast+0x370/0x370
[ 646.665877] ? netlink_unicast+0x370/0x370
[ 646.670351] sock_sendmsg+0x6b/0x80
[ 646.674212] ___sys_sendmsg+0x4a1/0x520
[ 646.678443] ? copy_msghdr_from_user+0x210/0x210
[ 646.683463] ? lock_downgrade+0x320/0x320
[ 646.687849] ? debug_show_all_locks+0x240/0x240
[ 646.692760] ? do_raw_spin_unlock+0xa2/0x130
[ 646.697418] ? _raw_spin_unlock+0x24/0x30
[ 646.701798] ? __handle_mm_fault+0x1819/0x1c10
[ 646.706619] ? __pmd_alloc+0x320/0x320
[ 646.710738] ? debug_show_all_locks+0x240/0x240
[ 646.715649] ? restore_nameidata+0x7b/0xa0
[ 646.720117] ? check_chain_key+0x140/0x1f0
[ 646.724590] ? check_chain_key+0x140/0x1f0
[ 646.729070] ? __fget_light+0xbc/0xd0
[ 646.733121] ? __sys_sendmsg+0xd7/0x150
[ 646.737329] __sys_sendmsg+0xd7/0x150
[ 646.741359] ? __ia32_sys_shutdown+0x30/0x30
[ 646.746003] ? up_read+0x53/0x90
[ 646.749601] ? __do_page_fault+0x484/0x780
[ 646.754105] ? do_syscall_64+0x1e/0x2c0
[ 646.758320] do_syscall_64+0x72/0x2c0
[ 646.762353] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[ 646.767776] RIP: 0033:0x7f4163872150
[ 646.771713] Code: 8b 15 3c 7d 2b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb cd 66 0f 1f 44 00 00 83 3d b9 d5 2b 00 00 75 10 b8 2e 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 be cd 00 00 48 89 04 24
[ 646.791474] RSP: 002b:00007ffdef7d6b58 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
[ 646.799721] RAX: ffffffffffffffda RBX: 0000000000000024 RCX: 00007f4163872150
[ 646.807240] RDX: 0000000000000000 RSI: 00007ffdef7d6bd0 RDI: 0000000000000003
[ 646.814760] RBP: 000000005b8b9482 R08: 0000000000000001 R09: 0000000000000000
[ 646.822286] R10: 00000000000005e7 R11: 0000000000000246 R12: 00007ffdef7dad20
[ 646.829807] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000679bc0
[ 646.837360] irq event stamp: 6083
[ 646.841043] hardirqs last enabled at (6081): [<ffffffff8c220a7d>] __call_rcu+0x17d/0x500
[ 646.849882] hardirqs last disabled at (6083): [<ffffffff8c004f06>] trace_hardirqs_off_thunk+0x1a/0x1c
[ 646.859775] softirqs last enabled at (5968): [<ffffffff8d4004a1>] __do_softirq+0x4a1/0x6ee
[ 646.868784] softirqs last disabled at (6082): [<ffffffffc0a78759>] tcf_ife_cleanup+0x39/0x200 [act_ife]
[ 646.878845] ---[ end trace b1b8c12ffe51e657 ]---
Fixes: 5ffe57da29
("act_ife: fix a potential deadlock")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
914 lines
20 KiB
C
914 lines
20 KiB
C
/*
|
|
* net/sched/ife.c Inter-FE action based on ForCES WG InterFE LFB
|
|
*
|
|
* Refer to:
|
|
* draft-ietf-forces-interfelfb-03
|
|
* and
|
|
* netdev01 paper:
|
|
* "Distributing Linux Traffic Control Classifier-Action
|
|
* Subsystem"
|
|
* Authors: Jamal Hadi Salim and Damascene M. Joachimpillai
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*
|
|
* copyright Jamal Hadi Salim (2015)
|
|
*
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/string.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/rtnetlink.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <net/net_namespace.h>
|
|
#include <net/netlink.h>
|
|
#include <net/pkt_sched.h>
|
|
#include <uapi/linux/tc_act/tc_ife.h>
|
|
#include <net/tc_act/tc_ife.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <net/ife.h>
|
|
|
|
static unsigned int ife_net_id;
|
|
static int max_metacnt = IFE_META_MAX + 1;
|
|
static struct tc_action_ops act_ife_ops;
|
|
|
|
static const struct nla_policy ife_policy[TCA_IFE_MAX + 1] = {
|
|
[TCA_IFE_PARMS] = { .len = sizeof(struct tc_ife)},
|
|
[TCA_IFE_DMAC] = { .len = ETH_ALEN},
|
|
[TCA_IFE_SMAC] = { .len = ETH_ALEN},
|
|
[TCA_IFE_TYPE] = { .type = NLA_U16},
|
|
};
|
|
|
|
int ife_encode_meta_u16(u16 metaval, void *skbdata, struct tcf_meta_info *mi)
|
|
{
|
|
u16 edata = 0;
|
|
|
|
if (mi->metaval)
|
|
edata = *(u16 *)mi->metaval;
|
|
else if (metaval)
|
|
edata = metaval;
|
|
|
|
if (!edata) /* will not encode */
|
|
return 0;
|
|
|
|
edata = htons(edata);
|
|
return ife_tlv_meta_encode(skbdata, mi->metaid, 2, &edata);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_encode_meta_u16);
|
|
|
|
int ife_get_meta_u32(struct sk_buff *skb, struct tcf_meta_info *mi)
|
|
{
|
|
if (mi->metaval)
|
|
return nla_put_u32(skb, mi->metaid, *(u32 *)mi->metaval);
|
|
else
|
|
return nla_put(skb, mi->metaid, 0, NULL);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_get_meta_u32);
|
|
|
|
int ife_check_meta_u32(u32 metaval, struct tcf_meta_info *mi)
|
|
{
|
|
if (metaval || mi->metaval)
|
|
return 8; /* T+L+V == 2+2+4 */
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_check_meta_u32);
|
|
|
|
int ife_check_meta_u16(u16 metaval, struct tcf_meta_info *mi)
|
|
{
|
|
if (metaval || mi->metaval)
|
|
return 8; /* T+L+(V) == 2+2+(2+2bytepad) */
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_check_meta_u16);
|
|
|
|
int ife_encode_meta_u32(u32 metaval, void *skbdata, struct tcf_meta_info *mi)
|
|
{
|
|
u32 edata = metaval;
|
|
|
|
if (mi->metaval)
|
|
edata = *(u32 *)mi->metaval;
|
|
else if (metaval)
|
|
edata = metaval;
|
|
|
|
if (!edata) /* will not encode */
|
|
return 0;
|
|
|
|
edata = htonl(edata);
|
|
return ife_tlv_meta_encode(skbdata, mi->metaid, 4, &edata);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_encode_meta_u32);
|
|
|
|
int ife_get_meta_u16(struct sk_buff *skb, struct tcf_meta_info *mi)
|
|
{
|
|
if (mi->metaval)
|
|
return nla_put_u16(skb, mi->metaid, *(u16 *)mi->metaval);
|
|
else
|
|
return nla_put(skb, mi->metaid, 0, NULL);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_get_meta_u16);
|
|
|
|
int ife_alloc_meta_u32(struct tcf_meta_info *mi, void *metaval, gfp_t gfp)
|
|
{
|
|
mi->metaval = kmemdup(metaval, sizeof(u32), gfp);
|
|
if (!mi->metaval)
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_alloc_meta_u32);
|
|
|
|
int ife_alloc_meta_u16(struct tcf_meta_info *mi, void *metaval, gfp_t gfp)
|
|
{
|
|
mi->metaval = kmemdup(metaval, sizeof(u16), gfp);
|
|
if (!mi->metaval)
|
|
return -ENOMEM;
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_alloc_meta_u16);
|
|
|
|
void ife_release_meta_gen(struct tcf_meta_info *mi)
|
|
{
|
|
kfree(mi->metaval);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_release_meta_gen);
|
|
|
|
int ife_validate_meta_u32(void *val, int len)
|
|
{
|
|
if (len == sizeof(u32))
|
|
return 0;
|
|
|
|
return -EINVAL;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_validate_meta_u32);
|
|
|
|
int ife_validate_meta_u16(void *val, int len)
|
|
{
|
|
/* length will not include padding */
|
|
if (len == sizeof(u16))
|
|
return 0;
|
|
|
|
return -EINVAL;
|
|
}
|
|
EXPORT_SYMBOL_GPL(ife_validate_meta_u16);
|
|
|
|
static LIST_HEAD(ifeoplist);
|
|
static DEFINE_RWLOCK(ife_mod_lock);
|
|
|
|
static struct tcf_meta_ops *find_ife_oplist(u16 metaid)
|
|
{
|
|
struct tcf_meta_ops *o;
|
|
|
|
read_lock(&ife_mod_lock);
|
|
list_for_each_entry(o, &ifeoplist, list) {
|
|
if (o->metaid == metaid) {
|
|
if (!try_module_get(o->owner))
|
|
o = NULL;
|
|
read_unlock(&ife_mod_lock);
|
|
return o;
|
|
}
|
|
}
|
|
read_unlock(&ife_mod_lock);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
int register_ife_op(struct tcf_meta_ops *mops)
|
|
{
|
|
struct tcf_meta_ops *m;
|
|
|
|
if (!mops->metaid || !mops->metatype || !mops->name ||
|
|
!mops->check_presence || !mops->encode || !mops->decode ||
|
|
!mops->get || !mops->alloc)
|
|
return -EINVAL;
|
|
|
|
write_lock(&ife_mod_lock);
|
|
|
|
list_for_each_entry(m, &ifeoplist, list) {
|
|
if (m->metaid == mops->metaid ||
|
|
(strcmp(mops->name, m->name) == 0)) {
|
|
write_unlock(&ife_mod_lock);
|
|
return -EEXIST;
|
|
}
|
|
}
|
|
|
|
if (!mops->release)
|
|
mops->release = ife_release_meta_gen;
|
|
|
|
list_add_tail(&mops->list, &ifeoplist);
|
|
write_unlock(&ife_mod_lock);
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(unregister_ife_op);
|
|
|
|
int unregister_ife_op(struct tcf_meta_ops *mops)
|
|
{
|
|
struct tcf_meta_ops *m;
|
|
int err = -ENOENT;
|
|
|
|
write_lock(&ife_mod_lock);
|
|
list_for_each_entry(m, &ifeoplist, list) {
|
|
if (m->metaid == mops->metaid) {
|
|
list_del(&mops->list);
|
|
err = 0;
|
|
break;
|
|
}
|
|
}
|
|
write_unlock(&ife_mod_lock);
|
|
|
|
return err;
|
|
}
|
|
EXPORT_SYMBOL_GPL(register_ife_op);
|
|
|
|
static int ife_validate_metatype(struct tcf_meta_ops *ops, void *val, int len)
|
|
{
|
|
int ret = 0;
|
|
/* XXX: unfortunately cant use nla_policy at this point
|
|
* because a length of 0 is valid in the case of
|
|
* "allow". "use" semantics do enforce for proper
|
|
* length and i couldve use nla_policy but it makes it hard
|
|
* to use it just for that..
|
|
*/
|
|
if (ops->validate)
|
|
return ops->validate(val, len);
|
|
|
|
if (ops->metatype == NLA_U32)
|
|
ret = ife_validate_meta_u32(val, len);
|
|
else if (ops->metatype == NLA_U16)
|
|
ret = ife_validate_meta_u16(val, len);
|
|
|
|
return ret;
|
|
}
|
|
|
|
#ifdef CONFIG_MODULES
|
|
static const char *ife_meta_id2name(u32 metaid)
|
|
{
|
|
switch (metaid) {
|
|
case IFE_META_SKBMARK:
|
|
return "skbmark";
|
|
case IFE_META_PRIO:
|
|
return "skbprio";
|
|
case IFE_META_TCINDEX:
|
|
return "tcindex";
|
|
default:
|
|
return "unknown";
|
|
}
|
|
}
|
|
#endif
|
|
|
|
/* called when adding new meta information
|
|
*/
|
|
static int load_metaops_and_vet(u32 metaid, void *val, int len, bool rtnl_held)
|
|
{
|
|
struct tcf_meta_ops *ops = find_ife_oplist(metaid);
|
|
int ret = 0;
|
|
|
|
if (!ops) {
|
|
ret = -ENOENT;
|
|
#ifdef CONFIG_MODULES
|
|
if (rtnl_held)
|
|
rtnl_unlock();
|
|
request_module("ife-meta-%s", ife_meta_id2name(metaid));
|
|
if (rtnl_held)
|
|
rtnl_lock();
|
|
ops = find_ife_oplist(metaid);
|
|
#endif
|
|
}
|
|
|
|
if (ops) {
|
|
ret = 0;
|
|
if (len)
|
|
ret = ife_validate_metatype(ops, val, len);
|
|
|
|
module_put(ops->owner);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
/* called when adding new meta information
|
|
*/
|
|
static int __add_metainfo(const struct tcf_meta_ops *ops,
|
|
struct tcf_ife_info *ife, u32 metaid, void *metaval,
|
|
int len, bool atomic, bool exists)
|
|
{
|
|
struct tcf_meta_info *mi = NULL;
|
|
int ret = 0;
|
|
|
|
mi = kzalloc(sizeof(*mi), atomic ? GFP_ATOMIC : GFP_KERNEL);
|
|
if (!mi)
|
|
return -ENOMEM;
|
|
|
|
mi->metaid = metaid;
|
|
mi->ops = ops;
|
|
if (len > 0) {
|
|
ret = ops->alloc(mi, metaval, atomic ? GFP_ATOMIC : GFP_KERNEL);
|
|
if (ret != 0) {
|
|
kfree(mi);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
if (exists)
|
|
spin_lock_bh(&ife->tcf_lock);
|
|
list_add_tail(&mi->metalist, &ife->metalist);
|
|
if (exists)
|
|
spin_unlock_bh(&ife->tcf_lock);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int add_metainfo_and_get_ops(const struct tcf_meta_ops *ops,
|
|
struct tcf_ife_info *ife, u32 metaid,
|
|
bool exists)
|
|
{
|
|
int ret;
|
|
|
|
if (!try_module_get(ops->owner))
|
|
return -ENOENT;
|
|
ret = __add_metainfo(ops, ife, metaid, NULL, 0, true, exists);
|
|
if (ret)
|
|
module_put(ops->owner);
|
|
return ret;
|
|
}
|
|
|
|
static int add_metainfo(struct tcf_ife_info *ife, u32 metaid, void *metaval,
|
|
int len, bool exists)
|
|
{
|
|
const struct tcf_meta_ops *ops = find_ife_oplist(metaid);
|
|
int ret;
|
|
|
|
if (!ops)
|
|
return -ENOENT;
|
|
ret = __add_metainfo(ops, ife, metaid, metaval, len, false, exists);
|
|
if (ret)
|
|
/*put back what find_ife_oplist took */
|
|
module_put(ops->owner);
|
|
return ret;
|
|
}
|
|
|
|
static int use_all_metadata(struct tcf_ife_info *ife, bool exists)
|
|
{
|
|
struct tcf_meta_ops *o;
|
|
int rc = 0;
|
|
int installed = 0;
|
|
|
|
read_lock(&ife_mod_lock);
|
|
list_for_each_entry(o, &ifeoplist, list) {
|
|
rc = add_metainfo_and_get_ops(o, ife, o->metaid, exists);
|
|
if (rc == 0)
|
|
installed += 1;
|
|
}
|
|
read_unlock(&ife_mod_lock);
|
|
|
|
if (installed)
|
|
return 0;
|
|
else
|
|
return -EINVAL;
|
|
}
|
|
|
|
static int dump_metalist(struct sk_buff *skb, struct tcf_ife_info *ife)
|
|
{
|
|
struct tcf_meta_info *e;
|
|
struct nlattr *nest;
|
|
unsigned char *b = skb_tail_pointer(skb);
|
|
int total_encoded = 0;
|
|
|
|
/*can only happen on decode */
|
|
if (list_empty(&ife->metalist))
|
|
return 0;
|
|
|
|
nest = nla_nest_start(skb, TCA_IFE_METALST);
|
|
if (!nest)
|
|
goto out_nlmsg_trim;
|
|
|
|
list_for_each_entry(e, &ife->metalist, metalist) {
|
|
if (!e->ops->get(skb, e))
|
|
total_encoded += 1;
|
|
}
|
|
|
|
if (!total_encoded)
|
|
goto out_nlmsg_trim;
|
|
|
|
nla_nest_end(skb, nest);
|
|
|
|
return 0;
|
|
|
|
out_nlmsg_trim:
|
|
nlmsg_trim(skb, b);
|
|
return -1;
|
|
}
|
|
|
|
/* under ife->tcf_lock */
|
|
static void _tcf_ife_cleanup(struct tc_action *a)
|
|
{
|
|
struct tcf_ife_info *ife = to_ife(a);
|
|
struct tcf_meta_info *e, *n;
|
|
|
|
list_for_each_entry_safe(e, n, &ife->metalist, metalist) {
|
|
list_del(&e->metalist);
|
|
if (e->metaval) {
|
|
if (e->ops->release)
|
|
e->ops->release(e);
|
|
else
|
|
kfree(e->metaval);
|
|
}
|
|
module_put(e->ops->owner);
|
|
kfree(e);
|
|
}
|
|
}
|
|
|
|
static void tcf_ife_cleanup(struct tc_action *a)
|
|
{
|
|
struct tcf_ife_info *ife = to_ife(a);
|
|
struct tcf_ife_params *p;
|
|
|
|
spin_lock_bh(&ife->tcf_lock);
|
|
_tcf_ife_cleanup(a);
|
|
spin_unlock_bh(&ife->tcf_lock);
|
|
|
|
p = rcu_dereference_protected(ife->params, 1);
|
|
if (p)
|
|
kfree_rcu(p, rcu);
|
|
}
|
|
|
|
static int populate_metalist(struct tcf_ife_info *ife, struct nlattr **tb,
|
|
bool exists, bool rtnl_held)
|
|
{
|
|
int len = 0;
|
|
int rc = 0;
|
|
int i = 0;
|
|
void *val;
|
|
|
|
for (i = 1; i < max_metacnt; i++) {
|
|
if (tb[i]) {
|
|
val = nla_data(tb[i]);
|
|
len = nla_len(tb[i]);
|
|
|
|
rc = load_metaops_and_vet(i, val, len, rtnl_held);
|
|
if (rc != 0)
|
|
return rc;
|
|
|
|
rc = add_metainfo(ife, i, val, len, exists);
|
|
if (rc)
|
|
return rc;
|
|
}
|
|
}
|
|
|
|
return rc;
|
|
}
|
|
|
|
static int tcf_ife_init(struct net *net, struct nlattr *nla,
|
|
struct nlattr *est, struct tc_action **a,
|
|
int ovr, int bind, bool rtnl_held,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
struct tc_action_net *tn = net_generic(net, ife_net_id);
|
|
struct nlattr *tb[TCA_IFE_MAX + 1];
|
|
struct nlattr *tb2[IFE_META_MAX + 1];
|
|
struct tcf_ife_params *p;
|
|
struct tcf_ife_info *ife;
|
|
u16 ife_type = ETH_P_IFE;
|
|
struct tc_ife *parm;
|
|
u8 *daddr = NULL;
|
|
u8 *saddr = NULL;
|
|
bool exists = false;
|
|
int ret = 0;
|
|
int err;
|
|
|
|
err = nla_parse_nested(tb, TCA_IFE_MAX, nla, ife_policy, NULL);
|
|
if (err < 0)
|
|
return err;
|
|
|
|
if (!tb[TCA_IFE_PARMS])
|
|
return -EINVAL;
|
|
|
|
parm = nla_data(tb[TCA_IFE_PARMS]);
|
|
|
|
/* IFE_DECODE is 0 and indicates the opposite of IFE_ENCODE because
|
|
* they cannot run as the same time. Check on all other values which
|
|
* are not supported right now.
|
|
*/
|
|
if (parm->flags & ~IFE_ENCODE)
|
|
return -EINVAL;
|
|
|
|
p = kzalloc(sizeof(*p), GFP_KERNEL);
|
|
if (!p)
|
|
return -ENOMEM;
|
|
|
|
err = tcf_idr_check_alloc(tn, &parm->index, a, bind);
|
|
if (err < 0) {
|
|
kfree(p);
|
|
return err;
|
|
}
|
|
exists = err;
|
|
if (exists && bind) {
|
|
kfree(p);
|
|
return 0;
|
|
}
|
|
|
|
if (!exists) {
|
|
ret = tcf_idr_create(tn, parm->index, est, a, &act_ife_ops,
|
|
bind, true);
|
|
if (ret) {
|
|
tcf_idr_cleanup(tn, parm->index);
|
|
kfree(p);
|
|
return ret;
|
|
}
|
|
ret = ACT_P_CREATED;
|
|
} else if (!ovr) {
|
|
tcf_idr_release(*a, bind);
|
|
kfree(p);
|
|
return -EEXIST;
|
|
}
|
|
|
|
ife = to_ife(*a);
|
|
p->flags = parm->flags;
|
|
|
|
if (parm->flags & IFE_ENCODE) {
|
|
if (tb[TCA_IFE_TYPE])
|
|
ife_type = nla_get_u16(tb[TCA_IFE_TYPE]);
|
|
if (tb[TCA_IFE_DMAC])
|
|
daddr = nla_data(tb[TCA_IFE_DMAC]);
|
|
if (tb[TCA_IFE_SMAC])
|
|
saddr = nla_data(tb[TCA_IFE_SMAC]);
|
|
}
|
|
|
|
if (parm->flags & IFE_ENCODE) {
|
|
if (daddr)
|
|
ether_addr_copy(p->eth_dst, daddr);
|
|
else
|
|
eth_zero_addr(p->eth_dst);
|
|
|
|
if (saddr)
|
|
ether_addr_copy(p->eth_src, saddr);
|
|
else
|
|
eth_zero_addr(p->eth_src);
|
|
|
|
p->eth_type = ife_type;
|
|
}
|
|
|
|
|
|
if (ret == ACT_P_CREATED)
|
|
INIT_LIST_HEAD(&ife->metalist);
|
|
|
|
if (tb[TCA_IFE_METALST]) {
|
|
err = nla_parse_nested(tb2, IFE_META_MAX, tb[TCA_IFE_METALST],
|
|
NULL, NULL);
|
|
if (err) {
|
|
metadata_parse_err:
|
|
tcf_idr_release(*a, bind);
|
|
kfree(p);
|
|
return err;
|
|
}
|
|
|
|
err = populate_metalist(ife, tb2, exists, rtnl_held);
|
|
if (err)
|
|
goto metadata_parse_err;
|
|
|
|
} else {
|
|
/* if no passed metadata allow list or passed allow-all
|
|
* then here we process by adding as many supported metadatum
|
|
* as we can. You better have at least one else we are
|
|
* going to bail out
|
|
*/
|
|
err = use_all_metadata(ife, exists);
|
|
if (err) {
|
|
tcf_idr_release(*a, bind);
|
|
kfree(p);
|
|
return err;
|
|
}
|
|
}
|
|
|
|
if (exists)
|
|
spin_lock_bh(&ife->tcf_lock);
|
|
ife->tcf_action = parm->action;
|
|
/* protected by tcf_lock when modifying existing action */
|
|
rcu_swap_protected(ife->params, p, 1);
|
|
|
|
if (exists)
|
|
spin_unlock_bh(&ife->tcf_lock);
|
|
if (p)
|
|
kfree_rcu(p, rcu);
|
|
|
|
if (ret == ACT_P_CREATED)
|
|
tcf_idr_insert(tn, *a);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int tcf_ife_dump(struct sk_buff *skb, struct tc_action *a, int bind,
|
|
int ref)
|
|
{
|
|
unsigned char *b = skb_tail_pointer(skb);
|
|
struct tcf_ife_info *ife = to_ife(a);
|
|
struct tcf_ife_params *p;
|
|
struct tc_ife opt = {
|
|
.index = ife->tcf_index,
|
|
.refcnt = refcount_read(&ife->tcf_refcnt) - ref,
|
|
.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind,
|
|
};
|
|
struct tcf_t t;
|
|
|
|
spin_lock_bh(&ife->tcf_lock);
|
|
opt.action = ife->tcf_action;
|
|
p = rcu_dereference_protected(ife->params,
|
|
lockdep_is_held(&ife->tcf_lock));
|
|
opt.flags = p->flags;
|
|
|
|
if (nla_put(skb, TCA_IFE_PARMS, sizeof(opt), &opt))
|
|
goto nla_put_failure;
|
|
|
|
tcf_tm_dump(&t, &ife->tcf_tm);
|
|
if (nla_put_64bit(skb, TCA_IFE_TM, sizeof(t), &t, TCA_IFE_PAD))
|
|
goto nla_put_failure;
|
|
|
|
if (!is_zero_ether_addr(p->eth_dst)) {
|
|
if (nla_put(skb, TCA_IFE_DMAC, ETH_ALEN, p->eth_dst))
|
|
goto nla_put_failure;
|
|
}
|
|
|
|
if (!is_zero_ether_addr(p->eth_src)) {
|
|
if (nla_put(skb, TCA_IFE_SMAC, ETH_ALEN, p->eth_src))
|
|
goto nla_put_failure;
|
|
}
|
|
|
|
if (nla_put(skb, TCA_IFE_TYPE, 2, &p->eth_type))
|
|
goto nla_put_failure;
|
|
|
|
if (dump_metalist(skb, ife)) {
|
|
/*ignore failure to dump metalist */
|
|
pr_info("Failed to dump metalist\n");
|
|
}
|
|
|
|
spin_unlock_bh(&ife->tcf_lock);
|
|
return skb->len;
|
|
|
|
nla_put_failure:
|
|
spin_unlock_bh(&ife->tcf_lock);
|
|
nlmsg_trim(skb, b);
|
|
return -1;
|
|
}
|
|
|
|
static int find_decode_metaid(struct sk_buff *skb, struct tcf_ife_info *ife,
|
|
u16 metaid, u16 mlen, void *mdata)
|
|
{
|
|
struct tcf_meta_info *e;
|
|
|
|
/* XXX: use hash to speed up */
|
|
list_for_each_entry(e, &ife->metalist, metalist) {
|
|
if (metaid == e->metaid) {
|
|
if (e->ops) {
|
|
/* We check for decode presence already */
|
|
return e->ops->decode(skb, mdata, mlen);
|
|
}
|
|
}
|
|
}
|
|
|
|
return -ENOENT;
|
|
}
|
|
|
|
static int tcf_ife_decode(struct sk_buff *skb, const struct tc_action *a,
|
|
struct tcf_result *res)
|
|
{
|
|
struct tcf_ife_info *ife = to_ife(a);
|
|
int action = ife->tcf_action;
|
|
u8 *ifehdr_end;
|
|
u8 *tlv_data;
|
|
u16 metalen;
|
|
|
|
bstats_cpu_update(this_cpu_ptr(ife->common.cpu_bstats), skb);
|
|
tcf_lastuse_update(&ife->tcf_tm);
|
|
|
|
if (skb_at_tc_ingress(skb))
|
|
skb_push(skb, skb->dev->hard_header_len);
|
|
|
|
tlv_data = ife_decode(skb, &metalen);
|
|
if (unlikely(!tlv_data)) {
|
|
qstats_drop_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
return TC_ACT_SHOT;
|
|
}
|
|
|
|
ifehdr_end = tlv_data + metalen;
|
|
for (; tlv_data < ifehdr_end; tlv_data = ife_tlv_meta_next(tlv_data)) {
|
|
u8 *curr_data;
|
|
u16 mtype;
|
|
u16 dlen;
|
|
|
|
curr_data = ife_tlv_meta_decode(tlv_data, ifehdr_end, &mtype,
|
|
&dlen, NULL);
|
|
if (!curr_data) {
|
|
qstats_drop_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
return TC_ACT_SHOT;
|
|
}
|
|
|
|
if (find_decode_metaid(skb, ife, mtype, dlen, curr_data)) {
|
|
/* abuse overlimits to count when we receive metadata
|
|
* but dont have an ops for it
|
|
*/
|
|
pr_info_ratelimited("Unknown metaid %d dlen %d\n",
|
|
mtype, dlen);
|
|
qstats_overlimit_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
}
|
|
}
|
|
|
|
if (WARN_ON(tlv_data != ifehdr_end)) {
|
|
qstats_drop_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
return TC_ACT_SHOT;
|
|
}
|
|
|
|
skb->protocol = eth_type_trans(skb, skb->dev);
|
|
skb_reset_network_header(skb);
|
|
|
|
return action;
|
|
}
|
|
|
|
/*XXX: check if we can do this at install time instead of current
|
|
* send data path
|
|
**/
|
|
static int ife_get_sz(struct sk_buff *skb, struct tcf_ife_info *ife)
|
|
{
|
|
struct tcf_meta_info *e, *n;
|
|
int tot_run_sz = 0, run_sz = 0;
|
|
|
|
list_for_each_entry_safe(e, n, &ife->metalist, metalist) {
|
|
if (e->ops->check_presence) {
|
|
run_sz = e->ops->check_presence(skb, e);
|
|
tot_run_sz += run_sz;
|
|
}
|
|
}
|
|
|
|
return tot_run_sz;
|
|
}
|
|
|
|
static int tcf_ife_encode(struct sk_buff *skb, const struct tc_action *a,
|
|
struct tcf_result *res, struct tcf_ife_params *p)
|
|
{
|
|
struct tcf_ife_info *ife = to_ife(a);
|
|
int action = ife->tcf_action;
|
|
struct ethhdr *oethh; /* outer ether header */
|
|
struct tcf_meta_info *e;
|
|
/*
|
|
OUTERHDR:TOTMETALEN:{TLVHDR:Metadatum:TLVHDR..}:ORIGDATA
|
|
where ORIGDATA = original ethernet header ...
|
|
*/
|
|
u16 metalen = ife_get_sz(skb, ife);
|
|
int hdrm = metalen + skb->dev->hard_header_len + IFE_METAHDRLEN;
|
|
unsigned int skboff = 0;
|
|
int new_len = skb->len + hdrm;
|
|
bool exceed_mtu = false;
|
|
void *ife_meta;
|
|
int err = 0;
|
|
|
|
if (!skb_at_tc_ingress(skb)) {
|
|
if (new_len > skb->dev->mtu)
|
|
exceed_mtu = true;
|
|
}
|
|
|
|
bstats_cpu_update(this_cpu_ptr(ife->common.cpu_bstats), skb);
|
|
tcf_lastuse_update(&ife->tcf_tm);
|
|
|
|
if (!metalen) { /* no metadata to send */
|
|
/* abuse overlimits to count when we allow packet
|
|
* with no metadata
|
|
*/
|
|
qstats_overlimit_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
return action;
|
|
}
|
|
/* could be stupid policy setup or mtu config
|
|
* so lets be conservative.. */
|
|
if ((action == TC_ACT_SHOT) || exceed_mtu) {
|
|
qstats_drop_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
return TC_ACT_SHOT;
|
|
}
|
|
|
|
if (skb_at_tc_ingress(skb))
|
|
skb_push(skb, skb->dev->hard_header_len);
|
|
|
|
ife_meta = ife_encode(skb, metalen);
|
|
|
|
spin_lock(&ife->tcf_lock);
|
|
|
|
/* XXX: we dont have a clever way of telling encode to
|
|
* not repeat some of the computations that are done by
|
|
* ops->presence_check...
|
|
*/
|
|
list_for_each_entry(e, &ife->metalist, metalist) {
|
|
if (e->ops->encode) {
|
|
err = e->ops->encode(skb, (void *)(ife_meta + skboff),
|
|
e);
|
|
}
|
|
if (err < 0) {
|
|
/* too corrupt to keep around if overwritten */
|
|
spin_unlock(&ife->tcf_lock);
|
|
qstats_drop_inc(this_cpu_ptr(ife->common.cpu_qstats));
|
|
return TC_ACT_SHOT;
|
|
}
|
|
skboff += err;
|
|
}
|
|
spin_unlock(&ife->tcf_lock);
|
|
oethh = (struct ethhdr *)skb->data;
|
|
|
|
if (!is_zero_ether_addr(p->eth_src))
|
|
ether_addr_copy(oethh->h_source, p->eth_src);
|
|
if (!is_zero_ether_addr(p->eth_dst))
|
|
ether_addr_copy(oethh->h_dest, p->eth_dst);
|
|
oethh->h_proto = htons(p->eth_type);
|
|
|
|
if (skb_at_tc_ingress(skb))
|
|
skb_pull(skb, skb->dev->hard_header_len);
|
|
|
|
return action;
|
|
}
|
|
|
|
static int tcf_ife_act(struct sk_buff *skb, const struct tc_action *a,
|
|
struct tcf_result *res)
|
|
{
|
|
struct tcf_ife_info *ife = to_ife(a);
|
|
struct tcf_ife_params *p;
|
|
int ret;
|
|
|
|
p = rcu_dereference_bh(ife->params);
|
|
if (p->flags & IFE_ENCODE) {
|
|
ret = tcf_ife_encode(skb, a, res, p);
|
|
return ret;
|
|
}
|
|
|
|
return tcf_ife_decode(skb, a, res);
|
|
}
|
|
|
|
static int tcf_ife_walker(struct net *net, struct sk_buff *skb,
|
|
struct netlink_callback *cb, int type,
|
|
const struct tc_action_ops *ops,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
struct tc_action_net *tn = net_generic(net, ife_net_id);
|
|
|
|
return tcf_generic_walker(tn, skb, cb, type, ops, extack);
|
|
}
|
|
|
|
static int tcf_ife_search(struct net *net, struct tc_action **a, u32 index,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
struct tc_action_net *tn = net_generic(net, ife_net_id);
|
|
|
|
return tcf_idr_search(tn, a, index);
|
|
}
|
|
|
|
static struct tc_action_ops act_ife_ops = {
|
|
.kind = "ife",
|
|
.type = TCA_ACT_IFE,
|
|
.owner = THIS_MODULE,
|
|
.act = tcf_ife_act,
|
|
.dump = tcf_ife_dump,
|
|
.cleanup = tcf_ife_cleanup,
|
|
.init = tcf_ife_init,
|
|
.walk = tcf_ife_walker,
|
|
.lookup = tcf_ife_search,
|
|
.size = sizeof(struct tcf_ife_info),
|
|
};
|
|
|
|
static __net_init int ife_init_net(struct net *net)
|
|
{
|
|
struct tc_action_net *tn = net_generic(net, ife_net_id);
|
|
|
|
return tc_action_net_init(tn, &act_ife_ops);
|
|
}
|
|
|
|
static void __net_exit ife_exit_net(struct list_head *net_list)
|
|
{
|
|
tc_action_net_exit(net_list, ife_net_id);
|
|
}
|
|
|
|
static struct pernet_operations ife_net_ops = {
|
|
.init = ife_init_net,
|
|
.exit_batch = ife_exit_net,
|
|
.id = &ife_net_id,
|
|
.size = sizeof(struct tc_action_net),
|
|
};
|
|
|
|
static int __init ife_init_module(void)
|
|
{
|
|
return tcf_register_action(&act_ife_ops, &ife_net_ops);
|
|
}
|
|
|
|
static void __exit ife_cleanup_module(void)
|
|
{
|
|
tcf_unregister_action(&act_ife_ops, &ife_net_ops);
|
|
}
|
|
|
|
module_init(ife_init_module);
|
|
module_exit(ife_cleanup_module);
|
|
|
|
MODULE_AUTHOR("Jamal Hadi Salim(2015)");
|
|
MODULE_DESCRIPTION("Inter-FE LFB action");
|
|
MODULE_LICENSE("GPL");
|