2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-24 13:13:57 +08:00
linux-next/net/l2tp
Tom Parkin 493048f5df l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge
l2tp_session_queue_purge is used during session shutdown to drop any
skbs queued for reordering purposes according to L2TP dataplane rules.

The BUG_ON in this function checks the session magic feather in an
attempt to catch lifetime bugs.

Rather than crashing the kernel with a BUG_ON, we can simply WARN_ON and
refuse to do anything more -- in the worst case this could result in a
leak.  However this is highly unlikely given that the session purge only
occurs from codepaths which have obtained the session by means of a lookup
via. the parent tunnel and which check the session "dead" flag to
protect against shutdown races.

While we're here, have l2tp_session_queue_purge return void rather than
an integer, since neither of the callsites checked the return value.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-07-24 17:19:14 -07:00
..
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
l2tp_core.c l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge 2020-07-24 17:19:14 -07:00
l2tp_core.h l2tp: prefer using BIT macro 2020-07-22 18:08:39 -07:00
l2tp_debugfs.c l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start 2020-07-24 17:19:14 -07:00
l2tp_eth.c l2tp: cleanup comments 2020-07-22 18:08:39 -07:00
l2tp_ip6.c l2tp: avoid multiple assignments 2020-07-24 17:19:14 -07:00
l2tp_ip.c l2tp: avoid multiple assignments 2020-07-24 17:19:14 -07:00
l2tp_netlink.c l2tp: cleanup netlink tunnel create address handling 2020-07-23 11:54:40 -07:00
l2tp_ppp.c l2tp: don't BUG_ON seqfile checks in l2tp_ppp 2020-07-24 17:19:14 -07:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00